1. 27 Apr, 2007 15 commits
  2. 26 Apr, 2007 25 commits
    • David S. Miller's avatar
      [AFS]: Fix u64 printing in debug logging. · ba3e0e1a
      David S. Miller authored
      Need 'unsigned long long' casts to quiet warnings on
      64-bit platforms when using %ll on a u64.
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ba3e0e1a
    • David Howells's avatar
      [AFS]: Add "directory write" support. · 260a9803
      David Howells authored
      Add support for the create, link, symlink, unlink, mkdir, rmdir and
      rename VFS operations to the in-kernel AFS filesystem.
      
      Also:
      
       (1) Fix dentry and inode revalidation.  d_revalidate should only look at
           state of the dentry.  Revalidation of the contents of an inode pointed to
           by a dentry is now separate.
      
       (2) Fix afs_lookup() to hash negative dentries as well as positive ones.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      260a9803
    • David Howells's avatar
      [AFS]: Implement the CB.InitCallBackState3 operation. · c35eccb1
      David Howells authored
      Implement the CB.InitCallBackState3 operation for the fileserver to
      call.  This reduces the amount of network traffic because if this op
      is aborted, the fileserver will then attempt an CB.InitCallBackState
      operation.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c35eccb1
    • David Howells's avatar
      [AFS]: Add support for the CB.GetCapabilities operation. · b908fe6b
      David Howells authored
      Add support for the CB.GetCapabilities operation with which the fileserver can
      ask the client for the following information:
      
       (1) The list of network interfaces it has available as IPv4 address + netmask
           plus the MTUs.
      
       (2) The client's UUID.
      
       (3) The extended capabilities of the client, for which the only current one
           is unified error mapping (abort code interpretation).
      
      To support this, the patch adds the following routines to AFS:
      
       (1) A function to iterate through all the network interfaces using RTNETLINK
           to extract IPv4 addresses and MTUs.
      
       (2) A function to iterate through all the network interfaces using RTNETLINK
           to pull out the MAC address of the lowest index interface to use in UUID
           construction.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b908fe6b
    • David Howells's avatar
      [AFS]: Update the AFS fs documentation. · 0795e7c0
      David Howells authored
      Update the AFS fs documentation.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0795e7c0
    • David Howells's avatar
      [AFS]: Add security support. · 00d3b7a4
      David Howells authored
      Add security support to the AFS filesystem.  Kerberos IV tickets are added as
      RxRPC keys are added to the session keyring with the klog program.  open() and
      other VFS operations then find this ticket with request_key() and either use
      it immediately (eg: mkdir, unlink) or attach it to a file descriptor (open).
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      00d3b7a4
    • David Howells's avatar
      [AFS]: Handle multiple mounts of an AFS superblock correctly. · 436058a4
      David Howells authored
      Handle multiple mounts of an AFS superblock correctly, checking to see
      whether the superblock is already initialised after calling sget()
      rather than just unconditionally stamping all over it.
      
      Also delete the "silent" parameter to afs_fill_super() as it's not
      used and can, in any case, be obtained from sb->s_flags.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      436058a4
    • David Howells's avatar
      [AF_RXRPC]: Delete the old RxRPC code. · 63b6be55
      David Howells authored
      Delete the old RxRPC code as it's now no longer used.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      63b6be55
    • David Howells's avatar
      [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC. · 08e0e7c8
      David Howells authored
      Make the in-kernel AFS filesystem use AF_RXRPC instead of the old RxRPC code.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      08e0e7c8
    • David Howells's avatar
      [AF_RXRPC]: Add an interface to the AF_RXRPC module for the AFS filesystem to use · 651350d1
      David Howells authored
      Add an interface to the AF_RXRPC module so that the AFS filesystem module can
      more easily make use of the services available.  AFS still opens a socket but
      then uses the action functions in lieu of sendmsg() and registers an intercept
      functions to grab messages before they're queued on the socket Rx queue.
      
      This permits AFS (or whatever) to:
      
       (1) Avoid the overhead of using the recvmsg() call.
      
       (2) Use different keys directly on individual client calls on one socket
           rather than having to open a whole slew of sockets, one for each key it
           might want to use.
      
       (3) Avoid calling request_key() at the point of issue of a call or opening of
           a socket.  This is done instead by AFS at the point of open(), unlink() or
           other VFS operation and the key handed through.
      
       (4) Request the use of something other than GFP_KERNEL to allocate memory.
      
      Furthermore:
      
       (*) The socket buffer markings used by RxRPC are made available for AFS so
           that it can interpret the cooked RxRPC messages itself.
      
       (*) rxgen (un)marshalling abort codes are made available.
      
      
      The following documentation for the kernel interface is added to
      Documentation/networking/rxrpc.txt:
      
      =========================
      AF_RXRPC KERNEL INTERFACE
      =========================
      
      The AF_RXRPC module also provides an interface for use by in-kernel utilities
      such as the AFS filesystem.  This permits such a utility to:
      
       (1) Use different keys directly on individual client calls on one socket
           rather than having to open a whole slew of sockets, one for each key it
           might want to use.
      
       (2) Avoid having RxRPC call request_key() at the point of issue of a call or
           opening of a socket.  Instead the utility is responsible for requesting a
           key at the appropriate point.  AFS, for instance, would do this during VFS
           operations such as open() or unlink().  The key is then handed through
           when the call is initiated.
      
       (3) Request the use of something other than GFP_KERNEL to allocate memory.
      
       (4) Avoid the overhead of using the recvmsg() call.  RxRPC messages can be
           intercepted before they get put into the socket Rx queue and the socket
           buffers manipulated directly.
      
      To use the RxRPC facility, a kernel utility must still open an AF_RXRPC socket,
      bind an addess as appropriate and listen if it's to be a server socket, but
      then it passes this to the kernel interface functions.
      
      The kernel interface functions are as follows:
      
       (*) Begin a new client call.
      
      	struct rxrpc_call *
      	rxrpc_kernel_begin_call(struct socket *sock,
      				struct sockaddr_rxrpc *srx,
      				struct key *key,
      				unsigned long user_call_ID,
      				gfp_t gfp);
      
           This allocates the infrastructure to make a new RxRPC call and assigns
           call and connection numbers.  The call will be made on the UDP port that
           the socket is bound to.  The call will go to the destination address of a
           connected client socket unless an alternative is supplied (srx is
           non-NULL).
      
           If a key is supplied then this will be used to secure the call instead of
           the key bound to the socket with the RXRPC_SECURITY_KEY sockopt.  Calls
           secured in this way will still share connections if at all possible.
      
           The user_call_ID is equivalent to that supplied to sendmsg() in the
           control data buffer.  It is entirely feasible to use this to point to a
           kernel data structure.
      
           If this function is successful, an opaque reference to the RxRPC call is
           returned.  The caller now holds a reference on this and it must be
           properly ended.
      
       (*) End a client call.
      
      	void rxrpc_kernel_end_call(struct rxrpc_call *call);
      
           This is used to end a previously begun call.  The user_call_ID is expunged
           from AF_RXRPC's knowledge and will not be seen again in association with
           the specified call.
      
       (*) Send data through a call.
      
      	int rxrpc_kernel_send_data(struct rxrpc_call *call, struct msghdr *msg,
      				   size_t len);
      
           This is used to supply either the request part of a client call or the
           reply part of a server call.  msg.msg_iovlen and msg.msg_iov specify the
           data buffers to be used.  msg_iov may not be NULL and must point
           exclusively to in-kernel virtual addresses.  msg.msg_flags may be given
           MSG_MORE if there will be subsequent data sends for this call.
      
           The msg must not specify a destination address, control data or any flags
           other than MSG_MORE.  len is the total amount of data to transmit.
      
       (*) Abort a call.
      
      	void rxrpc_kernel_abort_call(struct rxrpc_call *call, u32 abort_code);
      
           This is used to abort a call if it's still in an abortable state.  The
           abort code specified will be placed in the ABORT message sent.
      
       (*) Intercept received RxRPC messages.
      
      	typedef void (*rxrpc_interceptor_t)(struct sock *sk,
      					    unsigned long user_call_ID,
      					    struct sk_buff *skb);
      
      	void
      	rxrpc_kernel_intercept_rx_messages(struct socket *sock,
      					   rxrpc_interceptor_t interceptor);
      
           This installs an interceptor function on the specified AF_RXRPC socket.
           All messages that would otherwise wind up in the socket's Rx queue are
           then diverted to this function.  Note that care must be taken to process
           the messages in the right order to maintain DATA message sequentiality.
      
           The interceptor function itself is provided with the address of the socket
           and handling the incoming message, the ID assigned by the kernel utility
           to the call and the socket buffer containing the message.
      
           The skb->mark field indicates the type of message:
      
      	MARK				MEANING
      	===============================	=======================================
      	RXRPC_SKB_MARK_DATA		Data message
      	RXRPC_SKB_MARK_FINAL_ACK	Final ACK received for an incoming call
      	RXRPC_SKB_MARK_BUSY		Client call rejected as server busy
      	RXRPC_SKB_MARK_REMOTE_ABORT	Call aborted by peer
      	RXRPC_SKB_MARK_NET_ERROR	Network error detected
      	RXRPC_SKB_MARK_LOCAL_ERROR	Local error encountered
      	RXRPC_SKB_MARK_NEW_CALL		New incoming call awaiting acceptance
      
           The remote abort message can be probed with rxrpc_kernel_get_abort_code().
           The two error messages can be probed with rxrpc_kernel_get_error_number().
           A new call can be accepted with rxrpc_kernel_accept_call().
      
           Data messages can have their contents extracted with the usual bunch of
           socket buffer manipulation functions.  A data message can be determined to
           be the last one in a sequence with rxrpc_kernel_is_data_last().  When a
           data message has been used up, rxrpc_kernel_data_delivered() should be
           called on it..
      
           Non-data messages should be handled to rxrpc_kernel_free_skb() to dispose
           of.  It is possible to get extra refs on all types of message for later
           freeing, but this may pin the state of a call until the message is finally
           freed.
      
       (*) Accept an incoming call.
      
      	struct rxrpc_call *
      	rxrpc_kernel_accept_call(struct socket *sock,
      				 unsigned long user_call_ID);
      
           This is used to accept an incoming call and to assign it a call ID.  This
           function is similar to rxrpc_kernel_begin_call() and calls accepted must
           be ended in the same way.
      
           If this function is successful, an opaque reference to the RxRPC call is
           returned.  The caller now holds a reference on this and it must be
           properly ended.
      
       (*) Reject an incoming call.
      
      	int rxrpc_kernel_reject_call(struct socket *sock);
      
           This is used to reject the first incoming call on the socket's queue with
           a BUSY message.  -ENODATA is returned if there were no incoming calls.
           Other errors may be returned if the call had been aborted (-ECONNABORTED)
           or had timed out (-ETIME).
      
       (*) Record the delivery of a data message and free it.
      
      	void rxrpc_kernel_data_delivered(struct sk_buff *skb);
      
           This is used to record a data message as having been delivered and to
           update the ACK state for the call.  The socket buffer will be freed.
      
       (*) Free a message.
      
      	void rxrpc_kernel_free_skb(struct sk_buff *skb);
      
           This is used to free a non-DATA socket buffer intercepted from an AF_RXRPC
           socket.
      
       (*) Determine if a data message is the last one on a call.
      
      	bool rxrpc_kernel_is_data_last(struct sk_buff *skb);
      
           This is used to determine if a socket buffer holds the last data message
           to be received for a call (true will be returned if it does, false
           if not).
      
           The data message will be part of the reply on a client call and the
           request on an incoming call.  In the latter case there will be more
           messages, but in the former case there will not.
      
       (*) Get the abort code from an abort message.
      
      	u32 rxrpc_kernel_get_abort_code(struct sk_buff *skb);
      
           This is used to extract the abort code from a remote abort message.
      
       (*) Get the error number from a local or network error message.
      
      	int rxrpc_kernel_get_error_number(struct sk_buff *skb);
      
           This is used to extract the error number from a message indicating either
           a local error occurred or a network error occurred.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      651350d1
    • David Howells's avatar
      [AFS]: Clean up the AFS sources · ec26815a
      David Howells authored
      Clean up the AFS sources.
      
      Also remove references to AFS keys.  RxRPC keys are used instead.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ec26815a
    • David Howells's avatar
      [AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both · 17926a79
      David Howells authored
      Provide AF_RXRPC sockets that can be used to talk to AFS servers, or serve
      answers to AFS clients.  KerberosIV security is fully supported.  The patches
      and some example test programs can be found in:
      
      	http://people.redhat.com/~dhowells/rxrpc/
      
      This will eventually replace the old implementation of kernel-only RxRPC
      currently resident in net/rxrpc/.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      17926a79
    • David Howells's avatar
      [AF_RXRPC]: Make it possible to merely try to cancel timers from a module · e19dff1f
      David Howells authored
      Export try_to_del_timer_sync() for use by the AF_RXRPC module.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e19dff1f
    • David Howells's avatar
      [AF_RXRPC]: Key facility changes for AF_RXRPC · 7318226e
      David Howells authored
      Export the keyring key type definition and document its availability.
      
      Add alternative types into the key's type_data union to make it more useful.
      Not all users necessarily want to use it as a list_head (AF_RXRPC doesn't, for
      example), so make it clear that it can be used in other ways.
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7318226e
    • Oleg Nesterov's avatar
      [WORKQUEUE]: cancel_delayed_work: use del_timer() instead of del_timer_sync() · 071b6386
      Oleg Nesterov authored
      del_timer_sync() buys nothing for cancel_delayed_work(), but it is less
      efficient since it locks the timer unconditionally, and may wait for the
      completion of the delayed_work_timer_fn().
      
      cancel_delayed_work() == 0 means:
      
      	before this patch:
      		work->func may still be running or queued
      
      	after this patch:
      		work->func may still be running or queued, or
      		delayed_work_timer_fn->__queue_work() in progress.
      
      		The latter doesn't differ from the caller's POV,
      		delayed_work_timer_fn() is called with _PENDING
      		bit set.
      
      cancel_delayed_work() == 1 with this patch adds a new possibility:
      
      	delayed_work->work was cancelled, but delayed_work_timer_fn
      	is still running (this is only possible for the re-arming
      	works on single-threaded workqueue).
      
      	In this case the timer was re-started by work->func(), nobody
      	else can do this. This in turn means that delayed_work_timer_fn
      	has already passed __queue_work() (and wont't touch delayed_work)
      	because nobody else can queue delayed_work->work.
      Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
      Signed-Off-By: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      071b6386
    • Jamal Hadi Salim's avatar
      [XFRM]: Missing bits to SAD info. · 566ec034
      Jamal Hadi Salim authored
      This brings the SAD info in sync with net-2.6.22/net-2.6
      Signed-off-by: default avatarJamal Hadi Salim <hadi@cyberus.ca>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      566ec034
    • Matthias Kaehlcke's avatar
    • Andrew Morton's avatar
      [BLUETOOTH] rfcomm_worker(): fix wakeup race · 74da9d88
      Andrew Morton authored
      Set TASK_INTERRUPTIBLE prior to testing the flag to avoid missed wakeups.
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      74da9d88
    • Alexandra N. Kossovsky's avatar
      [NET]: bonding documentation fix for multiple bonding interfaces · 9198d222
      Alexandra N. Kossovsky authored
      Fix bonding driver documentation for the case of multiple bonding interfaces.
      Signed-off-by: default avatar"Alexandra N. Kossovsky" <Alexandra.Kossovsky@oktetlabs.ru>
      Acked-by: default avatarJay Vosburgh <fubar@us.ibm.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9198d222
    • Milind Arun Choudhary's avatar
      [NET]: SPIN_LOCK_UNLOCKED cleanup in drivers/atm, net · 4ef8d0ae
      Milind Arun Choudhary authored
      SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead
      Signed-off-by: default avatarMilind Arun Choudhary <milindchoudhary@gmail.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4ef8d0ae
    • Andrew Morton's avatar
    • Martin Peschke's avatar
      [SUNRPC]: cleanup: use seq_release_private() where appropriate · 14690fc6
      Martin Peschke authored
      We can save some lines of code by using seq_release_private().
      Signed-off-by: default avatarMartin Peschke <mp3@de.ibm.com>
      Acked-by: default avatarNeil Brown <neilb@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      14690fc6
    • Alexey Dobriyan's avatar
      [AF_IUCV]: Fix compilation on s390-up · f8a6d970
      Alexey Dobriyan authored
        CC [M]  net/iucv/iucv.o
      net/iucv/iucv.c: In function 'iucv_init':
      net/iucv/iucv.c:1556: error: 'iucv_cpu_notifier' undeclared (first use in this function)
      Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f8a6d970
    • Milind Arun Choudhary's avatar
      57cd5f75
    • Brian Braunstein's avatar
      [NET] tun/tap: fixed hw address handling · 36226a8d
      Brian Braunstein authored
      Fixed tun/tap driver's handling of hw addresses.  The hw address is stored
      in both the net_device.dev_addr and tun.dev_addr fields.  These fields were
      not kept synchronized, and in fact weren't even initialized to the same
      value.  Now during both init and when performing SIOCSIFHWADDR on the tun
      device these values are both updated.  However, if SIOCSIFHWADDR is
      performed on the net device directly (for instance, setting the hw address
      using ifconfig), the tun device does not get updated.  Perhaps the
      tun.dev_addr field should be removed completely at some point, as it is
      redundant and net_device.dev_addr can be used anywhere it is used.
      Signed-off-by: default avatarBrian Braunstein <linuxkernel@bristyle.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      36226a8d