Commit ec572e3f authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Linus Torvalds

[PATCH] msi: Only keep one msi_desc in each slab entry.

It looks like someone confused kmem_cache_create with a different allocator
and was attempting to give it knowledge of how many cache entries there
were.

With the unfortunate result that each slab entry was big enough to hold
every irq.
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 0635170b
...@@ -47,13 +47,13 @@ msi_register(struct msi_ops *ops) ...@@ -47,13 +47,13 @@ msi_register(struct msi_ops *ops)
static void msi_cache_ctor(void *p, kmem_cache_t *cache, unsigned long flags) static void msi_cache_ctor(void *p, kmem_cache_t *cache, unsigned long flags)
{ {
memset(p, 0, NR_IRQS * sizeof(struct msi_desc)); memset(p, 0, sizeof(struct msi_desc));
} }
static int msi_cache_init(void) static int msi_cache_init(void)
{ {
msi_cachep = kmem_cache_create("msi_cache", msi_cachep = kmem_cache_create("msi_cache",
NR_IRQS * sizeof(struct msi_desc), sizeof(struct msi_desc),
0, SLAB_HWCACHE_ALIGN, msi_cache_ctor, NULL); 0, SLAB_HWCACHE_ALIGN, msi_cache_ctor, NULL);
if (!msi_cachep) if (!msi_cachep)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment