Commit d35a1b9e authored by Georg Chini's avatar Georg Chini Committed by David S. Miller

[SOUND] Sparc CS4231: Fix IRQ return value and initialization.

SBUS: Change IRQ-handler return value from 0 to IRQ_HANDLED and
fix some initialisation problems.

Change period_bytes_min from 4096 to 256 to allow driver to work with
low latency (VOIP) applications. Hope this does not break EBUS.
Signed-off-by: default avatarGeorg Chini <georg.chini@triaton-webhosting.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a7ec3f52
...@@ -1268,7 +1268,7 @@ static struct snd_pcm_hardware snd_cs4231_playback = ...@@ -1268,7 +1268,7 @@ static struct snd_pcm_hardware snd_cs4231_playback =
.channels_min = 1, .channels_min = 1,
.channels_max = 2, .channels_max = 2,
.buffer_bytes_max = (32*1024), .buffer_bytes_max = (32*1024),
.period_bytes_min = 4096, .period_bytes_min = 256,
.period_bytes_max = (32*1024), .period_bytes_max = (32*1024),
.periods_min = 1, .periods_min = 1,
.periods_max = 1024, .periods_max = 1024,
...@@ -1288,7 +1288,7 @@ static struct snd_pcm_hardware snd_cs4231_capture = ...@@ -1288,7 +1288,7 @@ static struct snd_pcm_hardware snd_cs4231_capture =
.channels_min = 1, .channels_min = 1,
.channels_max = 2, .channels_max = 2,
.buffer_bytes_max = (32*1024), .buffer_bytes_max = (32*1024),
.period_bytes_min = 4096, .period_bytes_min = 256,
.period_bytes_max = (32*1024), .period_bytes_max = (32*1024),
.periods_min = 1, .periods_min = 1,
.periods_max = 1024, .periods_max = 1024,
...@@ -1796,7 +1796,7 @@ static irqreturn_t snd_cs4231_sbus_interrupt(int irq, void *dev_id) ...@@ -1796,7 +1796,7 @@ static irqreturn_t snd_cs4231_sbus_interrupt(int irq, void *dev_id)
snd_cs4231_outm(chip, CS4231_IRQ_STATUS, ~CS4231_ALL_IRQS | ~status, 0); snd_cs4231_outm(chip, CS4231_IRQ_STATUS, ~CS4231_ALL_IRQS | ~status, 0);
spin_unlock_irqrestore(&chip->lock, flags); spin_unlock_irqrestore(&chip->lock, flags);
return 0; return IRQ_HANDLED;
} }
/* /*
...@@ -1821,7 +1821,6 @@ static int sbus_dma_request(struct cs4231_dma_control *dma_cont, dma_addr_t bus_ ...@@ -1821,7 +1821,6 @@ static int sbus_dma_request(struct cs4231_dma_control *dma_cont, dma_addr_t bus_
if (!(csr & test)) if (!(csr & test))
goto out; goto out;
err = -EBUSY; err = -EBUSY;
csr = sbus_readl(base->regs + APCCSR);
test = APC_XINT_CNVA; test = APC_XINT_CNVA;
if ( base->dir == APC_PLAY ) if ( base->dir == APC_PLAY )
test = APC_XINT_PNVA; test = APC_XINT_PNVA;
...@@ -1862,17 +1861,16 @@ static void sbus_dma_enable(struct cs4231_dma_control *dma_cont, int on) ...@@ -1862,17 +1861,16 @@ static void sbus_dma_enable(struct cs4231_dma_control *dma_cont, int on)
spin_lock_irqsave(&base->lock, flags); spin_lock_irqsave(&base->lock, flags);
if (!on) { if (!on) {
if (base->dir == APC_PLAY) { sbus_writel(0, base->regs + base->dir + APCNC);
sbus_writel(0, base->regs + base->dir + APCNVA); sbus_writel(0, base->regs + base->dir + APCNVA);
sbus_writel(1, base->regs + base->dir + APCC); sbus_writel(0, base->regs + base->dir + APCC);
} sbus_writel(0, base->regs + base->dir + APCVA);
else
{ /* ACK any APC interrupts. */
sbus_writel(0, base->regs + base->dir + APCNC); csr = sbus_readl(base->regs + APCCSR);
sbus_writel(0, base->regs + base->dir + APCVA); sbus_writel(csr, base->regs + APCCSR);
}
} }
udelay(600); udelay(1000);
csr = sbus_readl(base->regs + APCCSR); csr = sbus_readl(base->regs + APCCSR);
shift = 0; shift = 0;
if ( base->dir == APC_PLAY ) if ( base->dir == APC_PLAY )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment