Commit c387fd85 authored by Jiri Slaby's avatar Jiri Slaby Committed by Linus Torvalds

[PATCH] Char: isicom, fix close bug

port is dereferenced even if it is NULL.  Dereference it _after_ the
check if (!port)...  Thanks Eric <ef87@yahoo.com> for reporting this.

This fixes

	http://bugzilla.kernel.org/show_bug.cgi?id=7527Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent f5ad1a78
...@@ -1062,11 +1062,12 @@ static void isicom_shutdown_port(struct isi_port *port) ...@@ -1062,11 +1062,12 @@ static void isicom_shutdown_port(struct isi_port *port)
static void isicom_close(struct tty_struct *tty, struct file *filp) static void isicom_close(struct tty_struct *tty, struct file *filp)
{ {
struct isi_port *port = tty->driver_data; struct isi_port *port = tty->driver_data;
struct isi_board *card = port->card; struct isi_board *card;
unsigned long flags; unsigned long flags;
if (!port) if (!port)
return; return;
card = port->card;
if (isicom_paranoia_check(port, tty->name, "isicom_close")) if (isicom_paranoia_check(port, tty->name, "isicom_close"))
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment