Commit 95688e97 authored by Adrian Bunk's avatar Adrian Bunk Committed by Stefan Richter

firewire: cleanups

This patch contains the following cleanups:
- "extern inline" -> "static inline"
- fw-topology.c: make struct fw_node_create static
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 21ebcd12
...@@ -147,7 +147,7 @@ struct fw_ohci { ...@@ -147,7 +147,7 @@ struct fw_ohci {
struct iso_context *ir_context_list; struct iso_context *ir_context_list;
}; };
extern inline struct fw_ohci *fw_ohci(struct fw_card *card) static inline struct fw_ohci *fw_ohci(struct fw_card *card)
{ {
return container_of(card, struct fw_ohci, card); return container_of(card, struct fw_ohci, card);
} }
...@@ -174,17 +174,17 @@ extern inline struct fw_ohci *fw_ohci(struct fw_card *card) ...@@ -174,17 +174,17 @@ extern inline struct fw_ohci *fw_ohci(struct fw_card *card)
static char ohci_driver_name[] = KBUILD_MODNAME; static char ohci_driver_name[] = KBUILD_MODNAME;
extern inline void reg_write(const struct fw_ohci *ohci, int offset, u32 data) static inline void reg_write(const struct fw_ohci *ohci, int offset, u32 data)
{ {
writel(data, ohci->registers + offset); writel(data, ohci->registers + offset);
} }
extern inline u32 reg_read(const struct fw_ohci *ohci, int offset) static inline u32 reg_read(const struct fw_ohci *ohci, int offset)
{ {
return readl(ohci->registers + offset); return readl(ohci->registers + offset);
} }
extern inline void flush_writes(const struct fw_ohci *ohci) static inline void flush_writes(const struct fw_ohci *ohci)
{ {
/* Do a dummy read to flush writes. */ /* Do a dummy read to flush writes. */
reg_read(ohci, OHCI1394_Version); reg_read(ohci, OHCI1394_Version);
......
...@@ -92,7 +92,7 @@ static int get_port_type(u32 *sid, int port_index) ...@@ -92,7 +92,7 @@ static int get_port_type(u32 *sid, int port_index)
return (sid[index] >> shift) & 0x03; return (sid[index] >> shift) & 0x03;
} }
struct fw_node *fw_node_create(u32 sid, int port_count, int color) static struct fw_node *fw_node_create(u32 sid, int port_count, int color)
{ {
struct fw_node *node; struct fw_node *node;
......
...@@ -57,13 +57,13 @@ struct fw_node { ...@@ -57,13 +57,13 @@ struct fw_node {
struct fw_port ports[0]; struct fw_port ports[0];
}; };
extern inline struct fw_node * static inline struct fw_node *
fw_node(struct list_head *l) fw_node(struct list_head *l)
{ {
return list_entry (l, struct fw_node, link); return list_entry (l, struct fw_node, link);
} }
extern inline struct fw_node * static inline struct fw_node *
fw_node_get(struct fw_node *node) fw_node_get(struct fw_node *node)
{ {
atomic_inc(&node->ref_count); atomic_inc(&node->ref_count);
...@@ -71,7 +71,7 @@ fw_node_get(struct fw_node *node) ...@@ -71,7 +71,7 @@ fw_node_get(struct fw_node *node)
return node; return node;
} }
extern inline void static inline void
fw_node_put(struct fw_node *node) fw_node_put(struct fw_node *node)
{ {
if (atomic_dec_and_test(&node->ref_count)) if (atomic_dec_and_test(&node->ref_count))
......
...@@ -106,7 +106,7 @@ transmit_complete_callback(struct fw_packet *packet, ...@@ -106,7 +106,7 @@ transmit_complete_callback(struct fw_packet *packet,
} }
} }
void static void
fw_fill_packet(struct fw_packet *packet, int tcode, int tlabel, fw_fill_packet(struct fw_packet *packet, int tcode, int tlabel,
int node_id, int generation, int speed, int node_id, int generation, int speed,
unsigned long long offset, void *payload, size_t length) unsigned long long offset, void *payload, size_t length)
......
...@@ -198,7 +198,7 @@ struct fw_transaction { ...@@ -198,7 +198,7 @@ struct fw_transaction {
void *callback_data; void *callback_data;
}; };
extern inline struct fw_packet * static inline struct fw_packet *
fw_packet(struct list_head *l) fw_packet(struct list_head *l)
{ {
return list_entry (l, struct fw_packet, link); return list_entry (l, struct fw_packet, link);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment