Commit 829ca9a3 authored by Pavel Machek's avatar Pavel Machek Committed by Linus Torvalds

[PATCH] swsusp: fix remaining u32 vs. pm_message_t confusion

Fix remaining bits of u32 vs.  pm_message confusion.  Should not break
anything.
Signed-off-by: default avatarPavel Machek <pavel@suse.cz>
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 7e958883
...@@ -561,7 +561,7 @@ struct mtrr_value { ...@@ -561,7 +561,7 @@ struct mtrr_value {
static struct mtrr_value * mtrr_state; static struct mtrr_value * mtrr_state;
static int mtrr_save(struct sys_device * sysdev, u32 state) static int mtrr_save(struct sys_device * sysdev, pm_message_t state)
{ {
int i; int i;
int size = num_var_ranges * sizeof(struct mtrr_value); int size = num_var_ranges * sizeof(struct mtrr_value);
......
...@@ -619,7 +619,7 @@ not_found: ...@@ -619,7 +619,7 @@ not_found:
return viaint; return viaint;
} }
static int pmacpic_suspend(struct sys_device *sysdev, u32 state) static int pmacpic_suspend(struct sys_device *sysdev, pm_message_t state)
{ {
int viaint = pmacpic_find_viaint(); int viaint = pmacpic_find_viaint();
......
...@@ -948,7 +948,7 @@ static void openpic_cached_disable_irq(u_int irq) ...@@ -948,7 +948,7 @@ static void openpic_cached_disable_irq(u_int irq)
* we need something better to deal with that... Maybe switch to S1 for * we need something better to deal with that... Maybe switch to S1 for
* cpufreq changes * cpufreq changes
*/ */
int openpic_suspend(struct sys_device *sysdev, u32 state) int openpic_suspend(struct sys_device *sysdev, pm_message_t state)
{ {
int i; int i;
unsigned long flags; unsigned long flags;
......
...@@ -290,7 +290,7 @@ void enable_timer_nmi_watchdog(void) ...@@ -290,7 +290,7 @@ void enable_timer_nmi_watchdog(void)
static int nmi_pm_active; /* nmi_active before suspend */ static int nmi_pm_active; /* nmi_active before suspend */
static int lapic_nmi_suspend(struct sys_device *dev, u32 state) static int lapic_nmi_suspend(struct sys_device *dev, pm_message_t state)
{ {
nmi_pm_active = nmi_active; nmi_pm_active = nmi_active;
disable_lapic_nmi_watchdog(); disable_lapic_nmi_watchdog();
......
...@@ -1504,7 +1504,7 @@ pmac_ide_macio_attach(struct macio_dev *mdev, const struct of_device_id *match) ...@@ -1504,7 +1504,7 @@ pmac_ide_macio_attach(struct macio_dev *mdev, const struct of_device_id *match)
} }
static int static int
pmac_ide_macio_suspend(struct macio_dev *mdev, u32 state) pmac_ide_macio_suspend(struct macio_dev *mdev, pm_message_t state)
{ {
ide_hwif_t *hwif = (ide_hwif_t *)dev_get_drvdata(&mdev->ofdev.dev); ide_hwif_t *hwif = (ide_hwif_t *)dev_get_drvdata(&mdev->ofdev.dev);
int rc = 0; int rc = 0;
...@@ -1527,7 +1527,7 @@ pmac_ide_macio_resume(struct macio_dev *mdev) ...@@ -1527,7 +1527,7 @@ pmac_ide_macio_resume(struct macio_dev *mdev)
if (mdev->ofdev.dev.power.power_state != 0) { if (mdev->ofdev.dev.power.power_state != 0) {
rc = pmac_ide_do_resume(hwif); rc = pmac_ide_do_resume(hwif);
if (rc == 0) if (rc == 0)
mdev->ofdev.dev.power.power_state = 0; mdev->ofdev.dev.power.power_state = PMSG_ON;
} }
return rc; return rc;
...@@ -1608,7 +1608,7 @@ pmac_ide_pci_attach(struct pci_dev *pdev, const struct pci_device_id *id) ...@@ -1608,7 +1608,7 @@ pmac_ide_pci_attach(struct pci_dev *pdev, const struct pci_device_id *id)
} }
static int static int
pmac_ide_pci_suspend(struct pci_dev *pdev, u32 state) pmac_ide_pci_suspend(struct pci_dev *pdev, pm_message_t state)
{ {
ide_hwif_t *hwif = (ide_hwif_t *)pci_get_drvdata(pdev); ide_hwif_t *hwif = (ide_hwif_t *)pci_get_drvdata(pdev);
int rc = 0; int rc = 0;
...@@ -1631,7 +1631,7 @@ pmac_ide_pci_resume(struct pci_dev *pdev) ...@@ -1631,7 +1631,7 @@ pmac_ide_pci_resume(struct pci_dev *pdev)
if (pdev->dev.power.power_state != 0) { if (pdev->dev.power.power_state != 0) {
rc = pmac_ide_do_resume(hwif); rc = pmac_ide_do_resume(hwif);
if (rc == 0) if (rc == 0)
pdev->dev.power.power_state = 0; pdev->dev.power.power_state = PMSG_ON;
} }
return rc; return rc;
......
...@@ -724,7 +724,7 @@ static int __pmac media_bay_resume(struct macio_dev *mdev) ...@@ -724,7 +724,7 @@ static int __pmac media_bay_resume(struct macio_dev *mdev)
struct media_bay_info *bay = macio_get_drvdata(mdev); struct media_bay_info *bay = macio_get_drvdata(mdev);
if (mdev->ofdev.dev.power.power_state != 0) { if (mdev->ofdev.dev.power.power_state != 0) {
mdev->ofdev.dev.power.power_state = 0; mdev->ofdev.dev.power.power_state = PMSG_ON;
/* We re-enable the bay using it's previous content /* We re-enable the bay using it's previous content
only if it did not change. Note those bozo timings, only if it did not change. Note those bozo timings,
......
...@@ -4047,7 +4047,6 @@ static int bttv_suspend(struct pci_dev *pci_dev, pm_message_t state) ...@@ -4047,7 +4047,6 @@ static int bttv_suspend(struct pci_dev *pci_dev, pm_message_t state)
struct bttv_buffer_set idle; struct bttv_buffer_set idle;
unsigned long flags; unsigned long flags;
dprintk("bttv%d: suspend %d\n", btv->c.nr, state);
/* stop dma + irqs */ /* stop dma + irqs */
spin_lock_irqsave(&btv->s_lock,flags); spin_lock_irqsave(&btv->s_lock,flags);
......
...@@ -1416,7 +1416,7 @@ static int msp_detach(struct i2c_client *client); ...@@ -1416,7 +1416,7 @@ static int msp_detach(struct i2c_client *client);
static int msp_probe(struct i2c_adapter *adap); static int msp_probe(struct i2c_adapter *adap);
static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg); static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg);
static int msp_suspend(struct device * dev, u32 state, u32 level); static int msp_suspend(struct device * dev, pm_message_t state, u32 level);
static int msp_resume(struct device * dev, u32 level); static int msp_resume(struct device * dev, u32 level);
static void msp_wake_thread(struct i2c_client *client); static void msp_wake_thread(struct i2c_client *client);
...@@ -1817,7 +1817,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg) ...@@ -1817,7 +1817,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
return 0; return 0;
} }
static int msp_suspend(struct device * dev, u32 state, u32 level) static int msp_suspend(struct device * dev, pm_message_t state, u32 level)
{ {
struct i2c_client *c = container_of(dev, struct i2c_client, dev); struct i2c_client *c = container_of(dev, struct i2c_client, dev);
......
...@@ -760,7 +760,7 @@ tda9887_command(struct i2c_client *client, unsigned int cmd, void *arg) ...@@ -760,7 +760,7 @@ tda9887_command(struct i2c_client *client, unsigned int cmd, void *arg)
return 0; return 0;
} }
static int tda9887_suspend(struct device * dev, u32 state, u32 level) static int tda9887_suspend(struct device * dev, pm_message_t state, u32 level)
{ {
dprintk("tda9887: suspend\n"); dprintk("tda9887: suspend\n");
return 0; return 0;
......
...@@ -672,7 +672,7 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg) ...@@ -672,7 +672,7 @@ static int tuner_command(struct i2c_client *client, unsigned int cmd, void *arg)
return 0; return 0;
} }
static int tuner_suspend(struct device *dev, u32 state, u32 level) static int tuner_suspend(struct device *dev, pm_message_t state, u32 level)
{ {
struct i2c_client *c = container_of (dev, struct i2c_client, dev); struct i2c_client *c = container_of (dev, struct i2c_client, dev);
struct tuner *t = i2c_get_clientdata (c); struct tuner *t = i2c_get_clientdata (c);
......
...@@ -2004,14 +2004,14 @@ bnx2_init_cpus(struct bnx2 *bp) ...@@ -2004,14 +2004,14 @@ bnx2_init_cpus(struct bnx2 *bp)
} }
static int static int
bnx2_set_power_state(struct bnx2 *bp, int state) bnx2_set_power_state(struct bnx2 *bp, pci_power_t state)
{ {
u16 pmcsr; u16 pmcsr;
pci_read_config_word(bp->pdev, bp->pm_cap + PCI_PM_CTRL, &pmcsr); pci_read_config_word(bp->pdev, bp->pm_cap + PCI_PM_CTRL, &pmcsr);
switch (state) { switch (state) {
case 0: { case PCI_D0: {
u32 val; u32 val;
pci_write_config_word(bp->pdev, bp->pm_cap + PCI_PM_CTRL, pci_write_config_word(bp->pdev, bp->pm_cap + PCI_PM_CTRL,
...@@ -2032,7 +2032,7 @@ bnx2_set_power_state(struct bnx2 *bp, int state) ...@@ -2032,7 +2032,7 @@ bnx2_set_power_state(struct bnx2 *bp, int state)
REG_WR(bp, BNX2_RPM_CONFIG, val); REG_WR(bp, BNX2_RPM_CONFIG, val);
break; break;
} }
case 3: { case PCI_D3hot: {
int i; int i;
u32 val, wol_msg; u32 val, wol_msg;
...@@ -3886,7 +3886,7 @@ bnx2_open(struct net_device *dev) ...@@ -3886,7 +3886,7 @@ bnx2_open(struct net_device *dev)
struct bnx2 *bp = dev->priv; struct bnx2 *bp = dev->priv;
int rc; int rc;
bnx2_set_power_state(bp, 0); bnx2_set_power_state(bp, PCI_D0);
bnx2_disable_int(bp); bnx2_disable_int(bp);
rc = bnx2_alloc_mem(bp); rc = bnx2_alloc_mem(bp);
...@@ -4197,7 +4197,7 @@ bnx2_close(struct net_device *dev) ...@@ -4197,7 +4197,7 @@ bnx2_close(struct net_device *dev)
bnx2_free_mem(bp); bnx2_free_mem(bp);
bp->link_up = 0; bp->link_up = 0;
netif_carrier_off(bp->dev); netif_carrier_off(bp->dev);
bnx2_set_power_state(bp, 3); bnx2_set_power_state(bp, PCI_D3hot);
return 0; return 0;
} }
...@@ -5203,7 +5203,7 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) ...@@ -5203,7 +5203,7 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
BNX2_PCICFG_MISC_CONFIG_REG_WINDOW_ENA | BNX2_PCICFG_MISC_CONFIG_REG_WINDOW_ENA |
BNX2_PCICFG_MISC_CONFIG_TARGET_MB_WORD_SWAP); BNX2_PCICFG_MISC_CONFIG_TARGET_MB_WORD_SWAP);
bnx2_set_power_state(bp, 0); bnx2_set_power_state(bp, PCI_D0);
bp->chip_id = REG_RD(bp, BNX2_MISC_ID); bp->chip_id = REG_RD(bp, BNX2_MISC_ID);
...@@ -5495,7 +5495,7 @@ bnx2_remove_one(struct pci_dev *pdev) ...@@ -5495,7 +5495,7 @@ bnx2_remove_one(struct pci_dev *pdev)
} }
static int static int
bnx2_suspend(struct pci_dev *pdev, u32 state) bnx2_suspend(struct pci_dev *pdev, pm_message_t state)
{ {
struct net_device *dev = pci_get_drvdata(pdev); struct net_device *dev = pci_get_drvdata(pdev);
struct bnx2 *bp = dev->priv; struct bnx2 *bp = dev->priv;
...@@ -5513,7 +5513,7 @@ bnx2_suspend(struct pci_dev *pdev, u32 state) ...@@ -5513,7 +5513,7 @@ bnx2_suspend(struct pci_dev *pdev, u32 state)
reset_code = BNX2_DRV_MSG_CODE_SUSPEND_NO_WOL; reset_code = BNX2_DRV_MSG_CODE_SUSPEND_NO_WOL;
bnx2_reset_chip(bp, reset_code); bnx2_reset_chip(bp, reset_code);
bnx2_free_skbs(bp); bnx2_free_skbs(bp);
bnx2_set_power_state(bp, state); bnx2_set_power_state(bp, pci_choose_state(pdev, state));
return 0; return 0;
} }
...@@ -5526,7 +5526,7 @@ bnx2_resume(struct pci_dev *pdev) ...@@ -5526,7 +5526,7 @@ bnx2_resume(struct pci_dev *pdev)
if (!netif_running(dev)) if (!netif_running(dev))
return 0; return 0;
bnx2_set_power_state(bp, 0); bnx2_set_power_state(bp, PCI_D0);
netif_device_attach(dev); netif_device_attach(dev);
bnx2_init_nic(bp); bnx2_init_nic(bp);
bnx2_netif_start(bp); bnx2_netif_start(bp);
......
...@@ -162,7 +162,7 @@ static void e1000_vlan_rx_add_vid(struct net_device *netdev, uint16_t vid); ...@@ -162,7 +162,7 @@ static void e1000_vlan_rx_add_vid(struct net_device *netdev, uint16_t vid);
static void e1000_vlan_rx_kill_vid(struct net_device *netdev, uint16_t vid); static void e1000_vlan_rx_kill_vid(struct net_device *netdev, uint16_t vid);
static void e1000_restore_vlan(struct e1000_adapter *adapter); static void e1000_restore_vlan(struct e1000_adapter *adapter);
static int e1000_suspend(struct pci_dev *pdev, uint32_t state); static int e1000_suspend(struct pci_dev *pdev, pm_message_t state);
#ifdef CONFIG_PM #ifdef CONFIG_PM
static int e1000_resume(struct pci_dev *pdev); static int e1000_resume(struct pci_dev *pdev);
#endif #endif
...@@ -3642,7 +3642,7 @@ e1000_set_spd_dplx(struct e1000_adapter *adapter, uint16_t spddplx) ...@@ -3642,7 +3642,7 @@ e1000_set_spd_dplx(struct e1000_adapter *adapter, uint16_t spddplx)
} }
static int static int
e1000_suspend(struct pci_dev *pdev, uint32_t state) e1000_suspend(struct pci_dev *pdev, pm_message_t state)
{ {
struct net_device *netdev = pci_get_drvdata(pdev); struct net_device *netdev = pci_get_drvdata(pdev);
struct e1000_adapter *adapter = netdev_priv(netdev); struct e1000_adapter *adapter = netdev_priv(netdev);
...@@ -3726,9 +3726,7 @@ e1000_suspend(struct pci_dev *pdev, uint32_t state) ...@@ -3726,9 +3726,7 @@ e1000_suspend(struct pci_dev *pdev, uint32_t state)
} }
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_power_state(pdev, pci_choose_state(pdev, state));
state = (state > 0) ? 3 : 0;
pci_set_power_state(pdev, state);
return 0; return 0;
} }
...@@ -3741,13 +3739,13 @@ e1000_resume(struct pci_dev *pdev) ...@@ -3741,13 +3739,13 @@ e1000_resume(struct pci_dev *pdev)
struct e1000_adapter *adapter = netdev_priv(netdev); struct e1000_adapter *adapter = netdev_priv(netdev);
uint32_t manc, ret_val, swsm; uint32_t manc, ret_val, swsm;
pci_set_power_state(pdev, 0); pci_set_power_state(pdev, PCI_D0);
pci_restore_state(pdev); pci_restore_state(pdev);
ret_val = pci_enable_device(pdev); ret_val = pci_enable_device(pdev);
pci_set_master(pdev); pci_set_master(pdev);
pci_enable_wake(pdev, 3, 0); pci_enable_wake(pdev, PCI_D3hot, 0);
pci_enable_wake(pdev, 4, 0); /* 4 == D3 cold */ pci_enable_wake(pdev, PCI_D3cold, 0);
e1000_reset(adapter); e1000_reset(adapter);
E1000_WRITE_REG(&adapter->hw, WUS, ~0); E1000_WRITE_REG(&adapter->hw, WUS, ~0);
......
...@@ -1749,11 +1749,6 @@ static int vlsi_irda_suspend(struct pci_dev *pdev, pm_message_t state) ...@@ -1749,11 +1749,6 @@ static int vlsi_irda_suspend(struct pci_dev *pdev, pm_message_t state)
struct net_device *ndev = pci_get_drvdata(pdev); struct net_device *ndev = pci_get_drvdata(pdev);
vlsi_irda_dev_t *idev; vlsi_irda_dev_t *idev;
if (state < 1 || state > 3 ) {
IRDA_ERROR("%s - %s: invalid pm state request: %u\n",
__FUNCTION__, PCIDEV_NAME(pdev), state);
return 0;
}
if (!ndev) { if (!ndev) {
IRDA_ERROR("%s - %s: no netdevice \n", IRDA_ERROR("%s - %s: no netdevice \n",
__FUNCTION__, PCIDEV_NAME(pdev)); __FUNCTION__, PCIDEV_NAME(pdev));
...@@ -1781,7 +1776,7 @@ static int vlsi_irda_suspend(struct pci_dev *pdev, pm_message_t state) ...@@ -1781,7 +1776,7 @@ static int vlsi_irda_suspend(struct pci_dev *pdev, pm_message_t state)
idev->new_baud = idev->baud; idev->new_baud = idev->baud;
} }
pci_set_power_state(pdev,state); pci_set_power_state(pdev, pci_choose_state(pdev, state));
pdev->current_state = state; pdev->current_state = state;
idev->resume_ok = 1; idev->resume_ok = 1;
up(&idev->sem); up(&idev->sem);
...@@ -1807,8 +1802,8 @@ static int vlsi_irda_resume(struct pci_dev *pdev) ...@@ -1807,8 +1802,8 @@ static int vlsi_irda_resume(struct pci_dev *pdev)
return 0; return 0;
} }
pci_set_power_state(pdev, 0); pci_set_power_state(pdev, PCI_D0);
pdev->current_state = 0; pdev->current_state = PM_EVENT_ON;
if (!idev->resume_ok) { if (!idev->resume_ok) {
/* should be obsolete now - but used to happen due to: /* should be obsolete now - but used to happen due to:
......
...@@ -128,7 +128,7 @@ static int mdio_bus_match(struct device *dev, struct device_driver *drv) ...@@ -128,7 +128,7 @@ static int mdio_bus_match(struct device *dev, struct device_driver *drv)
/* Suspend and resume. Copied from platform_suspend and /* Suspend and resume. Copied from platform_suspend and
* platform_resume * platform_resume
*/ */
static int mdio_bus_suspend(struct device * dev, u32 state) static int mdio_bus_suspend(struct device * dev, pm_message_t state)
{ {
int ret = 0; int ret = 0;
struct device_driver *drv = dev->driver; struct device_driver *drv = dev->driver;
......
...@@ -301,8 +301,6 @@ static int orinoco_pci_suspend(struct pci_dev *pdev, pm_message_t state) ...@@ -301,8 +301,6 @@ static int orinoco_pci_suspend(struct pci_dev *pdev, pm_message_t state)
unsigned long flags; unsigned long flags;
int err; int err;
printk(KERN_DEBUG "%s: Orinoco-PCI entering sleep mode (state=%d)\n",
dev->name, state);
err = orinoco_lock(priv, &flags); err = orinoco_lock(priv, &flags);
if (err) { if (err) {
......
...@@ -267,8 +267,6 @@ prism54_suspend(struct pci_dev *pdev, pm_message_t state) ...@@ -267,8 +267,6 @@ prism54_suspend(struct pci_dev *pdev, pm_message_t state)
islpci_private *priv = ndev ? netdev_priv(ndev) : NULL; islpci_private *priv = ndev ? netdev_priv(ndev) : NULL;
BUG_ON(!priv); BUG_ON(!priv);
printk(KERN_NOTICE "%s: got suspend request (state %d)\n",
ndev->name, state);
pci_save_state(pdev); pci_save_state(pdev);
......
...@@ -655,7 +655,7 @@ bail: ...@@ -655,7 +655,7 @@ bail:
} }
#ifdef CONFIG_PM #ifdef CONFIG_PM
static int s1d13xxxfb_suspend(struct device *dev, u32 state, u32 level) static int s1d13xxxfb_suspend(struct device *dev, pm_message_t state, u32 level)
{ {
struct fb_info *info = dev_get_drvdata(dev); struct fb_info *info = dev_get_drvdata(dev);
struct s1d13xxxfb_par *s1dfb = info->par; struct s1d13xxxfb_par *s1dfb = info->par;
......
...@@ -2110,7 +2110,6 @@ static int savagefb_suspend (struct pci_dev* dev, pm_message_t state) ...@@ -2110,7 +2110,6 @@ static int savagefb_suspend (struct pci_dev* dev, pm_message_t state)
struct savagefb_par *par = (struct savagefb_par *)info->par; struct savagefb_par *par = (struct savagefb_par *)info->par;
DBG("savagefb_suspend"); DBG("savagefb_suspend");
printk(KERN_DEBUG "state: %u\n", state);
acquire_console_sem(); acquire_console_sem();
fb_set_suspend(info, pci_choose_state(dev, state)); fb_set_suspend(info, pci_choose_state(dev, state));
......
...@@ -1427,7 +1427,7 @@ static int snd_atiixp_suspend(snd_card_t *card, pm_message_t state) ...@@ -1427,7 +1427,7 @@ static int snd_atiixp_suspend(snd_card_t *card, pm_message_t state)
snd_atiixp_aclink_down(chip); snd_atiixp_aclink_down(chip);
snd_atiixp_chip_stop(chip); snd_atiixp_chip_stop(chip);
pci_set_power_state(chip->pci, 3); pci_set_power_state(chip->pci, PCI_D3hot);
pci_disable_device(chip->pci); pci_disable_device(chip->pci);
return 0; return 0;
} }
...@@ -1438,7 +1438,7 @@ static int snd_atiixp_resume(snd_card_t *card) ...@@ -1438,7 +1438,7 @@ static int snd_atiixp_resume(snd_card_t *card)
int i; int i;
pci_enable_device(chip->pci); pci_enable_device(chip->pci);
pci_set_power_state(chip->pci, 0); pci_set_power_state(chip->pci, PCI_D0);
pci_set_master(chip->pci); pci_set_master(chip->pci);
snd_atiixp_aclink_reset(chip); snd_atiixp_aclink_reset(chip);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment