Commit 58ec4152 authored by Michal Ludvig's avatar Michal Ludvig Committed by Herbert Xu

[CRYPTO] padlock-sha: TFMs don't need to be static

TFMs are local variables. No need to declare them 
static. After all one is enough.
Signed-off-by: default avatarMichal Ludvig <michal@logix.cz>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 5644bda5
...@@ -262,28 +262,28 @@ static struct crypto_alg sha256_alg = { ...@@ -262,28 +262,28 @@ static struct crypto_alg sha256_alg = {
static void __init padlock_sha_check_fallbacks(void) static void __init padlock_sha_check_fallbacks(void)
{ {
static struct crypto_tfm *tfm_sha1, *tfm_sha256; struct crypto_tfm *tfm;
/* We'll try to allocate one TFM for each fallback /* We'll try to allocate one TFM for each fallback
* to test that the modules are available. */ * to test that the modules are available. */
tfm_sha1 = crypto_alloc_tfm(sha1_fallback, 0); tfm = crypto_alloc_tfm(sha1_fallback, 0);
if (!tfm_sha1) { if (!tfm) {
printk(KERN_WARNING PFX "Couldn't load fallback module for '%s'. Tried '%s'.\n", printk(KERN_WARNING PFX "Couldn't load fallback module for '%s'. Tried '%s'.\n",
sha1_alg.cra_name, sha1_fallback); sha1_alg.cra_name, sha1_fallback);
} else { } else {
printk(KERN_NOTICE PFX "Fallback for '%s' is driver '%s' (prio=%d)\n", sha1_alg.cra_name, printk(KERN_NOTICE PFX "Fallback for '%s' is driver '%s' (prio=%d)\n", sha1_alg.cra_name,
crypto_tfm_alg_driver_name(tfm_sha1), crypto_tfm_alg_priority(tfm_sha1)); crypto_tfm_alg_driver_name(tfm), crypto_tfm_alg_priority(tfm));
crypto_free_tfm(tfm_sha1); crypto_free_tfm(tfm);
} }
tfm_sha256 = crypto_alloc_tfm(sha256_fallback, 0); tfm = crypto_alloc_tfm(sha256_fallback, 0);
if (!tfm_sha256) { if (!tfm) {
printk(KERN_WARNING PFX "Couldn't load fallback module for '%s'. Tried '%s'.\n", printk(KERN_WARNING PFX "Couldn't load fallback module for '%s'. Tried '%s'.\n",
sha256_alg.cra_name, sha256_fallback); sha256_alg.cra_name, sha256_fallback);
} else { } else {
printk(KERN_NOTICE PFX "Fallback for '%s' is driver '%s' (prio=%d)\n", sha256_alg.cra_name, printk(KERN_NOTICE PFX "Fallback for '%s' is driver '%s' (prio=%d)\n", sha256_alg.cra_name,
crypto_tfm_alg_driver_name(tfm_sha256), crypto_tfm_alg_priority(tfm_sha256)); crypto_tfm_alg_driver_name(tfm), crypto_tfm_alg_priority(tfm));
crypto_free_tfm(tfm_sha256); crypto_free_tfm(tfm);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment