Commit 4a01c8d5 authored by Paul Jackson's avatar Paul Jackson Committed by Linus Torvalds

[PATCH] cpuset: task_lock comment fix

Fix cpuset comment involving case of a tasks cpuset pointer being NULL.
Thanks to "the_top_cpuset_hack", this code no longer sees NULL task->cpuset
pointers.
Signed-off-by: default avatarPaul Jackson <pj@sgi.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 2cf8d82d
...@@ -616,12 +616,10 @@ static void guarantee_online_mems(const struct cpuset *cs, nodemask_t *pmask) ...@@ -616,12 +616,10 @@ static void guarantee_online_mems(const struct cpuset *cs, nodemask_t *pmask)
* current->cpuset if a task has its memory placement changed. * current->cpuset if a task has its memory placement changed.
* Do not call this routine if in_interrupt(). * Do not call this routine if in_interrupt().
* *
* Call without callback_mutex or task_lock() held. May be called * Call without callback_mutex or task_lock() held. May be
* with or without manage_mutex held. Doesn't need task_lock to guard * called with or without manage_mutex held. Thanks in part to
* against another task changing a non-NULL cpuset pointer to NULL, * 'the_top_cpuset_hack', the tasks cpuset pointer will never
* as that is only done by a task on itself, and if the current task * be NULL. This routine also might acquire callback_mutex and
* is here, it is not simultaneously in the exit code NULL'ing its
* cpuset pointer. This routine also might acquire callback_mutex and
* current->mm->mmap_sem during call. * current->mm->mmap_sem during call.
* *
* Reading current->cpuset->mems_generation doesn't need task_lock * Reading current->cpuset->mems_generation doesn't need task_lock
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment