Commit 3af8e31c authored by Jesper Juhl's avatar Jesper Juhl Committed by David S. Miller

[NETFILTER]: ipt_recent: avoid a possible NULL pointer deref in recent_seq_open()

If the call to seq_open() returns != 0 then the code calls 
kfree(st) but then on the very next line proceeds to 
dereference the pointer - not good.

Problem spotted by the Coverity checker.
Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 864c5a4d
...@@ -387,12 +387,17 @@ static int recent_seq_open(struct inode *inode, struct file *file) ...@@ -387,12 +387,17 @@ static int recent_seq_open(struct inode *inode, struct file *file)
st = kzalloc(sizeof(*st), GFP_KERNEL); st = kzalloc(sizeof(*st), GFP_KERNEL);
if (st == NULL) if (st == NULL)
return -ENOMEM; return -ENOMEM;
ret = seq_open(file, &recent_seq_ops); ret = seq_open(file, &recent_seq_ops);
if (ret) if (ret) {
kfree(st); kfree(st);
goto out;
}
st->table = pde->data; st->table = pde->data;
seq = file->private_data; seq = file->private_data;
seq->private = st; seq->private = st;
out:
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment