Commit 33b74977 authored by Benjamin Herrenschmidt's avatar Benjamin Herrenschmidt Committed by Paul Mackerras

[PATCH] powerpc: Fix call to ibm,client-architecture-support

The code in prom_init.c calling the firmware
ibm,client-architecture-support method on pSeries has a bug where it
fails to properly pass the instance handle of the firmware object when
trying to call a method. Result ranges from the call doing nothing to
the firmware crashing. (Found by Segher, thanks !)
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarSegher Boessenkool <segher@kernel.crashing.org>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent 7c85d1f9
...@@ -822,6 +822,7 @@ static void __init prom_send_capabilities(void) ...@@ -822,6 +822,7 @@ static void __init prom_send_capabilities(void)
/* try calling the ibm,client-architecture-support method */ /* try calling the ibm,client-architecture-support method */
if (call_prom_ret("call-method", 3, 2, &ret, if (call_prom_ret("call-method", 3, 2, &ret,
ADDR("ibm,client-architecture-support"), ADDR("ibm,client-architecture-support"),
root,
ADDR(ibm_architecture_vec)) == 0) { ADDR(ibm_architecture_vec)) == 0) {
/* the call exists... */ /* the call exists... */
if (ret) if (ret)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment