Commit 287aa83d authored by Bill Nottingham's avatar Bill Nottingham Committed by Jeff Garzik

drivers/net: fix comparisons of unsigned < 0

Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0.
Signed-off-by: default avatarBill Nottingham <notting@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 40738f3f
...@@ -113,8 +113,7 @@ int mlx4_qp_modify(struct mlx4_dev *dev, struct mlx4_mtt *mtt, ...@@ -113,8 +113,7 @@ int mlx4_qp_modify(struct mlx4_dev *dev, struct mlx4_mtt *mtt,
struct mlx4_cmd_mailbox *mailbox; struct mlx4_cmd_mailbox *mailbox;
int ret = 0; int ret = 0;
if (cur_state < 0 || cur_state >= MLX4_QP_NUM_STATE || if (cur_state >= MLX4_QP_NUM_STATE || cur_state >= MLX4_QP_NUM_STATE ||
new_state < 0 || cur_state >= MLX4_QP_NUM_STATE ||
!op[cur_state][new_state]) !op[cur_state][new_state])
return -EINVAL; return -EINVAL;
......
...@@ -724,7 +724,7 @@ int netxen_niu_disable_gbe_port(struct netxen_adapter *adapter) ...@@ -724,7 +724,7 @@ int netxen_niu_disable_gbe_port(struct netxen_adapter *adapter)
__u32 mac_cfg0; __u32 mac_cfg0;
u32 port = physical_port[adapter->portnum]; u32 port = physical_port[adapter->portnum];
if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS)) if (port > NETXEN_NIU_MAX_GBE_PORTS)
return -EINVAL; return -EINVAL;
mac_cfg0 = 0; mac_cfg0 = 0;
netxen_gb_soft_reset(mac_cfg0); netxen_gb_soft_reset(mac_cfg0);
...@@ -757,7 +757,7 @@ int netxen_niu_set_promiscuous_mode(struct netxen_adapter *adapter, ...@@ -757,7 +757,7 @@ int netxen_niu_set_promiscuous_mode(struct netxen_adapter *adapter,
__u32 reg; __u32 reg;
u32 port = physical_port[adapter->portnum]; u32 port = physical_port[adapter->portnum];
if ((port < 0) || (port > NETXEN_NIU_MAX_GBE_PORTS)) if (port > NETXEN_NIU_MAX_GBE_PORTS)
return -EINVAL; return -EINVAL;
/* save previous contents */ /* save previous contents */
...@@ -894,7 +894,7 @@ int netxen_niu_xg_set_promiscuous_mode(struct netxen_adapter *adapter, ...@@ -894,7 +894,7 @@ int netxen_niu_xg_set_promiscuous_mode(struct netxen_adapter *adapter,
__u32 reg; __u32 reg;
u32 port = physical_port[adapter->portnum]; u32 port = physical_port[adapter->portnum];
if ((port < 0) || (port > NETXEN_NIU_MAX_XG_PORTS)) if (port > NETXEN_NIU_MAX_XG_PORTS)
return -EINVAL; return -EINVAL;
if (netxen_nic_hw_read_wx(adapter, if (netxen_nic_hw_read_wx(adapter,
......
...@@ -785,7 +785,6 @@ static void __de_set_rx_mode (struct net_device *dev) ...@@ -785,7 +785,6 @@ static void __de_set_rx_mode (struct net_device *dev)
de->tx_head = NEXT_TX(entry); de->tx_head = NEXT_TX(entry);
BUG_ON(TX_BUFFS_AVAIL(de) < 0);
if (TX_BUFFS_AVAIL(de) == 0) if (TX_BUFFS_AVAIL(de) == 0)
netif_stop_queue(dev); netif_stop_queue(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment