• Pantelis Koukousoulas's avatar
    V4L/DVB (5095): Pvrusb2: Allow VIDIOC_S_FMT with -1 for resolution values · fd694964
    Pantelis Koukousoulas authored
    With the previous patch, mplayer started but was polling the video
    device forever without any video actually coming out. Further analysis
    showed that it does a VIDIOC_S_FMT with width and height set to -1 (!!!).
    The code handling this only cares that both are lower than the minimum
    range allowed so it ends up setting the size to 19x17 (!!) This pretty
    much breaks the encoder here. Even if this breakage is yet another (TM)
    result of my setup, setting the size to 19x17 by default would surprise
    most users IMHO.
    So, special case for -1 and interpret this to be a request for the
    default size, please. Users can then set their favorite size both
    through mplayer and through sysfs.
    With this patch, mplayer finally works in pvr:// mode (not that we
    really gain anything over operating it through sysfs with lirc,
    sometime I might actually get off my lazy a** and contribute this
    setup too)
    Signed-off-by: default avatarPantelis Koukousoulas <pakt223@freemail.gr>
    Signed-off-by: default avatarMike Isely <isely@pobox.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
    fd694964
pvrusb2-v4l2.c 29.1 KB