• Ingo Molnar's avatar
    [PATCH] suspend: fix suspend on single-CPU systems · e1d9fd2e
    Ingo Molnar authored
    Clark Williams reported that suspend doesnt work on his laptop on
    2.6.20-rc1-rt kernels. The bug was introduced by the following cleanup
    commit:
    
     commit 112cecb2
     Author: Siddha, Suresh B <suresh.b.siddha@intel.com>
     Date:   Wed Dec 6 20:34:31 2006 -0800
    
        [PATCH] suspend: don't change cpus_allowed for task initiating the suspend
    
    because with this change 'error' is not initialized to 0 anymore, if
    there are no other online CPUs. (i.e. if the system is single-CPU).
    
    the fix is the initialize it to 0. The really weird thing is that my
    version of gcc does not warn about this non-initialized variable
    situation ...
    
    (also fix the kernel printk in the error branch, it was missing a
     newline)
    Reported-by: default avatarClark Williams <williams@redhat.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    e1d9fd2e
cpu.c 7.05 KB