• Gerrit Renker's avatar
    [DCCP] ccid3: Avoid congestion control on zero-sized data packets · da335baf
    Gerrit Renker authored
    This resolves an `XXX' in ccid3_hc_tx_send_packet().
    
    The function is only called on Data and DataAck packets and returns a negative
    result on zero-sized messages. This is a reasonable policy since CCID 3 is a
    congestion-control module and congestion control on zero-sized Data(Ack)
    packets is in a way pathological.
    
    The patch uses a more suitable error code for this case, it returns the Posix.1
    code `EBADMSG' ("Not a data message") instead of `ENOTCONN'.
    
    As a result of ignoring zero-sized packets, a the condition for a warning
    "First packet is data" in ccid3_hc_tx_packet_sent is always satisfied; this
    message has been removed since it will always be printed.
    Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
    Signed-off-by: default avatarIan McDonald <ian.mcdonald@jandi.co.nz>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
    da335baf
ccid3.c 35.9 KB