• Linus Torvalds's avatar
    [PATCH] PCI: resource address mismatch · b408cbc7
    Linus Torvalds authored
    On Tue, 21 Feb 2006, Ivan Kokshaysky wrote:
    > There are two bogus entries in the BIOS memory map table which are
    > conflicting with a prefetchable memory range of the AGP bridge:
    >
    >  BIOS-e820: 00000000fec00000 - 00000000fec01000 (reserved)
    >  BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
    >
    > 0000:00:02.0 PCI bridge: Silicon Integrated Systems [SiS] Virtual PCI-to-PCI bridge (AGP) (prog-if 00 [Normal decode])
    > 	Flags: bus master, fast devsel, latency 0
    > 	Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
    > 	I/O behind bridge: 0000c000-0000cfff
    > 	Memory behind bridge: e7e00000-e7efffff
    > 	Prefetchable memory behind bridge: fec00000-ffcfffff
    > 					   ^^^^^^^^^^^^^^^^^
    
    Yes. However, it's pretty clear that the e820 entries are there for a
    reason. Probably they are a hack by the BIOS maintainers to keep Windows
    from stomping/moving that region, exactly because they want to keep the
    bridge where it is (or, it's actually for the BIOS itself - the BIOS
    tables are a horrid mess, and BIOS engineers are pretty hacky people:
    they'll add random entries to make their own broken algorithms do the
    "right thing").
    
    > Starting from 2.6.13, kernel tries to resolve that sort of conflicts,
    > so that prefetch window of the bridge and the framebuffer memory behind
    > it get moved to 0x10000000.
    
    I think we could (and probably should) solve this another way: consider
    the ACPI "reserved regions" from the e820 map exactly the same way that we
    do other ACPI hints - they should restrict _new_ allocations, but not
    impact stuff we figure out on our own.
    
    Basically, right now we assign _unassigned_ resources at "fs_initcall"
    time. If we were to add in the e820 "reserved region" stuff before that
    (but after we've done PCI discovery), we'd probably do the right thing.
    
    Right now we do the e820 reserved regions very early indeed: we call
    "register_memory()" from setup_arch(). We could move at least part of it
    (the part that registers the resources) down a bit.
    
    Here's a test-patch. I'm not saying we should absolutely do this, but it
    might be interesting to try...
    
    Cc: "Antonino A. Daplas" <adaplas@pol.net>
    Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
    Cc: <bjk@luxsci.net>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    b408cbc7
efi.c 17.4 KB