• Tejun Heo's avatar
    [PATCH] ahci: simplify ahci_start_engine() · 9f592056
    Tejun Heo authored
    Simplify ahci_start_engine() by killing prerequisite condition checks.
    Rationales are..
    
    * No user checks error return from ahci_start_engine()
    
    * Code flow guarantees the prerequisite conditions unless the
      controller is malfunctioning.  In such cases, the driver had chances
      to learn about the problem _before_ calling this function.
    
    * Closely related to the above two, driver calls into this function
      even when prerequisites fail hoping for the best.
    
    Basically, ahci_start_engine() should only do the operation itself.
    It isn't the right place to check for prerequisites.
    Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
    Signed-off-by: default avatarZhao, Forrest <forrest.zhao@intel.com>
    Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    9f592056
ahci.c 38.3 KB