• Michael H. Schimek's avatar
    V4L/DVB (3178): bttv VBI fixes · 67f1570a
    Michael H. Schimek authored
    - V4L2_(G|S|TRY)_FMT returned incorrect VBI start lines for PAL-M,
    NTSC-JP, and PAL-60. They also returned an inaccurate VBI offset.
    - V4L2_(G|S)_FMT and V4L2_TRY_FMT disagreed about the start of VBI
    capturing in PAL and SECAM second field. Note the start line fixes
    may break applications using VIDIOCSVBIFMT because this ioctl fails
    when the driver does not support exactly the requested parameters.
    - V4L2_TRY_FMT did not clear the reserved field in struct
    v4l2_vbi_format.
    - V4L2_(S|TRY)_FMT did not expect very large or small VBI start or
    count values, returning wrong (but safe) counts due to an overflow.
    - VIDIOCGVBIFMT confused V4L and V4L2 VBI flags. However this had no
    effect because the flags have the same value and bttv never sets
    them.
    - In v4l_compat_translate_ioctl() the VIDIOC(G|S)VBIFMT code did not
    expect V4L2 drivers supporting VBI formats besides V4L2_PIX_FMT_GREY.
    Signed-off-by: default avatarMichael H. Schimek <mschimek@gmx.at>
    Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@brturbo.com.br>
    67f1570a
bttv-vbi.c 6.22 KB