• Andrew Morton's avatar
    isdn/capi warning fixes · 5e6c20a9
    Andrew Morton authored
    drivers/isdn/capi/capi.c: In function 'handle_minor_send':
    drivers/isdn/capi/capi.c:552: warning: cast from pointer to integer of different size
    
    Of course, the code here might actually be buggy, in which case this patch
    should not be applied?
    
    Answer:
    
      No this field is ignored inside linux kernel.Yes this is ugly, but it's
      the CAPI spec for all OS.
    
      CAPI DATA_B3 Request/Indication CAPI Message has a mandatory field which
      represent the 32 bit buffer address of the payload data.  In linux the
      payload data do not use a sperate buffer, data follows directely after the
      CAPI Message in the same skb and we use this assumption inside the drivers,
      so we can ignore this field.
    
      Inside the linux CAPI implemetation we never use this field, so it could
      also have no value, but since random data in a message is bad as well (e.g.
      displayed in CAPI traces) we set is to the most adequate value.
    
      Outside the kernel the capi20 library sets the correct addresses (there is
      an optional second field for 64 bit adresses for 64 bit systems, we do not
      use here).
    Acked-by: default avatarKarsten Keil <kkeil@suse.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    5e6c20a9
capi.c 38 KB