• Benny Halevy's avatar
    synchronization in usb_serial_put · 52f6b5e1
    Benny Halevy authored
    I think there is a race between usb_serial_put() and
    usb_serial_get_by_index() (and get_free_serial()) with regards
    to handling the serial port refcount.
    
    usb_serial_get_by_index() gets a reference on the serial port under
    table_lock while return_serial releases all the returned ports
    from the table under the same lock.  However, the table_lock is not
    taken around the call to kref_put, theoretically allowing to sneak
    in and grab a reference after kref_put has already determined that
    the reference count is zero (and before calling destroy_serial)
    causing use after free.
    Signed-off-by: default avatarBenny Halevy <bhalevy@ns1.bhalevy.com>
    Cc: Oliver Neukum <oneukum@suse.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    52f6b5e1
usb-serial.c 33.3 KB