• Suzuki Kp's avatar
    [PATCH] fix rescan_partitions to return errors properly · 5127d002
    Suzuki Kp authored
    The current rescan_partition implementation ignores the errors that comes from
    the lower layer.  It reports success for unknown partitions as well as I/O
    error cases while reading the partition information.
    
    The unknown partition is not (and will not be) considered as an error in the
    kernel, since there are legal users of it (e.g, members of a RAID5 MD Device
    or a new disk which is not partitioned at all ).  Changing this behaviour
    would scare the user about a serious problem with their disk and is not
    recommended.  Thus for both "unknown partitions" to the Linux (eg., DEC
    VMS,Novell Netware) and the legal users of NULL partition, would still be
    reported as "SUCCESS".
    
    The patch attached here, scares the user about something which he does need to
    worry about.  i.e, returning -EIO on disk I/O errors while reading the
    partition information.
    Signed-off-by: default avatarSuzuki K P <suzuki@in.ibm.com>
    Cc: Erik Mouw <erik@harddisk-recovery.com>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    5127d002
check.c 13.5 KB