• Deepak Saxena's avatar
    [PATCH] Update smc91x driver with ARM Versatile board info · 33fee56a
    Deepak Saxena authored
    We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new
    generic IRQ layer will complain thusly:
    
    No IRQF_TRIGGER set_type function for IRQ 25 (<NULL>)
    Signed-off-by: default avatarDeepak Saxena <dsaxena@plexity.net>
    Cc: Jeff Garzik <jeff@garzik.org>
    Cc: Russell King <rmk@arm.linux.org.uk>
    Cc: Nicolas Pitre <nico@cam.org>
    
    On Fri, 20 Oct 2006 22:50:40 +0100
    Russell King <rmk@arm.linux.org.uk> wrote:
    
    > On Fri, Oct 20, 2006 at 02:42:04PM -0700, akpm@osdl.org wrote:
    > > We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new
    > > generic IRQ layer will complain thusly:
    >
    > I don't think I heard anything back from my previous suggestion that
    > the IRQ flags are passed through the platform device IRQ resource.
    >
    > Doing so would avoid adding yet another platform specific block into
    > the file.
    >
    > BTW, Integrator platforms will also suffer from this, which will add
    > another ifdef to this header.
    >
    > Let's do it right and arrange to pass these flags from the platform
    > code.  It's not like they're in a critical path.
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    33fee56a
smc91x.h 38.1 KB