• Alexander Nyberg's avatar
    [PATCH] x86_64: cpu hotplug changes kills nmi watchdog · 2a16a300
    Alexander Nyberg authored
    When the x86_64 cpu hotplug changes went in it added a check in
    default_do_nmi() which kills NMI delivery on any CPU but the BSP.
    
    The NMI watchdog is brought up quite some time before the online bit is set
    in num_online_cpus so this won't work very well.  The nmi watchdogs on cpus
    that are not BSP will never be reprogrammed and no NMIs.
    
    Why was this check added? How does an offlined cpu receive an NMI?
    Signed-off-by: default avatarAlexander Nyberg <alexn@telia.com>
    Cc: Andi Kleen <ak@suse.de>
    Cc: Andrew Morton <akpm@osdl.org>
    Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>
    Cc: <ashok.raj@intel.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    2a16a300
traps.c 24.2 KB