• Franck Bui-Huu's avatar
    [PATCH] softcursor.c: avoid unaligned accesses · 024cd7e0
    Franck Bui-Huu authored
    Fix some possible unaligned accesses when accessing fields of 'image'
    pointer.  Indeed this pointer was obtained by allocating a block of memory
    that embeds a temporary array plus an image structure.  The temporary
    buffer was located at the start of the allocated block and depending on its
    size, the image structure which comes right after can be unaligned.
    
    For example when using mini fonts (4x6) (cursor's width is 4 and its height
    is 6) the temporary buf size is 6 bytes.
    
    Therefore this patch moves the image structure to the start of the block
    and moves the temporary buffer right after.  It makes 'image' pointer
    always aligned and since the tempo buf is a buffer of char, it's always
    correctly aligned as well.
    
    It also fixes the file header alignement.
    Signed-off-by: default avatarFranck Bui-Huu <fbuihuu@gmail.com>
    Cc: James Simmons <jsimmons@infradead.org>
    Cc: "Antonino A. Daplas" <adaplas@pol.net>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    024cd7e0
softcursor.c 2.1 KB