Commit e3204e44 authored by Antoine Cellerier's avatar Antoine Cellerier

* [PATCH] Memory hole fix by Bernie Purcell

parent ba04cf95
...@@ -1765,9 +1765,6 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out, ...@@ -1765,9 +1765,6 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out,
} }
stream_Delete( p_sub ); stream_Delete( p_sub );
} }
/* No longer need a HTML version of the text */
free( p_region_in->psz_html );
p_region_in->psz_html = NULL;
return rv; return rv;
} }
......
...@@ -710,9 +710,6 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out, ...@@ -710,9 +710,6 @@ static int RenderHtml( filter_t *p_filter, subpicture_region_t *p_region_out,
} }
stream_Delete( p_sub ); stream_Delete( p_sub );
} }
// No longer need a HTML version of the text
free( p_region_in->psz_html );
p_region_in->psz_html = NULL;
return rv; return rv;
} }
......
...@@ -355,6 +355,8 @@ void __spu_DestroyRegion( vlc_object_t *p_this, subpicture_region_t *p_region ) ...@@ -355,6 +355,8 @@ void __spu_DestroyRegion( vlc_object_t *p_this, subpicture_region_t *p_region )
if( p_region->psz_text ) if( p_region->psz_text )
free( p_region->psz_text ); free( p_region->psz_text );
if( p_region->psz_html )
free( p_region->psz_html );
//free( p_region->p_style ); FIXME --fenrir plugin does not allocate the memory for it. I think it might lead to segfault, video renderer can live longer than the decoder //free( p_region->p_style ); FIXME --fenrir plugin does not allocate the memory for it. I think it might lead to segfault, video renderer can live longer than the decoder
free( p_region ); free( p_region );
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment