Skip to content

V
vlc
Commit dd4d8155 authored by Felix Paul Kühne's avatar Felix Paul Kühne
Browse files
Options

auhal: fix insufficient bounds checking introduced in [14250ccc]

parent 8aeca915
Show whitespace changes
Inline Side-by-side
Showing with 7 additions and 0 deletions
modules/audio_output/auhal.c
View file @ dd4d8155
...@@ -997,6 +997,13 @@ static void RebuildDeviceList(audio_output_t * p_aout) ...@@ -997,6 +997,13 @@ static void RebuildDeviceList(audio_output_t * p_aout)
bool b_digital = false; bool b_digital = false;
UInt32 i_id = deviceIDs[i]; UInt32 i_id = deviceIDs[i];
/* Retrieve the length of the device name */
err = AudioObjectGetPropertyDataSize(deviceIDs[i], &deviceNameAddress, 0, NULL, &propertySize);
if (err != noErr) {
msg_Dbg(p_aout, "failed to get name size for device %i", deviceIDs[i]);
continue;
}
/* Retrieve the name of the device */ /* Retrieve the name of the device */
err = AudioObjectGetPropertyData(deviceIDs[i], &deviceNameAddress, 0, NULL, &propertySize, &device_name_ref); err = AudioObjectGetPropertyData(deviceIDs[i], &deviceNameAddress, 0, NULL, &propertySize, &device_name_ref);
if (err != noErr) { if (err != noErr) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment