Commit a043d59a authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

Fix strcasen?cmp overflow

Pointed out by Hannes Domani
parent 0448c670
...@@ -146,7 +146,7 @@ static inline int strcasecmp (const char *s1, const char *s2) ...@@ -146,7 +146,7 @@ static inline int strcasecmp (const char *s1, const char *s2)
for (size_t i = 0;; i++) for (size_t i = 0;; i++)
{ {
int d = tolower (s1[i]) - tolower (s2[i]); int d = tolower (s1[i]) - tolower (s2[i]);
if (d) return d; if (d || !s1[i]) return d;
} }
return 0; return 0;
} }
...@@ -163,7 +163,7 @@ static inline int strncasecmp (const char *s1, const char *s2, size_t n) ...@@ -163,7 +163,7 @@ static inline int strncasecmp (const char *s1, const char *s2, size_t n)
for (size_t i = 0; i < n; i++) for (size_t i = 0; i < n; i++)
{ {
int d = tolower (s1[i]) - tolower (s2[i]); int d = tolower (s1[i]) - tolower (s2[i]);
if (d) return d; if (d || !s1[i]) return d;
} }
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment