Better asprintf error handling

src/misc/update.c

@@ -1060,9 +1060,16 @@ void update_DownloadReal( update_download_thread_t *p_udt )
         l_size = stream_Size( p_stream );
 
         psz_tmpdestfile = strrchr( p_update->release.psz_url, '/' );
+        if( !psz_tmpdestfile )
+        {
+            msg_Err( p_update->p_libvlc, "The URL %s is false formated", p_update->release.psz_url );
+            return;
+        }
+        else
+        {
             psz_tmpdestfile++;
-        asprintf( &psz_destfile, "%s%s", psz_destdir, psz_tmpdestfile );
-
+            if( asprintf( &psz_destfile, "%s%s", psz_destdir, psz_tmpdestfile ) != -1 )
+            {
                 p_file = utf8_fopen( psz_destfile, "w" );
                 if( !p_file )
                 {
@@ -1075,9 +1082,11 @@ void update_DownloadReal( update_download_thread_t *p_udt )
                     if( p_buffer )
                     {
                         psz_size = size_str( l_size );
-                asprintf( &psz_status, "%s\nDownloading... O.O/%s %.1f%% done",  p_update->release.psz_url, psz_size, 0.0 );
+                        if( asprintf( &psz_status, "%s\nDownloading... O.O/%s %.1f%% done",  p_update->release.psz_url, psz_size, 0.0 ) != -1 )
+                        {
                             i_progress = intf_UserProgress( p_update->p_libvlc, "Downloading ...", psz_status, 0.0, 0 );
                             free( psz_status );
+                        }
 
                         while( ( i_read = stream_Read( p_stream, p_buffer, 1 << 10 ) ) &&
                                  !intf_ProgressIsCancelled( p_update->p_libvlc, i_progress ) )
@@ -1086,30 +1095,37 @@ void update_DownloadReal( update_download_thread_t *p_udt )
 
                             l_downloaded += i_read;
                             psz_downloaded = size_str( l_downloaded );
-                    asprintf( &psz_status, "%s\nDonwloading... %s/%s %.1f%% done", p_update->release.psz_url,
-                              psz_size, psz_downloaded, 100.0*(float)l_downloaded/(float)l_size );
+                            if( asprintf( &psz_status, "%s\nDonwloading... %s/%s %.1f%% done", p_update->release.psz_url,
+                                          psz_size, psz_downloaded, 100.0*(float)l_downloaded/(float)l_size ) != -1 )
+                            {
                                 intf_ProgressUpdate( p_update->p_libvlc, i_progress, psz_status, 10.0, 0 );
-                    free( psz_downloaded );
                                 free( psz_status );
                             }
+                            free( psz_downloaded );
+                        }
+                        free( p_buffer );
 
                         /* If the user cancelled the download */
                         if( !intf_ProgressIsCancelled( p_update->p_libvlc, i_progress ) )
                         {
-                    asprintf( &psz_status, "%s\nDone %s (100.0%%)", p_update->release.psz_url, psz_size );
+                             if( asprintf( &psz_status, "%s\nDone %s (100.0%%)", p_update->release.psz_url, psz_size ) != -1 )
+                             {
                                 intf_ProgressUpdate( p_update->p_libvlc, i_progress, psz_status, 100.0, 0 );
                                 free( psz_status );
                             }
-                free( p_buffer );
+                        }
                         free( psz_size );
                     }
                     fclose( p_file );
                     if( intf_ProgressIsCancelled( p_update->p_libvlc, i_progress ) )
                         remove( psz_destfile );
                 }
-        stream_Delete( p_stream );
+                free( psz_destfile );
+            }
+        }
     }
     free( psz_destdir );
+    stream_Delete( p_stream );
 }
 
 #endif