Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
7bdcc742
Commit
7bdcc742
authored
Jun 05, 2011
by
Rémi Duraffort
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
taglib: MP4 covert art comes with v1.6.1 and only if TAGLIB_WITH_MP4 is defined.
parent
449b78e8
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
8 deletions
+4
-8
configure.ac
configure.ac
+0
-3
modules/meta_engine/taglib.cpp
modules/meta_engine/taglib.cpp
+4
-5
No files found.
configure.ac
View file @
7bdcc742
...
@@ -1776,9 +1776,6 @@ AS_IF([test "${enable_taglib}" != "no"], [
...
@@ -1776,9 +1776,6 @@ AS_IF([test "${enable_taglib}" != "no"], [
VLC_ADD_PLUGIN([taglib])
VLC_ADD_PLUGIN([taglib])
VLC_ADD_LIBS([taglib],[$TAGLIB_LIBS -lz])
VLC_ADD_LIBS([taglib],[$TAGLIB_LIBS -lz])
VLC_ADD_CXXFLAGS([taglib],[$TAGLIB_CFLAGS])
VLC_ADD_CXXFLAGS([taglib],[$TAGLIB_CFLAGS])
AC_LANG_PUSH(C++)
AC_CHECK_HEADERS(taglib/mp4coverart.h)
AC_LANG_POP(C++)
], [
], [
AC_MSG_WARN(TagLib library not found)])
AC_MSG_WARN(TagLib library not found)])
])
])
...
...
modules/meta_engine/taglib.cpp
View file @
7bdcc742
...
@@ -65,8 +65,6 @@
...
@@ -65,8 +65,6 @@
# ifdef TAGLIB_WITH_ASF // ASF pictures comes with v1.7.0
# ifdef TAGLIB_WITH_ASF // ASF pictures comes with v1.7.0
# define TAGLIB_HAVE_ASFPICTURE_H
# define TAGLIB_HAVE_ASFPICTURE_H
# include <asffile.h>
# include <asffile.h>
# include <asftag.h>
# include <asfattribute.h>
# endif
# endif
#endif
#endif
...
@@ -82,7 +80,8 @@
...
@@ -82,7 +80,8 @@
# include <wavfile.h>
# include <wavfile.h>
#endif
#endif
#ifdef TAGLIB_WITH_MP4
#if TAGLIB_VERSION >= VERSION_INT(1,6,1) && defined(TAGLIB_WITH_MP4)
# define TAGLIB_HAVE_MP4COVERTART_H
# include <mp4file.h>
# include <mp4file.h>
#endif
#endif
...
@@ -399,7 +398,7 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t* p_demux_meta,
...
@@ -399,7 +398,7 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t* p_demux_meta,
}
}
#if
defined(TAGLIB_WITH_MP4) && defined(HAVE_TAGLIB_MP4COVERART_H)
#if
def TAGLIB_HAVE_MP4COVERTART_H
/**
/**
* Read the meta information from mp4 specific tags
* Read the meta information from mp4 specific tags
* @param tag: the mp4 tag
* @param tag: the mp4 tag
...
@@ -531,7 +530,7 @@ static int ReadMeta( vlc_object_t* p_this)
...
@@ -531,7 +530,7 @@ static int ReadMeta( vlc_object_t* p_this)
else
if
(
flac
->
xiphComment
()
)
else
if
(
flac
->
xiphComment
()
)
ReadMetaFromXiph
(
flac
->
xiphComment
(),
p_demux_meta
,
p_meta
);
ReadMetaFromXiph
(
flac
->
xiphComment
(),
p_demux_meta
,
p_meta
);
}
}
#if
defined(TAGLIB_WITH_MP4) && defined(HAVE_TAGLIB_MP4COVERART_H)
#if
def TAGLIB_HAVE_MP4COVERTART_H
else
if
(
MP4
::
File
*
mp4
=
dynamic_cast
<
MP4
::
File
*>
(
f
.
file
())
)
else
if
(
MP4
::
File
*
mp4
=
dynamic_cast
<
MP4
::
File
*>
(
f
.
file
())
)
{
{
if
(
mp4
->
tag
()
)
if
(
mp4
->
tag
()
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment