Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
7475606a
Commit
7475606a
authored
Aug 13, 2009
by
Ilkka Ollakka
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Qt4: PLItem cleanup
parent
8df85173
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
18 deletions
+0
-18
modules/gui/qt4/components/playlist/playlist_item.cpp
modules/gui/qt4/components/playlist/playlist_item.cpp
+0
-16
modules/gui/qt4/components/playlist/playlist_item.hpp
modules/gui/qt4/components/playlist/playlist_item.hpp
+0
-2
No files found.
modules/gui/qt4/components/playlist/playlist_item.cpp
View file @
7475606a
...
...
@@ -77,20 +77,17 @@ void PLItem::init( playlist_item_t *_playlist_item, PLItem *parent, PLModel *m,
else
if
(
i_showflags
>=
COLUMN_END
)
i_showflags
=
COLUMN_END
-
1
;
/* show everything */
updateColumnHeaders
();
}
}
else
{
i_showflags
=
parentItem
->
i_showflags
;
//Add empty string and update() handles data appending
}
}
/*
Constructors
Call the above function init
So far the first constructor isn't used...
*/
PLItem
::
PLItem
(
playlist_item_t
*
p_item
,
PLItem
*
parent
,
PLModel
*
m
)
{
...
...
@@ -109,12 +106,6 @@ PLItem::~PLItem()
children
.
clear
();
}
/* Column manager */
void
PLItem
::
updateColumnHeaders
()
{
assert
(
i_showflags
<
COLUMN_END
);
}
/* So far signal is always true.
Using signal false would not call PLModel... Why ?
*/
...
...
@@ -149,13 +140,6 @@ int PLItem::row() const
}
/* update the PL Item, get the good names and so on */
/* This function may not be the best way to do it
It destroys everything and gets everything again instead of just
building the necessary columns.
This does extra work if you re-display the same column. Slower...
On the other hand, this way saves memory.
There must be a more clever way.
*/
void
PLItem
::
update
(
playlist_item_t
*
p_item
,
bool
iscurrent
)
{
assert
(
p_item
->
p_input
->
i_id
==
i_input_id
);
...
...
modules/gui/qt4/components/playlist/playlist_item.hpp
View file @
7475606a
...
...
@@ -40,7 +40,6 @@ class PLItem
{
friend
class
PLModel
;
public:
PLItem
(
int
,
int
,
bool
,
PLItem
*
parent
,
PLModel
*
);
PLItem
(
playlist_item_t
*
,
PLItem
*
parent
,
PLModel
*
);
PLItem
(
playlist_item_t
*
,
QSettings
*
,
PLModel
*
);
~
PLItem
();
...
...
@@ -74,7 +73,6 @@ protected:
private:
void
init
(
playlist_item_t
*
,
PLItem
*
,
PLModel
*
,
QSettings
*
);
void
updateColumnHeaders
();
PLItem
*
parentItem
;
PLModel
*
model
;
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment