macosx: always expand all sidebar nodes on launch (fixes #5811) and make sure...

macosx: always expand all sidebar nodes on launch (fixes #5811) and make sure that the sidebar isn't editable by the user

extras/package/macosx/Resources/English.lproj/MainMenu.xib

@@ -21,16 +21,16 @@
     </object>
     <object class="NSMutableArray" key="IBDocument.EditedObjectIDs">
       <bool key="EncodedWithXMLCoder">YES</bool>
-      <integer value="2770"/>
-      <integer value="1617"/>
+      <integer value="283"/>
       <integer value="29"/>
-      <integer value="21"/>
-      <integer value="4722"/>
-      <integer value="915"/>
       <integer value="4596"/>
-      <integer value="283"/>
+      <integer value="1617"/>
       <integer value="4895"/>
+      <integer value="4722"/>
+      <integer value="2770"/>
       <integer value="2730"/>
+      <integer value="4717"/>
+      <integer value="915"/>
     </object>
     <object class="NSArray" key="IBDocument.PluginDependencies">
       <bool key="EncodedWithXMLCoder">YES</bool>
@@ -130,7 +130,7 @@
                                     </object>
                                   </object>
                                   <object class="NSTextFieldCell" key="NSDataCell" id="1022116109">
-                                    <int key="NSCellFlags">337772096</int>
+                                    <int key="NSCellFlags">67239488</int>
                                     <int key="NSCellFlags2">2048</int>
                                     <string key="NSContents">Text Cell</string>
                                     <object class="NSFont" key="NSSupport">

modules/gui/macosx/MainWindow.m

@@ -391,6 +391,9 @@ static VLCMainWindow *_o_sharedInstance = nil;
 
     [o_sidebar_view reloadData];
     [o_sidebar_view selectRowIndexes:[NSIndexSet indexSetWithIndex:0] byExtendingSelection:YES];
+    NSUInteger i_sidebaritem_count = [o_sidebaritems count];
+    for (NSUInteger x = 0; x < i_sidebaritem_count; x++)
+        [o_sidebar_view expandItem: [o_sidebaritems objectAtIndex: x] expandChildren: YES];
 
     if( b_dark_interface )
     {
@@ -1893,9 +1896,6 @@ static VLCMainWindow *_o_sharedInstance = nil;
 /* taken under BSD-new from the PXSourceList sample project, adapted for VLC */
 - (BOOL)sourceList:(PXSourceList*)aSourceList isGroupAlwaysExpanded:(id)group
 {
-	if([[group identifier] isEqualToString:@"library"])
-		return YES;
-
     return NO;
 }