Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc
Commits
6b44362d
Commit
6b44362d
authored
Aug 20, 2008
by
Rémi Duraffort
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check malloc return value and avoid memleaks.
parent
3059bd8f
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
27 additions
and
3 deletions
+27
-3
modules/mux/avi.c
modules/mux/avi.c
+21
-3
modules/mux/dummy.c
modules/mux/dummy.c
+2
-0
modules/mux/mp4.c
modules/mux/mp4.c
+4
-0
No files found.
modules/mux/avi.c
View file @
6b44362d
...
@@ -143,6 +143,8 @@ static int Open( vlc_object_t *p_this )
...
@@ -143,6 +143,8 @@ static int Open( vlc_object_t *p_this )
msg_Dbg
(
p_mux
,
"AVI muxer opened"
);
msg_Dbg
(
p_mux
,
"AVI muxer opened"
);
p_sys
=
malloc
(
sizeof
(
sout_mux_sys_t
)
);
p_sys
=
malloc
(
sizeof
(
sout_mux_sys_t
)
);
if
(
!
p_sys
)
return
VLC_ENOMEM
;
p_sys
->
i_streams
=
0
;
p_sys
->
i_streams
=
0
;
p_sys
->
i_stream_video
=
-
1
;
p_sys
->
i_stream_video
=
-
1
;
p_sys
->
i_movi_size
=
0
;
p_sys
->
i_movi_size
=
0
;
...
@@ -151,6 +153,11 @@ static int Open( vlc_object_t *p_this )
...
@@ -151,6 +153,11 @@ static int Open( vlc_object_t *p_this )
p_sys
->
idx1
.
i_entry_max
=
10000
;
p_sys
->
idx1
.
i_entry_max
=
10000
;
p_sys
->
idx1
.
entry
=
calloc
(
p_sys
->
idx1
.
i_entry_max
,
p_sys
->
idx1
.
entry
=
calloc
(
p_sys
->
idx1
.
i_entry_max
,
sizeof
(
avi_idx1_entry_t
)
);
sizeof
(
avi_idx1_entry_t
)
);
if
(
!
p_sys
->
idx1
.
entry
)
{
free
(
p_sys
);
return
VLC_ENOMEM
;
}
p_sys
->
b_write_header
=
true
;
p_sys
->
b_write_header
=
true
;
...
@@ -253,11 +260,13 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
...
@@ -253,11 +260,13 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
if
(
p_sys
->
i_streams
>=
100
)
if
(
p_sys
->
i_streams
>=
100
)
{
{
msg_Err
(
p_mux
,
"too many streams"
);
msg_Err
(
p_mux
,
"too many streams"
);
return
(
-
1
)
;
return
VLC_EGENERIC
;
}
}
msg_Dbg
(
p_mux
,
"adding input"
);
msg_Dbg
(
p_mux
,
"adding input"
);
p_input
->
p_sys
=
malloc
(
sizeof
(
int
)
);
p_input
->
p_sys
=
malloc
(
sizeof
(
int
)
);
if
(
!
p_input
->
p_sys
)
return
VLC_ENOMEM
;
*
((
int
*
)
p_input
->
p_sys
)
=
p_sys
->
i_streams
;
*
((
int
*
)
p_input
->
p_sys
)
=
p_sys
->
i_streams
;
p_stream
=
&
p_sys
->
stream
[
p_sys
->
i_streams
];
p_stream
=
&
p_sys
->
stream
[
p_sys
->
i_streams
];
...
@@ -275,6 +284,11 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
...
@@ -275,6 +284,11 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
p_stream
->
p_wf
=
malloc
(
sizeof
(
WAVEFORMATEX
)
+
p_stream
->
p_wf
=
malloc
(
sizeof
(
WAVEFORMATEX
)
+
p_input
->
p_fmt
->
i_extra
);
p_input
->
p_fmt
->
i_extra
);
if
(
!
p_stream
->
p_wf
)
{
free
(
p_input
->
p_sys
);
return
VLC_ENOMEM
;
}
#define p_wf p_stream->p_wf
#define p_wf p_stream->p_wf
p_wf
->
cbSize
=
p_input
->
p_fmt
->
i_extra
;
p_wf
->
cbSize
=
p_input
->
p_fmt
->
i_extra
;
if
(
p_wf
->
cbSize
>
0
)
if
(
p_wf
->
cbSize
>
0
)
...
@@ -349,6 +363,11 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
...
@@ -349,6 +363,11 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
p_stream
->
p_wf
=
NULL
;
p_stream
->
p_wf
=
NULL
;
p_stream
->
p_bih
=
malloc
(
sizeof
(
BITMAPINFOHEADER
)
+
p_stream
->
p_bih
=
malloc
(
sizeof
(
BITMAPINFOHEADER
)
+
p_input
->
p_fmt
->
i_extra
);
p_input
->
p_fmt
->
i_extra
);
if
(
!
p_stream
->
p_bih
)
{
free
(
p_input
->
p_sys
);
return
VLC_ENOMEM
;
}
#define p_bih p_stream->p_bih
#define p_bih p_stream->p_bih
p_bih
->
biSize
=
sizeof
(
BITMAPINFOHEADER
)
+
p_bih
->
biSize
=
sizeof
(
BITMAPINFOHEADER
)
+
p_input
->
p_fmt
->
i_extra
;
p_input
->
p_fmt
->
i_extra
;
...
@@ -395,11 +414,10 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
...
@@ -395,11 +414,10 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
static
int
DelStream
(
sout_mux_t
*
p_mux
,
sout_input_t
*
p_input
)
static
int
DelStream
(
sout_mux_t
*
p_mux
,
sout_input_t
*
p_input
)
{
{
msg_Dbg
(
p_mux
,
"removing input"
);
msg_Dbg
(
p_mux
,
"removing input"
);
free
(
p_input
->
p_sys
);
free
(
p_input
->
p_sys
);
return
(
0
)
;
return
0
;
}
}
static
int
Mux
(
sout_mux_t
*
p_mux
)
static
int
Mux
(
sout_mux_t
*
p_mux
)
...
...
modules/mux/dummy.c
View file @
6b44362d
...
@@ -84,6 +84,8 @@ static int Open( vlc_object_t *p_this )
...
@@ -84,6 +84,8 @@ static int Open( vlc_object_t *p_this )
p_mux
->
pf_mux
=
Mux
;
p_mux
->
pf_mux
=
Mux
;
p_mux
->
p_sys
=
p_sys
=
malloc
(
sizeof
(
sout_mux_sys_t
)
);
p_mux
->
p_sys
=
p_sys
=
malloc
(
sizeof
(
sout_mux_sys_t
)
);
if
(
!
p_sys
)
return
VLC_ENOMEM
;
p_sys
->
b_header
=
true
;
p_sys
->
b_header
=
true
;
return
VLC_SUCCESS
;
return
VLC_SUCCESS
;
...
...
modules/mux/mp4.c
View file @
6b44362d
...
@@ -193,6 +193,8 @@ static int Open( vlc_object_t *p_this )
...
@@ -193,6 +193,8 @@ static int Open( vlc_object_t *p_this )
p_mux
->
pf_delstream
=
DelStream
;
p_mux
->
pf_delstream
=
DelStream
;
p_mux
->
pf_mux
=
Mux
;
p_mux
->
pf_mux
=
Mux
;
p_mux
->
p_sys
=
p_sys
=
malloc
(
sizeof
(
sout_mux_sys_t
)
);
p_mux
->
p_sys
=
p_sys
=
malloc
(
sizeof
(
sout_mux_sys_t
)
);
if
(
!
p_sys
)
return
VLC_ENOMEM
;
p_sys
->
i_pos
=
0
;
p_sys
->
i_pos
=
0
;
p_sys
->
i_nb_streams
=
0
;
p_sys
->
i_nb_streams
=
0
;
p_sys
->
pp_streams
=
NULL
;
p_sys
->
pp_streams
=
NULL
;
...
@@ -422,6 +424,8 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
...
@@ -422,6 +424,8 @@ static int AddStream( sout_mux_t *p_mux, sout_input_t *p_input )
}
}
p_stream
=
malloc
(
sizeof
(
mp4_stream_t
)
);
p_stream
=
malloc
(
sizeof
(
mp4_stream_t
)
);
if
(
!
p_stream
)
return
VLC_ENOMEM
;
es_format_Copy
(
&
p_stream
->
fmt
,
p_input
->
p_fmt
);
es_format_Copy
(
&
p_stream
->
fmt
,
p_input
->
p_fmt
);
p_stream
->
i_track_id
=
p_sys
->
i_nb_streams
+
1
;
p_stream
->
i_track_id
=
p_sys
->
i_nb_streams
+
1
;
p_stream
->
i_length_neg
=
0
;
p_stream
->
i_length_neg
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment