Skip to content

V
vlc
Commit 423e5997 authored by Ilkka Ollakka's avatar Ilkka Ollakka Committed by Rafaël Carré
Browse files
Options

fix xspf extension parsing for leaking 

Signed-off-by: default avatarRafaël Carré <funman@videolan.org>
parent 883c4fc1
Show whitespace changes
Inline Side-by-side
Showing with 2 additions and 1 deletion
modules/demux/playlist/xspf.c
View file @ 423e5997
...@@ -558,7 +558,6 @@ static vlc_bool_t parse_track_node COMPLEX_INTERFACE ...@@ -558,7 +558,6 @@ static vlc_bool_t parse_track_node COMPLEX_INTERFACE
free( psz_uri ); free( psz_uri );
psz_uri = psz_tmp; psz_uri = psz_tmp;
} }
/* FIXME: We are leaking that one */
p_new_input = input_ItemNewExt( p_playlist, psz_uri, p_new_input = input_ItemNewExt( p_playlist, psz_uri,
NULL, 0, NULL, -1 ); NULL, 0, NULL, -1 );
free( psz_uri ); free( psz_uri );
...@@ -724,6 +723,7 @@ static vlc_bool_t parse_extension_node COMPLEX_INTERFACE ...@@ -724,6 +723,7 @@ static vlc_bool_t parse_extension_node COMPLEX_INTERFACE
{ {
input_ItemAddSubItem( p_input_item, p_new_input ); input_ItemAddSubItem( p_input_item, p_new_input );
p_input_item = p_new_input; p_input_item = p_new_input;
vlc_gc_decref( p_new_input );
} }
free( psz_title ); free( psz_title );
} }
...@@ -899,6 +899,7 @@ static vlc_bool_t parse_extitem_node COMPLEX_INTERFACE ...@@ -899,6 +899,7 @@ static vlc_bool_t parse_extitem_node COMPLEX_INTERFACE
if( p_new_input ) if( p_new_input )
{ {
input_ItemAddSubItem( p_input_item, p_new_input ); input_ItemAddSubItem( p_input_item, p_new_input );
vlc_gc_decref( p_new_input );
p_demux->p_sys->pp_tracklist[i_href] = NULL; p_demux->p_sys->pp_tracklist[i_href] = NULL;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment