Update mechanism: split update.c

Move cryptography specific functions into their own file, together with
functions downloading public key / signatures
Factorize common code for generating signatures (hash_sha1_from_*)
Remove unused update_WaitDownload (was OSX specific)

include/vlc_update.h

@@ -63,7 +63,6 @@ VLC_EXPORT( void, update_Check, ( update_t *, void (*callback)( void*, bool ), v
 VLC_EXPORT( bool, update_NeedUpgrade, ( update_t * ) );
 VLC_EXPORT( void, update_Download, ( update_t *, const char* ) );
 VLC_EXPORT( update_release_t*, update_GetRelease, ( update_t * ) );
-VLC_EXPORT( void, update_WaitDownload, ( update_t * ) );
 
 /**
  * @}

src/Makefile.am

@@ -417,6 +417,7 @@ SOURCES_libvlc_common = \
 	misc/error.c \
 	misc/update.h \
 	misc/update.c \
+	misc/update_crypto.c \
 	misc/xml.c \
 	misc/devices.c \
 	extras/libc.c \

src/misc/update.h

@@ -37,6 +37,8 @@
  * XXX
  */
 
+#include <vlc_update.h>
+
 enum    /* Public key algorithms */
 {
     /* we will only use DSA public keys */
@@ -162,6 +164,7 @@ typedef struct
     void (*pf_callback)( void *, bool );
     void *p_data;
 } update_check_thread_t;
+
 /**
  * The update object. Stores (and caches) all information relative to updates
  */
@@ -175,3 +178,58 @@ struct update_t
     update_check_thread_t *p_check;
 };
 
+/*
+ * download a public key (the last one) from videolan server, and parse it
+ */
+public_key_t *
+download_key(
+        vlc_object_t *p_this, const uint8_t *p_longid,
+        const uint8_t *p_signature_issuer );
+
+/*
+ * fill a public_key_t with public key data, including:
+ *   * public key packet
+ *   * signature packet issued by key which long id is p_sig_issuer
+ *   * user id packet
+ */
+int
+parse_public_key(
+        const uint8_t *p_key_data, size_t i_key_len, public_key_t *p_key,
+        const uint8_t *p_sig_issuer );
+
+/*
+ * Verify an OpenPGP signature made on some SHA-1 hash, with some DSA public key
+ */
+int
+verify_signature(
+        uint8_t *p_r, uint8_t *p_s, public_key_packet_t *p_key,
+        uint8_t *p_hash );
+
+/*
+ * Download the signature associated to a document or a binary file.
+ * We're given the file's url, we just append ".asc" to it and download
+ */
+int
+download_signature(
+        vlc_object_t *p_this, signature_packet_t *p_sig, const char *psz_url );
+
+/*
+ * return a sha1 hash of a text
+ */
+uint8_t *
+hash_sha1_from_text(
+        const char *psz_text, signature_packet_t *p_sig );
+
+/*
+ * return a sha1 hash of a file
+ */
+uint8_t *
+hash_sha1_from_file(
+        const char *psz_file, signature_packet_t *p_sig );
+
+/*
+ * return a sha1 hash of a public key
+ */
+uint8_t *
+hash_sha1_from_public_key( public_key_t *p_pkey );
+