* fixed several format string inconsistencies and deprecated C constructions.

modules/access/ftp.c

@@ -2,7 +2,7 @@
  * ftp.c:
  *****************************************************************************
  * Copyright (C) 2001, 2002 VideoLAN
- * $Id: ftp.c,v 1.2 2002/12/16 15:17:12 fenrir Exp $
+ * $Id: ftp.c,v 1.3 2002/12/18 14:17:09 sam Exp $
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *
@@ -350,7 +350,7 @@ static int Open( vlc_object_t *p_this )
     }
 #endif
 
-    msg_Dbg( p_input, "file size:%d", p_access->i_filesize );
+    msg_Dbg( p_input, "file size: "I64Fd, p_access->i_filesize );
     FREE( psz_arg );
 
     if( ftp_StartStream( p_input, 0 ) < 0 )

modules/access/mms/mms.c

@@ -2,7 +2,7 @@
  * mms.c: MMS access plug-in
  *****************************************************************************
  * Copyright (C) 2001, 2002 VideoLAN
- * $Id: mms.c,v 1.13 2002/12/12 15:10:58 gbazin Exp $
+ * $Id: mms.c,v 1.14 2002/12/18 14:17:09 sam Exp $
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *
@@ -1559,11 +1559,15 @@ static int  mms_ParseCommand( input_thread_t *p_input,
              GET32( 0 ),
              GET32( 4 ),
              GET32( 8 ),
+             /* 12: protocol type "MMS " */
              GET32( 16 ),
              GET32( 20 ),
+             /* 24: unknown (0) */
+             /* 28: unknown (0) */
              GET32( 32 ),
-             GET32( 36 ),
-             GET32( 40 ) );
+             GET32( 36 )
+             /* 40: switches */
+             /* 44: extra */ );
 
     p_access->i_command = GET32( 36 ) & 0xffff;
 

modules/audio_output/oss.c

@@ -2,7 +2,7 @@
  * oss.c : OSS /dev/dsp module for vlc
  *****************************************************************************
  * Copyright (C) 2000-2002 VideoLAN
- * $Id: oss.c,v 1.38 2002/12/10 18:22:01 gbazin Exp $
+ * $Id: oss.c,v 1.39 2002/12/18 14:17:09 sam Exp $
  *
  * Authors: Michel Kaempf <maxx@via.ecp.fr>
  *          Samuel Hocevar <sam@zoy.org>
@@ -376,7 +376,7 @@ static int Open( vlc_object_t *p_this )
         if( ioctl( p_sys->i_fd, SNDCTL_DSP_CHANNELS, &i_nb_channels ) < 0 ||
             i_nb_channels != aout_FormatNbChannels( &p_aout->output.output ) )
         {
-            msg_Err( p_aout, "cannot set number of audio channels (%x)",
+            msg_Err( p_aout, "cannot set number of audio channels (%s)",
                      aout_FormatPrintChannels( &p_aout->output.output) );
             close( p_sys->i_fd );
             free( p_sys );

modules/codec/adpcm.c

@@ -2,7 +2,7 @@
  * adpcm.c : adpcm variant audio decoder
  *****************************************************************************
  * Copyright (C) 2001, 2002 VideoLAN
- * $Id: adpcm.c,v 1.1 2002/12/03 17:00:16 fenrir Exp $
+ * $Id: adpcm.c,v 1.2 2002/12/18 14:17:10 sam Exp $
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *      
@@ -378,6 +378,7 @@ static void DecodeThread( adec_thread_t *p_adec )
             DecodeAdpcmMs( p_adec, p_aout_buffer );
             break;
         default:
+            break;
     }
 
 

modules/codec/ffmpeg/audio.c

@@ -2,7 +2,7 @@
  * audio.c: audio decoder using ffmpeg library
  *****************************************************************************
  * Copyright (C) 1999-2001 VideoLAN
- * $Id: audio.c,v 1.7 2002/12/06 14:22:55 fenrir Exp $
+ * $Id: audio.c,v 1.8 2002/12/18 14:17:10 sam Exp $
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *
@@ -238,7 +238,7 @@ void  E_( DecodeThread_Audio )( adec_thread_t *p_adec )
         p_adec->p_context->channels > 5 )
     {
         msg_Warn( p_adec->p_fifo,
-                  "invalid channels count", 
+                  "invalid channels count %d",
                   p_adec->p_context->channels );
     }
 

modules/codec/mpeg_video/parser.c

@@ -2,7 +2,7 @@
  * video_parser.c : video parser thread
  *****************************************************************************
  * Copyright (C) 1999-2001 VideoLAN
- * $Id: parser.c,v 1.8 2002/11/28 17:35:00 sam Exp $
+ * $Id: parser.c,v 1.9 2002/12/18 14:17:10 sam Exp $
  *
  * Authors: Christophe Massiot <massiot@via.ecp.fr>
  *          Samuel Hocevar <sam@via.ecp.fr>
@@ -317,22 +317,22 @@ static void EndThread( vpar_thread_t *p_vpar )
 
     vout_Request( p_vpar->p_fifo, p_vpar->p_vout, 0, 0, 0, 0 );
 
-    msg_Dbg( p_vpar->p_fifo, "%d loops among %d sequence(s)",
+    msg_Dbg( p_vpar->p_fifo, "%ld loops among %ld sequence(s)",
              p_vpar->c_loops, p_vpar->c_sequences );
 
 #ifdef HAVE_SYS_TIMES_H
-    msg_Dbg( p_vpar->p_fifo, "cpu usage (user: %d, system: %d)",
+    msg_Dbg( p_vpar->p_fifo, "cpu usage (user: %ld, system: %ld)",
              cpu_usage.tms_utime, cpu_usage.tms_stime );
 #endif
 
-    msg_Dbg( p_vpar->p_fifo, "read %d frames/fields (I %d/P %d/B %d)",
+    msg_Dbg( p_vpar->p_fifo, "read %ld frames/fields (I %ld/P %ld/B %ld)",
              p_vpar->pc_pictures[I_CODING_TYPE]
              + p_vpar->pc_pictures[P_CODING_TYPE]
              + p_vpar->pc_pictures[B_CODING_TYPE],
              p_vpar->pc_pictures[I_CODING_TYPE],
              p_vpar->pc_pictures[P_CODING_TYPE],
              p_vpar->pc_pictures[B_CODING_TYPE] );
-    msg_Dbg( p_vpar->p_fifo, "decoded %d frames/fields (I %d/P %d/B %d)",
+    msg_Dbg( p_vpar->p_fifo, "decoded %ld frames/fields (I %ld/P %ld/B %ld)",
              p_vpar->pc_decoded_pictures[I_CODING_TYPE]
              + p_vpar->pc_decoded_pictures[P_CODING_TYPE]
              + p_vpar->pc_decoded_pictures[B_CODING_TYPE],
@@ -340,7 +340,7 @@ static void EndThread( vpar_thread_t *p_vpar )
              p_vpar->pc_decoded_pictures[P_CODING_TYPE],
              p_vpar->pc_decoded_pictures[B_CODING_TYPE] );
     msg_Dbg( p_vpar->p_fifo,
-             "read %d malformed frames/fields (I %d/P %d/B %d)",
+             "read %ld malformed frames/fields (I %ld/P %ld/B %ld)",
              p_vpar->pc_malformed_pictures[I_CODING_TYPE]
              + p_vpar->pc_malformed_pictures[P_CODING_TYPE]
              + p_vpar->pc_malformed_pictures[B_CODING_TYPE],

modules/demux/asf/libasf.c

@@ -2,7 +2,7 @@
  * libasf.c :
  *****************************************************************************
  * Copyright (C) 2001 VideoLAN
- * $Id: libasf.c,v 1.8 2002/12/06 16:34:06 sam Exp $
+ * $Id: libasf.c,v 1.9 2002/12/18 14:17:10 sam Exp $
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -353,10 +353,11 @@ int  ASF_ReadObject_Index( input_thread_t *p_input,
     msg_Dbg( p_input,
             "Read \"Index Object\" file_id:" GUID_FMT
             " index_entry_time_interval:"I64Fd" max_packet_count:%d "
-            "index_entry_count:%d",
+            "index_entry_count:%ld",
             GUID_PRINT( p_index->i_file_id ),
+            p_index->i_index_entry_time_interval,
             p_index->i_max_packet_count,
-            p_index->i_index_entry_count );
+            (long int)p_index->i_index_entry_count );
 #endif
     return( 1 );
 }

modules/demux/demuxdump.c

@@ -2,7 +2,7 @@
  * demuxdump.c : Pseudo demux module for vlc (dump raw stream)
  *****************************************************************************
  * Copyright (C) 2001 VideoLAN
- * $Id: demuxdump.c,v 1.1 2002/11/13 20:23:21 fenrir Exp $
+ * $Id: demuxdump.c,v 1.2 2002/12/18 14:17:10 sam Exp $
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *
@@ -157,7 +157,7 @@ static void Desactivate ( vlc_object_t *p_this )
     demux_sys_t         *p_demux = (demux_sys_t*)p_input->p_demux_data;
     
     msg_Info( p_input, 
-              "closing %s (%d Kbytes dumped)", 
+              "closing %s ("I64Fd" Kbytes dumped)", 
               p_demux->psz_name,
               p_demux->i_write / 1024 );
    

modules/demux/mp4/libmp4.c

@@ -2,7 +2,7 @@
  * libmp4.c : LibMP4 library for mp4 module for vlc
  *****************************************************************************
  * Copyright (C) 2001 VideoLAN
- * $Id: libmp4.c,v 1.10 2002/12/06 16:34:06 sam Exp $
+ * $Id: libmp4.c,v 1.11 2002/12/18 14:17:10 sam Exp $
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  * 
  * This program is free software; you can redistribute it and/or modify
@@ -1557,7 +1557,7 @@ int MP4_ReadBox_stdp( MP4_Stream_t *p_stream, MP4_Box_t *p_box )
     
     
 #ifdef MP4_VERBOSE 
-    msg_Dbg( p_stream->p_input, "Read Box: \"stdp\" entry-count %d",
+    msg_Dbg( p_stream->p_input, "Read Box: \"stdp\" entry-count "I64Fd,
                       i_read / 2 );
 
 #endif
@@ -1602,7 +1602,7 @@ int MP4_ReadBox_padb( MP4_Stream_t *p_stream, MP4_Box_t *p_box )
     
     
 #ifdef MP4_VERBOSE 
-    msg_Dbg( p_stream->p_input, "Read Box: \"stdp\" entry-count %d",
+    msg_Dbg( p_stream->p_input, "Read Box: \"stdp\" entry-count "I64Fd,
                       i_read / 2 );
 
 #endif
@@ -1661,7 +1661,7 @@ int MP4_ReadBox_elst( MP4_Stream_t *p_stream, MP4_Box_t *p_box )
     
     
 #ifdef MP4_VERBOSE 
-    msg_Dbg( p_stream->p_input, "Read Box: \"elst\" entry-count %d",
+    msg_Dbg( p_stream->p_input, "Read Box: \"elst\" entry-count "I64Fd,
                       i_read / 2 );
 
 #endif

modules/demux/ogg.c

@@ -2,7 +2,7 @@
  * ogg.c : ogg stream input module for vlc
  *****************************************************************************
  * Copyright (C) 2001 VideoLAN
- * $Id: ogg.c,v 1.14 2002/12/16 18:30:12 gbazin Exp $
+ * $Id: ogg.c,v 1.15 2002/12/18 14:17:10 sam Exp $
  *
  * Authors: Gildas Bazin <gbazin@netcourrier.com>
  * 
@@ -457,7 +457,7 @@ static void Ogg_DecodePacket( input_thread_t *p_input,
     if( p_stream->i_fourcc == VLC_FOURCC( 't','a','r','k' ) )
     {
         /* FIXME: the biggest hack I've ever done */
-        msg_Warn( p_input, "tark pts: %lli, granule: %i",
+        msg_Warn( p_input, "tark pts: "I64Fd", granule: "I64Fd,
                   p_pes->i_pts, p_pes->i_dts );
         msleep(10000);
     }

modules/demux/wav/wav.c

@@ -2,7 +2,7 @@
  * wav.c : wav file input module for vlc
  *****************************************************************************
  * Copyright (C) 2001 VideoLAN
- * $Id: wav.c,v 1.7 2002/12/10 23:34:19 gbazin Exp $
+ * $Id: wav.c,v 1.8 2002/12/18 14:17:10 sam Exp $
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  * 
  * This program is free software; you can redistribute it and/or modify
@@ -210,7 +210,7 @@ static int FindTag( input_thread_t *p_input, u32 i_tag )
         i_id   = GetDWLE( p_peek );
         i_size = GetDWLE( p_peek + 4 );
 
-        msg_Dbg( p_input, "FindTag: tag:%4.4s size:%d", &i_id, i_size );
+        msg_Dbg( p_input, "FindTag: tag:%4.4s size:%d", (char*)&i_id, i_size );
         if( i_id == i_tag )
         {
             /* Yes, we have found the good tag */

modules/gui/gtk/display.c

@@ -2,7 +2,7 @@
  * display.c: Gtk+ tools for main interface
  *****************************************************************************
  * Copyright (C) 1999, 2000 VideoLAN
- * $Id: display.c,v 1.5 2002/12/13 01:56:29 gbazin Exp $
+ * $Id: display.c,v 1.6 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Samuel Hocevar <sam@zoy.org>
  *          Stphane Borel <stef@via.ecp.fr>
@@ -288,7 +288,7 @@ void GtkHideToolbarText( vlc_object_t *p_this )
 
     for( i_index = 0; i_index < list.i_count; i_index++ )
     {
-        p_intf = (module_t *)list.p_values[i_index].p_object ;
+        p_intf = (intf_thread_t *)list.p_values[i_index].p_object ;
 
         if( strcmp( MODULE_STRING, p_intf->p_module->psz_object_name ) )
         {

modules/mux/mpeg/ps.c

@@ -2,7 +2,7 @@
  * ps.c
  *****************************************************************************
  * Copyright (C) 2001, 2002 VideoLAN
- * $Id: ps.c,v 1.2 2002/12/15 23:39:41 fenrir Exp $
+ * $Id: ps.c,v 1.3 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *          Eric Petit <titer@videolan.org>
@@ -160,7 +160,7 @@ static int AddStream( sout_instance_t *p_sout, sout_input_t *p_input )
     sout_mux_t          *p_mux = (sout_mux_t*)p_sout->p_mux_data;
     ps_stream_t         *p_stream;
 
-    msg_Dbg( p_sout, "adding input", p_sout );
+    msg_Dbg( p_sout, "adding input" );
     p_input->p_mux_data = (void*)p_stream = malloc( sizeof( ps_stream_t ) );
     p_stream->i_ok = 0;
     switch( p_input->input_format.i_cat )
@@ -188,7 +188,7 @@ static int AddStream( sout_instance_t *p_sout, sout_input_t *p_input )
     }
 
     p_stream->i_ok = 1;
-    msg_Dbg( p_sout, "adding input stream_id:0x%x [OK]", p_stream->i_stream_id, p_sout );
+    msg_Dbg( p_sout, "adding input stream_id:0x%x [OK]", p_stream->i_stream_id );
     return( 0 );
 }
 

src/audio_output/mixer.c

@@ -2,7 +2,7 @@
  * mixer.c : audio output mixing operations
  *****************************************************************************
  * Copyright (C) 2002 VideoLAN
- * $Id: mixer.c,v 1.21 2002/12/06 10:10:39 sam Exp $
+ * $Id: mixer.c,v 1.22 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Christophe Massiot <massiot@via.ecp.fr>
  *
@@ -229,7 +229,7 @@ static int MixBuffer( aout_instance_t * p_aout )
                      + mixer_nb_bytes)) )
             {
                 msg_Warn( p_aout,
-                          "mixer start isn't output start (%d)",
+                          "mixer start isn't output start ("I64Fd,
                           i_nb_bytes - mixer_nb_bytes );
 
                 /* Round to the nearest multiple */

src/input/input.c

@@ -4,7 +4,7 @@
  * decoders.
  *****************************************************************************
  * Copyright (C) 1998-2002 VideoLAN
- * $Id: input.c,v 1.219 2002/12/12 15:23:43 gbazin Exp $
+ * $Id: input.c,v 1.220 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Christophe Massiot <massiot@via.ecp.fr>
  *
@@ -541,10 +541,10 @@ static void EndThread( input_thread_t * p_input )
     struct tms  cpu_usage;
     times( &cpu_usage );
 
-    msg_Dbg( p_input, "%d loops consuming user: %d, system: %d",
+    msg_Dbg( p_input, "%ld loops consuming user: %ld, system: %ld",
              p_input->c_loops, cpu_usage.tms_utime, cpu_usage.tms_stime );
 #else
-    msg_Dbg( p_input, "%d loops", p_input->c_loops );
+    msg_Dbg( p_input, "%ld loops", p_input->c_loops );
 #endif
 
     /* Free info structures */

src/input/input_ext-intf.c

@@ -2,7 +2,7 @@
  * input_ext-intf.c: services to the interface
  *****************************************************************************
  * Copyright (C) 1998-2001 VideoLAN
- * $Id: input_ext-intf.c,v 1.44 2002/12/06 16:34:08 sam Exp $
+ * $Id: input_ext-intf.c,v 1.45 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Christophe Massiot <massiot@via.ecp.fr>
  *
@@ -277,7 +277,7 @@ void input_DumpStream( input_thread_t * p_input )
     unsigned int i, j;
 
 #define S   p_input->stream
-    msg_Dbg( p_input, "dumping stream ID 0x%x [OK:%d/D:%d]", S.i_stream_id,
+    msg_Dbg( p_input, "dumping stream ID 0x%x [OK:%ld/D:%ld]", S.i_stream_id,
              S.c_packets_read, S.c_packets_trashed );
     if( S.b_seekable )
         msg_Dbg( p_input, "seekable stream, position: "I64Fd"/"I64Fd" (%s/%s)",
@@ -299,8 +299,8 @@ void input_DumpStream( input_thread_t * p_input )
         for( j = 0; j < p_input->stream.pp_programs[i]->i_es_number; j++ )
         {
 #define ES  p_input->stream.pp_programs[i]->pp_es[j]
-            msg_Dbg( p_input,
-                     "ES 0x%x, stream 0x%x, fourcc `%4.4s', %s [OK:%d/ERR:%d]",
+            msg_Dbg( p_input, "ES 0x%x, "
+                     "stream 0x%x, fourcc `%4.4s', %s [OK:%ld/ERR:%ld]",
                      ES->i_id, ES->i_stream_id, (char*)&ES->i_fourcc,
                      ES->p_decoder_fifo != NULL ? "selected" : "not selected",
                      ES->c_packets, ES->c_invalid_packets );

src/misc/threads.c

@@ -2,7 +2,7 @@
  * threads.c : threads implementation for the VideoLAN client
  *****************************************************************************
  * Copyright (C) 1999, 2000, 2001, 2002 VideoLAN
- * $Id: threads.c,v 1.29 2002/12/14 19:19:08 gbazin Exp $
+ * $Id: threads.c,v 1.30 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Jean-Marc Dressler <polux@via.ecp.fr>
  *          Samuel Hocevar <sam@zoy.org>
@@ -651,7 +651,7 @@ int __vlc_thread_create( vlc_object_t *p_this, char * psz_file, int i_line,
         p_this->b_thread = 1;
 
         msg_Dbg( p_this, "thread %d (%s) created at priority %d (%s:%d)",
-                 p_this->thread_id, psz_name, i_priority,
+                 (int)p_this->thread_id, psz_name, i_priority,
                  psz_file, i_line );
 
         vlc_mutex_unlock( &p_this->object_lock );
@@ -752,16 +752,17 @@ void __vlc_thread_join( vlc_object_t *p_this, char * psz_file, int i_line )
     {
 #ifdef HAVE_STRERROR
         msg_Err( p_this, "thread_join(%d) failed at %s:%d (%s)",
-                         p_this->thread_id, psz_file, i_line, strerror(i_ret) );
+                         (int)p_this->thread_id, psz_file, i_line,
+                         strerror(i_ret) );
 #else
         msg_Err( p_this, "thread_join(%d) failed at %s:%d",
-                         p_this->thread_id, psz_file, i_line );
+                         (int)p_this->thread_id, psz_file, i_line );
 #endif
     }
     else
     {
         msg_Dbg( p_this, "thread %d joined (%s:%d)",
-                         p_this->thread_id, psz_file, i_line );
+                         (int)p_this->thread_id, psz_file, i_line );
     }
 
     p_this->b_thread = 0;

src/misc/variables.c

@@ -2,7 +2,7 @@
  * variables.c: routines for object variables handling
  *****************************************************************************
  * Copyright (C) 2002 VideoLAN
- * $Id: variables.c,v 1.18 2002/12/14 19:34:06 gbazin Exp $
+ * $Id: variables.c,v 1.19 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Samuel Hocevar <sam@zoy.org>
  *
@@ -497,7 +497,7 @@ int __var_Set( vlc_object_t *p_this, const char *psz_name, vlc_value_t val )
         i_var = Lookup( p_this->p_vars, p_this->i_vars, psz_name );
         if( i_var < 0 )
         {
-            msg_Err( p_this, "variable %s has disappeared" );
+            msg_Err( p_this, "variable %s has disappeared", psz_name );
             vlc_mutex_unlock( &p_this->var_lock );
             return VLC_ENOVAR;
         }

src/video_output/video_output.c

@@ -5,7 +5,7 @@
  * thread, and destroy a previously oppened video output thread.
  *****************************************************************************
  * Copyright (C) 2000-2001 VideoLAN
- * $Id: video_output.c,v 1.204 2002/12/18 08:08:29 gbazin Exp $
+ * $Id: video_output.c,v 1.205 2002/12/18 14:17:11 sam Exp $
  *
  * Authors: Vincent Seguin <seguin@via.ecp.fr>
  *
@@ -477,7 +477,8 @@ static int InitThread( vout_thread_t *p_vout )
         if( p_vout->chroma.p_module == NULL )
         {
             msg_Err( p_vout, "no chroma module for %4.4s to %4.4s",
-                     &p_vout->render.i_chroma, &p_vout->output.i_chroma );
+                     (char*)&p_vout->render.i_chroma,
+                     (char*)&p_vout->output.i_chroma );
             p_vout->pf_end( p_vout );
             vlc_mutex_unlock( &p_vout->change_lock );
             return VLC_EGENERIC;