Win32: vlc_rename() needs to erase target file first, fixes #3521

5581a1ec · Rémi Denis-Courmont · 0d0e440d · 5581a1ec
Commit 5581a1ec authored Apr 16, 2010 by Rémi Denis-Courmont
Show whitespace changes
Inline Side-by-side

Showing with 11 additions and 1 deletion

src/text/filesystem.c src/text/filesystem.c +11 -1

No files found.
--- a/src/text/filesystem.c
+++ b/src/text/filesystem.c
@@ -520,7 +520,17 @@ int vlc_rename (const char *oldpath, const char *newpath)
    else
        return -1;
 #else
-    return _wrename (wold, wnew);
+    if (_wrename (wold, wnew) && errno == EACCES)
+    {   /* Windows does not allow atomic file replacement */
+        if (_wremove (wnew))
+        {
+            errno = EACCES; /* restore errno */
+            return -1;
+        }
+        if (_wrename (wold, wnew))
+            return -1;
+    }
+    return 0;
 #endif

 #endif