libvlc: Fix a (tiny) buffer overflow and fix #2449

02bf31b4 · Rémi Duraffort · 25c10c93 · 02bf31b4
Commit 02bf31b4 authored Jan 26, 2009 by Rémi Duraffort
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

src/libvlc.c src/libvlc.c +6 -3

No files found.
--- a/src/libvlc.c
+++ b/src/libvlc.c
@@ -864,9 +864,12 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc,
    if( psz_modules && *psz_modules && psz_control && *psz_control )
    {
-        psz_modules = (char *)realloc( psz_modules, strlen( psz_modules ) +
+        char* psz_tmp;
-                                                    strlen( psz_control ) + 1 );
+        if( asprintf( &psz_tmp, "%s:%s", psz_modules, psz_control ) != -1 )
-        sprintf( psz_modules, "%s:%s", psz_modules, psz_control );
+        {
+            free( psz_modules );
+            psz_modules = psz_tmp;
+        }
    }
    else if( psz_control && *psz_control )
    {