Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-2-2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-2-2
Commits
e7eb8964
Commit
e7eb8964
authored
Jan 30, 2013
by
Martin Storsjö
Committed by
Rafaël Carré
Jan 30, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
omxil: Update the explanation of the OMX.SEC quirk/workaround
Signed-off-by:
Rafaël Carré
<
funman@videolan.org
>
parent
5290741d
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
8 deletions
+8
-8
modules/codec/omxil/omxil.c
modules/codec/omxil/omxil.c
+8
-8
No files found.
modules/codec/omxil/omxil.c
View file @
e7eb8964
...
@@ -512,14 +512,14 @@ static OMX_ERRORTYPE GetPortDefinition(decoder_t *p_dec, OmxPort *p_port,
...
@@ -512,14 +512,14 @@ static OMX_ERRORTYPE GetPortDefinition(decoder_t *p_dec, OmxPort *p_port,
strlen
(
"OMX.qcom.video.decoder"
)))
strlen
(
"OMX.qcom.video.decoder"
)))
def
->
format
.
video
.
eColorFormat
=
OMX_QCOM_COLOR_FormatYVU420SemiPlanar
;
def
->
format
.
video
.
eColorFormat
=
OMX_QCOM_COLOR_FormatYVU420SemiPlanar
;
/* Hack:
Galaxy S II (stock firmware) gives a slice height larger
/* Hack:
Some Samsung devices (e.g. Galaxy S III) have multiple
*
than the video height, but this doesn't imply padding between
*
H264 decoders with different quirks (OMX.SEC.avc.dec, OMX.SEC.avcdec
*
the video planes. Nexus S also has a slice height larger than
*
and OMX.SEC.AVC.Decoder) - the latter is well-behaved while the
*
the video height, but there it actually is real padding, thus
*
former ones signal padding but in practice doesn't have any padding.
*
Galaxy S II is the buggy one. The Galaxy S II decoder is
*
We can't simply ignore the buggy ones, because some devices only
*
named OMX.SEC.avcdec while the one on Nexus S is
*
have that one (Galaxy S II has only got one named OMX.SEC.avcdec,
*
OMX.SEC.AVC.Decoder. Thus do this for any OMX.SEC. that don't
*
at least in the pre-4.0 firmwares). Thus, we enable this quirk on
* contain the string ".Decoder". */
*
any OMX.SEC. decoder that doesn't
contain the string ".Decoder". */
if
(
!
strncmp
(
p_sys
->
psz_component
,
"OMX.SEC."
,
strlen
(
"OMX.SEC."
))
&&
if
(
!
strncmp
(
p_sys
->
psz_component
,
"OMX.SEC."
,
strlen
(
"OMX.SEC."
))
&&
!
strstr
(
p_sys
->
psz_component
,
".Decoder"
))
!
strstr
(
p_sys
->
psz_component
,
".Decoder"
))
def
->
format
.
video
.
nSliceHeight
=
0
;
def
->
format
.
video
.
nSliceHeight
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment