Commit d42739f8 authored by Clément Stenac's avatar Clément Stenac

Fix interaction locking

parent 1b481ca9
...@@ -143,7 +143,8 @@ protected: ...@@ -143,7 +143,8 @@ protected:
{ {
QSettings settings( "VideoLAN", "VLC" ); QSettings settings( "VideoLAN", "VLC" );
settings.beginGroup( name ); settings.beginGroup( name );
resize( settings.value( "size", defSize ).toSize() ); QSize s = settings.value( "size", defSize ).toSize() ;
fprintf( stderr, "%i %i ", s.width(), s.height() );
move( settings.value( "pos", QPoint( 0,0 ) ).toPoint() ); move( settings.value( "pos", QPoint( 0,0 ) ).toPoint() );
settings.endGroup(); settings.endGroup();
} }
......
...@@ -568,7 +568,6 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog ) ...@@ -568,7 +568,6 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog )
} }
else else
p_dialog->i_status = UPDATED_DIALOG; p_dialog->i_status = UPDATED_DIALOG;
vlc_mutex_unlock( &p_interaction->object_lock );
if( p_dialog->i_type == INTERACT_DIALOG_TWOWAY ) // Wait for answer if( p_dialog->i_type == INTERACT_DIALOG_TWOWAY ) // Wait for answer
{ {
...@@ -577,15 +576,17 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog ) ...@@ -577,15 +576,17 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog )
p_dialog->i_status != HIDDEN_DIALOG && p_dialog->i_status != HIDDEN_DIALOG &&
!p_dialog->p_parent->b_die ) !p_dialog->p_parent->b_die )
{ {
vlc_mutex_unlock( &p_interaction->object_lock );
msleep( 100000 ); msleep( 100000 );
vlc_mutex_lock( &p_interaction->object_lock );
} }
/// \todo locking ?
if( p_dialog->p_parent->b_die ) if( p_dialog->p_parent->b_die )
{ {
p_dialog->i_return = DIALOG_CANCELLED; p_dialog->i_return = DIALOG_CANCELLED;
p_dialog->i_status = ANSWERED_DIALOG; p_dialog->i_status = ANSWERED_DIALOG;
} }
p_dialog->i_flags |= DIALOG_GOT_ANSWER; p_dialog->i_flags |= DIALOG_GOT_ANSWER;
vlc_mutex_unlock( &p_interaction->object_lock );
return p_dialog->i_return; return p_dialog->i_return;
} }
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment