Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-2-2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-2-2
Commits
b4b357ee
Commit
b4b357ee
authored
Jun 04, 2011
by
Rémi Duraffort
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
taglib: use the taglib version to decide if apefile is available.
parent
a1271085
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
5 deletions
+11
-5
configure.ac
configure.ac
+0
-1
modules/meta_engine/taglib.cpp
modules/meta_engine/taglib.cpp
+11
-4
No files found.
configure.ac
View file @
b4b357ee
...
@@ -1778,7 +1778,6 @@ AS_IF([test "${enable_taglib}" != "no"], [
...
@@ -1778,7 +1778,6 @@ AS_IF([test "${enable_taglib}" != "no"], [
VLC_ADD_CXXFLAGS([taglib],[$TAGLIB_CFLAGS])
VLC_ADD_CXXFLAGS([taglib],[$TAGLIB_CFLAGS])
AC_LANG_PUSH(C++)
AC_LANG_PUSH(C++)
AC_CHECK_HEADERS(taglib/mp4coverart.h)
AC_CHECK_HEADERS(taglib/mp4coverart.h)
AC_CHECK_HEADERS(taglib/apefile.h)
AC_LANG_POP(C++)
AC_LANG_POP(C++)
], [
], [
AC_MSG_WARN(TagLib library not found)])
AC_MSG_WARN(TagLib library not found)])
...
...
modules/meta_engine/taglib.cpp
View file @
b4b357ee
...
@@ -45,6 +45,12 @@
...
@@ -45,6 +45,12 @@
// Taglib headers
// Taglib headers
#include <taglib.h>
#define VERSION_INT(a, b, c) ((a)<<16 | (b)<<8 | (c))
#define TAGLIB_VERSION VERSION_INT(TAGLIB_MAJOR_VERSION, \
TAGLIB_MINOR_VERSION, \
TAGLIB_PATCH_VERSION)
#include <fileref.h>
#include <fileref.h>
#include <tag.h>
#include <tag.h>
#include <tbytevector.h>
#include <tbytevector.h>
...
@@ -53,8 +59,9 @@
...
@@ -53,8 +59,9 @@
#include <id3v2tag.h>
#include <id3v2tag.h>
#include <xiphcomment.h>
#include <xiphcomment.h>
#ifdef HAVE_TAGLIB_APEFILE_H
#if TAGLIB_VERSION >= VERSION_INT(1,7,0)
#include <apefile.h>
# define TAGLIB_HAVE_APEFILE_H
# include <apefile.h>
#endif
#endif
#include <flacfile.h>
#include <flacfile.h>
#include <mpcfile.h>
#include <mpcfile.h>
...
@@ -438,7 +445,7 @@ static int ReadMeta( vlc_object_t* p_this)
...
@@ -438,7 +445,7 @@ static int ReadMeta( vlc_object_t* p_this)
// Try now to read special tags
// Try now to read special tags
#ifdef
HAVE_TAGLIB
_APEFILE_H
#ifdef
TAGLIB_HAVE
_APEFILE_H
if
(
APE
::
File
*
ape
=
dynamic_cast
<
APE
::
File
*>
(
f
.
file
())
)
if
(
APE
::
File
*
ape
=
dynamic_cast
<
APE
::
File
*>
(
f
.
file
())
)
{
{
if
(
ape
->
APETag
()
)
if
(
ape
->
APETag
()
)
...
@@ -664,7 +671,7 @@ static int WriteMeta( vlc_object_t *p_this )
...
@@ -664,7 +671,7 @@ static int WriteMeta( vlc_object_t *p_this )
// Try now to write special tags
// Try now to write special tags
#ifdef
HAVE_TAGLIB
_APEFILE_H
#ifdef
TAGLIB_HAVE
_APEFILE_H
if
(
APE
::
File
*
ape
=
dynamic_cast
<
APE
::
File
*>
(
f
.
file
())
)
if
(
APE
::
File
*
ape
=
dynamic_cast
<
APE
::
File
*>
(
f
.
file
())
)
{
{
if
(
ape
->
APETag
()
)
if
(
ape
->
APETag
()
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment