Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-2-2
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-2-2
Commits
b479244a
Commit
b479244a
authored
May 08, 2007
by
Pierre d'Herbemont
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Mac OS X gui: Protect against NULL string, and fix filter window crash.
parent
39e14fc7
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
8 deletions
+15
-8
modules/gui/macosx/sfilters.m
modules/gui/macosx/sfilters.m
+15
-8
No files found.
modules/gui/macosx/sfilters.m
View file @
b479244a
...
@@ -224,6 +224,8 @@ static VLCsFilters *_o_sharedInstance = nil;
...
@@ -224,6 +224,8 @@ static VLCsFilters *_o_sharedInstance = nil;
-
(
void
)
showAsPanel
-
(
void
)
showAsPanel
{
{
char
*
psz_temp
;
/* called from intf.m */
/* called from intf.m */
[
o_sfilter_win
displayIfNeeded
];
[
o_sfilter_win
displayIfNeeded
];
[
o_sfilter_win
makeKeyAndOrderFront
:
nil
];
[
o_sfilter_win
makeKeyAndOrderFront
:
nil
];
...
@@ -245,8 +247,11 @@ static VLCsFilters *_o_sharedInstance = nil;
...
@@ -245,8 +247,11 @@ static VLCsFilters *_o_sharedInstance = nil;
}
}
}
}
[
o_marq_color_pop
selectItemAtIndex
:
x
];
[
o_marq_color_pop
selectItemAtIndex
:
x
];
[
o_marq_marq_fld
setStringValue
:
[
NSString
stringWithUTF8String
:
if
(
psz_temp
=
config_GetPsz
(
p_intf
,
"time-format"
)
)
config_GetPsz
(
p_intf
,
"marq-marquee"
)]];
[
o_marq_marq_fld
setStringValue
:
[
NSString
stringWithUTF8String
:
psz_temp
]];
else
[
o_marq_marq_fld
setStringValue
:
_NS
(
@"Not Available"
)];
[
o_marq_opaque_sld
setIntValue
:
config_GetInt
(
p_intf
,
"marq-opacity"
)];
[
o_marq_opaque_sld
setIntValue
:
config_GetInt
(
p_intf
,
"marq-opacity"
)];
[
o_marq_pos_radio
selectCellWithTag
:
config_GetInt
(
p_intf
,
"marq-position"
)];
[
o_marq_pos_radio
selectCellWithTag
:
config_GetInt
(
p_intf
,
"marq-position"
)];
/* FIXME: the following line doesn't work with "-1", which is the default
/* FIXME: the following line doesn't work with "-1", which is the default
...
@@ -273,8 +278,11 @@ static VLCsFilters *_o_sharedInstance = nil;
...
@@ -273,8 +278,11 @@ static VLCsFilters *_o_sharedInstance = nil;
}
}
}
}
[
o_time_color_pop
selectItemAtIndex
:
x
];
[
o_time_color_pop
selectItemAtIndex
:
x
];
[
o_time_stamp_fld
setStringValue
:
[
NSString
stringWithUTF8String
:
if
(
psz_temp
=
config_GetPsz
(
p_intf
,
"time-format"
)
)
config_GetPsz
(
p_intf
,
"time-format"
)]];
[
o_time_stamp_fld
setStringValue
:
[
NSString
stringWithUTF8String
:
psz_temp
]];
else
[
o_time_stamp_fld
setStringValue
:
_NS
(
@"Not Available"
)];
[
o_time_opaque_sld
setIntValue
:
config_GetInt
(
p_intf
,
"time-opacity"
)];
[
o_time_opaque_sld
setIntValue
:
config_GetInt
(
p_intf
,
"time-opacity"
)];
/* FIXME: the following line doesn't work with "-1", which is the default
/* FIXME: the following line doesn't work with "-1", which is the default
* value */
* value */
...
@@ -286,9 +294,8 @@ static VLCsFilters *_o_sharedInstance = nil;
...
@@ -286,9 +294,8 @@ static VLCsFilters *_o_sharedInstance = nil;
/* retrieve the logo settings */
/* retrieve the logo settings */
[
o_logo_opaque_sld
setIntValue
:
config_GetInt
(
p_intf
,
"logo-transparency"
)];
[
o_logo_opaque_sld
setIntValue
:
config_GetInt
(
p_intf
,
"logo-transparency"
)];
/* in case that no path has been saved yet */
/* in case that no path has been saved yet */
if
(
config_GetPsz
(
p_intf
,
"logo-file"
)
)
if
(
psz_temp
=
config_GetPsz
(
p_intf
,
"logo-file"
)
)
[
o_logo_image_fld
setStringValue
:
[
NSString
stringWithUTF8String
:
[
o_logo_image_fld
setStringValue
:
[
NSString
stringWithUTF8String
:
psz_temp
]];
config_GetPsz
(
p_intf
,
"logo-file"
)]];
else
else
[
o_logo_image_fld
setStringValue
:
@""
];
[
o_logo_image_fld
setStringValue
:
@""
];
[
o_logo_pos_radio
selectCellWithTag
:
config_GetInt
(
p_intf
,
"logo-position"
)];
[
o_logo_pos_radio
selectCellWithTag
:
config_GetInt
(
p_intf
,
"logo-position"
)];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment