macosx: destroy lua dialogs correctly on close (close #8567)

b2e47226 · Felix Paul Kühne · 5a60b824 · b2e47226
Commit b2e47226 authored May 11, 2013 by Felix Paul Kühne
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

modules/gui/macosx/ExtensionsDialogProvider.m modules/gui/macosx/ExtensionsDialogProvider.m +6 -2

No files found.
--- a/modules/gui/macosx/ExtensionsDialogProvider.m
+++ b/modules/gui/macosx/ExtensionsDialogProvider.m
@@ -497,10 +497,14 @@ static ExtensionsDialogProvider *_o_sharedInstance = nil;
    assert(p_dialog);

    VLCDialogWindow *dialogWindow = (VLCDialogWindow*) p_dialog->p_sys_intf;
-    if (!dialogWindow)
+    if (!dialogWindow) {
+        msg_Warn(VLCIntf, "dialog window not found");
        return VLC_EGENERIC;
+    }

-    [VLCDialogWindow release];
+    [dialogWindow setDelegate:nil];
+    [dialogWindow close];
+    dialogWindow = nil;

    p_dialog->p_sys_intf = NULL;
    vlc_cond_signal(&p_dialog->cond);