Skip to content

V
vlc-2-2
Commit 6b723625 authored by Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf
Browse files
Options

Qt: preferences, fix checkbox behaviours 

Remove weird layout margins, and zones for correct deactivations of
groups of groupBoxes
parent 94b30f51
Show whitespace changes
Inline Side-by-side
Showing with 474 additions and 528 deletions
modules/gui/qt4/components/simple_preferences.cpp
View file @ 6b723625
......@@ -215,6 +215,9 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
******************************/
START_SPREFS_CAT( Video , qtr("Video Settings") );
CONFIG_BOOL( "video", enableVideo );
ui.videoZone->setEnabled( ui.enableVideo->isChecked() );
CONNECT( ui.enableVideo, toggled( bool ),
ui.videoZone, setEnabled( bool ) );
CONFIG_BOOL( "fullscreen", fullscreen );
CONFIG_BOOL( "overlay", overlay );
......@@ -259,9 +262,9 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
START_SPREFS_CAT( Audio, qtr("Audio Settings") );
CONFIG_BOOL( "audio", enableAudio );
ui.SPrefsAudio_zone->setEnabled( ui.enableAudio->isChecked() );
ui.audioZone->setEnabled( ui.enableAudio->isChecked() );
CONNECT( ui.enableAudio, toggled( bool ),
ui.SPrefsAudio_zone, setEnabled( bool ) );
ui.audioZone, setEnabled( bool ) );
#define audioCommon( name ) \
QWidget * name ## Control = new QWidget( ui.outputAudioBox ); \
......@@ -649,6 +652,9 @@ SPrefsPanel::SPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
ui.OSDTitlePosLabel, OSDTitlePos );
CONFIG_BOOL( "spu", spuActiveBox);
ui.spuZone->setEnabled( ui.spuActiveBox->isChecked() );
CONNECT( ui.spuActiveBox, toggled( bool ),
ui.spuZone, setEnabled( bool ) );
CONFIG_GENERIC( "subsdec-encoding", StringList, ui.encodLabel,
encoding );
......
modules/gui/qt4/ui/sprefs_audio.ui
View file @ 6b723625
......@@ -7,8 +7,8 @@
<rect>
<x>0</x>
<y>0</y>
<width>703</width>
<height>656</height>
<width>707</width>
<height>536</height>
</rect>
</property>
<property name="sizePolicy">
......@@ -32,8 +32,11 @@
</widget>
</item>
<item>
<widget class="QWidget" name="SPrefsAudio_zone" native="true">
<layout class="QVBoxLayout" name="verticalLayout">
<widget class="QWidget" name="audioZone" native="true">
<layout class="QVBoxLayout" name="audioZoneLayout">
<property name="margin">
<number>0</number>
</property>
<item>
<widget class="QGroupBox" name="audioBox">
<property name="title">
......@@ -166,9 +169,6 @@
<property name="text">
<string>Output module:</string>
</property>
<property name="buddy">
<cstring>outputModule</cstring>
</property>
</widget>
</item>
<item row="0" column="1">
......@@ -204,9 +204,6 @@
<property name="text">
<string>Destination file:</string>
</property>
<property name="buddy">
<cstring>fileName</cstring>
</property>
</widget>
</item>
<item>
......@@ -264,9 +261,6 @@
<property name="text">
<string>Visualization:</string>
</property>
<property name="buddy">
<cstring>visualisation</cstring>
</property>
</widget>
</item>
<item row="8" column="2" colspan="2">
......@@ -309,9 +303,6 @@
<property name="text">
<string>Dolby Surround:</string>
</property>
<property name="buddy">
<cstring>detectionDolby</cstring>
</property>
</widget>
</item>
<item row="5" column="0">
......@@ -328,9 +319,6 @@
<property name="alignment">
<set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignVCenter</set>
</property>
<property name="buddy">
<cstring>replayCombo</cstring>
</property>
</widget>
</item>
<item row="5" column="2" colspan="2">
......@@ -447,9 +435,6 @@
<property name="text">
<string>Preferred audio language:</string>
</property>
<property name="buddy">
<cstring>preferredAudioLanguage</cstring>
</property>
</widget>
</item>
<item row="0" column="1">
......@@ -501,9 +486,6 @@
<property name="alignment">
<set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
</property>
<property name="buddy">
<cstring>lastfm_pass_edit</cstring>
</property>
</widget>
</item>
<item row="0" column="0">
......@@ -520,9 +502,6 @@
<property name="alignment">
<set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
</property>
<property name="buddy">
<cstring>lastfm_user_edit</cstring>
</property>
</widget>
</item>
</layout>
......
modules/gui/qt4/ui/sprefs_subtitles.ui
View file @ 6b723625
......@@ -8,7 +8,7 @@
<x>0</x>
<y>0</y>
<width>741</width>
<height>373</height>
<height>375</height>
</rect>
</property>
<property name="windowTitle">
......@@ -67,6 +67,12 @@
</property>
</widget>
</item>
<item>
<widget class="QWidget" name="spuZone" native="true">
<layout class="QVBoxLayout" name="spuZoneLayout">
<property name="margin">
<number>0</number>
</property>
<item>
<widget class="QGroupBox" name="groupBox_2">
<property name="sizePolicy">
......@@ -90,9 +96,6 @@
<property name="text">
<string>Preferred subtitles language</string>
</property>
<property name="buddy">
<cstring>preferredLanguage</cstring>
</property>
</widget>
</item>
<item row="1" column="1">
......@@ -116,9 +119,6 @@
<property name="text">
<string>Default encoding</string>
</property>
<property name="buddy">
<cstring>encoding</cstring>
</property>
</widget>
</item>
</layout>
......@@ -141,9 +141,6 @@
<property name="text">
<string>Font</string>
</property>
<property name="buddy">
<cstring>font</cstring>
</property>
</widget>
</item>
<item row="0" column="1" colspan="3">
......@@ -160,9 +157,6 @@
<property name="text">
<string>Font size</string>
</property>
<property name="buddy">
<cstring>fontSize</cstring>
</property>
</widget>
</item>
<item row="1" column="1">
......@@ -196,9 +190,6 @@
<property name="text">
<string>Font color</string>
</property>
<property name="buddy">
<cstring>fontColor</cstring>
</property>
</widget>
</item>
<item row="1" column="4">
......@@ -215,9 +206,6 @@
<property name="text">
<string>Outline thickness</string>
</property>
<property name="buddy">
<cstring>effect</cstring>
</property>
</widget>
</item>
<item row="2" column="1">
......@@ -235,9 +223,6 @@
<property name="text">
<string>Outline color</string>
</property>
<property name="buddy">
<cstring>outlineColor</cstring>
</property>
</widget>
</item>
<item row="2" column="4">
......@@ -268,9 +253,6 @@
<property name="text">
<string>Force subtitle position</string>
</property>
<property name="buddy">
<cstring>subsPosition</cstring>
</property>
</widget>
</item>
<item row="4" column="1">
......@@ -300,6 +282,9 @@
</item>
</layout>
</widget>
</item>
</layout>
</widget>
<tabstops>
<tabstop>OSDBox</tabstop>
<tabstop>OSDTitleBox</tabstop>
......
modules/gui/qt4/ui/sprefs_video.ui
View file @ 6b723625
......@@ -7,20 +7,14 @@
<rect>
<x>0</x>
<y>0</y>
<width>699</width>
<height>615</height>
<width>682</width>
<height>577</height>
</rect>
</property>
<property name="windowTitle">
<string>Form</string>
</property>
<layout class="QVBoxLayout">
<property name="spacing">
<number>10</number>
</property>
<property name="margin">
<number>9</number>
</property>
<layout class="QVBoxLayout" name="verticalLayout_3">
<item>
<widget class="QCheckBox" name="enableVideo">
<property name="text">
......@@ -31,6 +25,12 @@
</property>
</widget>
</item>
<item>
<widget class="QWidget" name="videoZone" native="true">
<layout class="QVBoxLayout" name="videoZoneLayout">
<property name="margin">
<number>0</number>
</property>
<item>
<widget class="QGroupBox" name="displayBox">
<property name="title">
......@@ -50,48 +50,45 @@
</property>
</widget>
</item>
<item row="2" column="0" colspan="2">
<widget class="QCheckBox" name="alwaysOnTop">
<item row="2" column="2">
<widget class="QCheckBox" name="windowDecorations">
<property name="text">
<string>Always on top</string>
<string>Window decorations</string>
</property>
</widget>
</item>
<item row="8" column="1" colspan="2">
<widget class="QComboBox" name="outputModule">
<property name="maxVisibleItems">
<number>15</number>
<item row="1" column="2">
<widget class="QCheckBox" name="hwYUVBox">
<property name="text">
<string>Use hardware YUV-&gt;RGB conversions</string>
</property>
</widget>
</item>
<item row="8" column="0">
<widget class="QLabel" name="voutLabel">
<item row="1" column="0" colspan="2">
<widget class="QCheckBox" name="overlay">
<property name="text">
<string>Output</string>
</property>
<property name="buddy">
<cstring>outputModule</cstring>
<string>Accelerated video output (Overlay)</string>
</property>
</widget>
</item>
<item row="2" column="2">
<widget class="QCheckBox" name="windowDecorations">
<item row="8" column="0">
<widget class="QLabel" name="voutLabel">
<property name="text">
<string>Window decorations</string>
<string>Output</string>
</property>
</widget>
</item>
<item row="1" column="0" colspan="2">
<widget class="QCheckBox" name="overlay">
<item row="2" column="0" colspan="2">
<widget class="QCheckBox" name="alwaysOnTop">
<property name="text">
<string>Accelerated video output (Overlay)</string>
<string>Always on top</string>
</property>
</widget>
</item>
<item row="1" column="2">
<widget class="QCheckBox" name="hwYUVBox">
<property name="text">
<string>Use hardware YUV-&gt;RGB conversions</string>
<item row="8" column="1" colspan="2">
<widget class="QComboBox" name="outputModule">
<property name="maxVisibleItems">
<number>15</number>
</property>
</widget>
</item>
......@@ -118,9 +115,6 @@
<property name="text">
<string>Display device</string>
</property>
<property name="buddy">
<cstring>dXdisplayDevice</cstring>
</property>
</widget>
</item>
</layout>
......@@ -138,17 +132,11 @@
<property name="spacing">
<number>6</number>
</property>
<item row="1" column="1" colspan="2">
<widget class="QComboBox" name="kvaVideoMode"/>
</item>
<item row="1" column="0">
<widget class="QLabel" name="kvaVideoModeLabel">
<property name="text">
<string>Video mode</string>
</property>
<property name="buddy">
<cstring>kvaVideoMode</cstring>
</property>
</widget>
</item>
<item row="0" column="0" colspan="2">
......@@ -158,6 +146,9 @@
</property>
</widget>
</item>
<item row="1" column="1" colspan="2">
<widget class="QComboBox" name="kvaVideoMode"/>
</item>
</layout>
</widget>
</item>
......@@ -172,9 +163,6 @@
<property name="text">
<string>Deinterlacing</string>
</property>
<property name="buddy">
<cstring>deinterlaceBox</cstring>
</property>
</widget>
</item>
<item row="1" column="0">
......@@ -182,9 +170,6 @@
<property name="text">
<string>Force Aspect Ratio</string>
</property>
<property name="buddy">
<cstring>arLine</cstring>
</property>
</widget>
</item>
<item row="0" column="1">
......@@ -208,9 +193,6 @@
<property name="text">
<string>Mode</string>
</property>
<property name="buddy">
<cstring>deinterlaceModeBox</cstring>
</property>
</widget>
</item>
<item row="0" column="3">
......@@ -256,9 +238,6 @@
<property name="text">
<string>Directory</string>
</property>
<property name="buddy">
<cstring>snapshotsDirectory</cstring>
</property>
</widget>
</item>
<item row="1" column="0">
......@@ -266,9 +245,6 @@
<property name="text">
<string>Prefix</string>
</property>
<property name="buddy">
<cstring>snapshotsPrefix</cstring>
</property>
</widget>
</item>
<item row="1" column="2">
......@@ -283,9 +259,6 @@
<property name="text">
<string>Format</string>
</property>
<property name="buddy">
<cstring>snapshotsFormat</cstring>
</property>
</widget>
</item>
<item row="1" column="3" colspan="2">
......@@ -319,6 +292,9 @@
</item>
</layout>
</widget>
</item>
</layout>
</widget>
<tabstops>
<tabstop>enableVideo</tabstop>
<tabstop>fullscreen</tabstop>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment