macosx: added code to enable/disable video filters and modify a few properties.

dialog not yet fully functional

modules/gui/macosx/VideoEffects.h

@@ -28,6 +28,7 @@
     /* generic */
     intf_thread_t *p_intf;
     IBOutlet id o_window;
+    IBOutlet id o_tableView;
 
     /* basic */
     IBOutlet id o_adjust_ckb;
@@ -140,6 +141,8 @@
 
 /* generic */
 + (VLCVideoEffects *)sharedInstance;
+- (void)resetValues;
+- (void)setVideoFilter: (char *)psz_name on:(BOOL)b_on;
 
 /* basic */
 - (IBAction)enableAdjust:(id)sender;

modules/gui/macosx/VideoEffects.m

@@ -25,6 +25,9 @@
 #import <vlc_common.h>
 #import "VideoEffects.h"
 
+#pragma mark -
+#pragma mark Initialization & Generic code
+
 @implementation VLCVideoEffects
 static VLCVideoEffects *_o_sharedInstance = nil;
 
@@ -45,42 +48,378 @@ static VLCVideoEffects *_o_sharedInstance = nil;
     return _o_sharedInstance;
 }
 
+- (void)awakeFromNib
+{
+    [o_window setTitle: _NS("Video Effects")];
+    [o_window setExcludedFromWindowsMenu:YES];
+    [[o_tableView tabViewItemAtIndex:[o_tableView indexOfTabViewItemWithIdentifier:@"basic"]] setLabel:_NS("Basic")];
+    [[o_tableView tabViewItemAtIndex:[o_tableView indexOfTabViewItemWithIdentifier:@"crop"]] setLabel:_NS("Crop")];
+    [[o_tableView tabViewItemAtIndex:[o_tableView indexOfTabViewItemWithIdentifier:@"geometry"]] setLabel:_NS("Geometry")];
+    [[o_tableView tabViewItemAtIndex:[o_tableView indexOfTabViewItemWithIdentifier:@"color"]] setLabel:_NS("Color")];
+    [[o_tableView tabViewItemAtIndex:[o_tableView indexOfTabViewItemWithIdentifier:@"overlay"]] setLabel:_NS("Video output/Overlay")];
+    [[o_tableView tabViewItemAtIndex:[o_tableView indexOfTabViewItemWithIdentifier:@"logo"]] setLabel:_NS("Logo")];
+
+    [o_adjust_ckb setTitle:_NS("Image Adjust")];
+    [o_adjust_hue_lbl setStringValue:_NS("Hue")];
+    [o_adjust_contrast_lbl setStringValue:_NS("Contrast")];
+    [o_adjust_brightness_lbl setStringValue:_NS("Brightness")];
+    [o_adjust_brightness_ckb setTitle:_NS("Brightness Threshold")];
+    [o_adjust_saturation_lbl setStringValue:_NS("Saturation")];
+    [o_adjust_gamma_lbl setStringValue:_NS("Gamma")];
+    [o_adjust_opaque_lbl setStringValue:_NS("Opaqueness")];
+    [o_sharpen_ckb setTitle:_NS("Sharpen")];
+    [o_sharpen_lbl setStringValue:_NS("Sigma")];
+    [o_banding_ckb setTitle:_NS("Banding removal")];
+    [o_banding_lbl setStringValue:_NS("Radius")];
+    [o_grain_ckb setTitle:_NS("Film Grain")];
+    [o_grain_lbl setStringValue:_NS("Variance")];
+    [o_crop_top_lbl setStringValue:_NS("Top")];
+    [o_crop_left_lbl setStringValue:_NS("Left")];
+    [o_crop_right_lbl setStringValue:_NS("Right")];
+    [o_crop_bottom_lbl setStringValue:_NS("Bottom")];
+    [o_crop_sync_top_bottom_ckb setTitle:_NS("Synchronize top and bottom")];
+    [o_crop_sync_left_right_ckb setTitle:_NS("Synchronize left and right")];
+
+    [o_transform_ckb setTitle:_NS("Transform")];
+    [o_transform_pop removeAllItems];
+    [o_transform_pop addItemWithTitle: _NS("Rotate by 90 degrees")];
+    [[o_transform_pop lastItem] setTag: 90];
+    [o_transform_pop addItemWithTitle: _NS("Rotate by 180 degrees")];
+    [[o_transform_pop lastItem] setTag: 180];
+    [o_transform_pop addItemWithTitle: _NS("Rotate by 270 degrees")];
+    [[o_transform_pop lastItem] setTag: 270];
+    [o_transform_pop addItemWithTitle: _NS("Flip horizontally")];
+    [[o_transform_pop lastItem] setTag: 1];
+    [o_transform_pop addItemWithTitle: _NS("Flip vertically")];
+    [[o_transform_pop lastItem] setTag: 2];
+    [o_zoom_ckb setTitle:_NS("Magnification/Zoom")];
+    [o_puzzle_ckb setTitle:_NS("Puzzle game")];
+    [o_puzzle_rows_lbl setStringValue:_NS("Rows")];
+    [o_puzzle_columns_lbl setStringValue:_NS("Columns")];
+    [o_puzzle_blackslot_ckb setTitle:_NS("Black Slot")];
+
+    [o_threshold_ckb setTitle:_NS("Color threshold")];
+    [o_threshold_color_lbl setStringValue:_NS("Color")];
+    [o_threshold_saturation_lbl setStringValue:_NS("Saturation")];
+    [o_threshold_similarity_lbl setStringValue:_NS("Similarity")];
+    [o_sepia_ckb setTitle:_NS("Sepia")];
+    [o_sepia_lbl setStringValue:_NS("Intensity")];
+    [o_noise_ckb setTitle:_NS("Noise")];
+    [o_gradient_ckb setTitle:_NS("Gradient")];
+    [o_gradient_mode_lbl setStringValue:_NS("Mode")];
+    [o_gradient_mode_pop removeAllItems];
+    [o_gradient_mode_pop addItemWithTitle: _NS("Gradient")];
+    [[o_gradient_mode_pop lastItem] setTag: 1];
+    [o_gradient_mode_pop addItemWithTitle: _NS("Edge")];
+    [[o_gradient_mode_pop lastItem] setTag: 2];
+    [o_gradient_mode_pop addItemWithTitle: _NS("Hough")];
+    [[o_gradient_mode_pop lastItem] setTag: 3];
+    [o_gradient_color_ckb setTitle:_NS("Color")];
+    [o_gradient_cartoon_ckb setTitle:_NS("Cartoon")];
+    [o_extract_ckb setTitle:_NS("Color extraction")];
+    [o_extract_lbl setStringValue:_NS("Color")];
+    [o_invert_ckb setTitle:_NS("Invert colors")];
+    [o_posterize_ckb setTitle:_NS("Posterize")];
+    [o_posterize_lbl setStringValue:_NS("Posterize level")];
+    [o_blur_ckb setTitle:_NS("Motion blue")];
+    [o_blur_lbl setStringValue:_NS("Factor")];
+    [o_motiondetect_ckb setTitle:_NS("Motion Detect")];
+    [o_watereffect_ckb setTitle:_NS("Water effect")];
+    [o_waves_ckb setTitle:_NS("Waves")];
+    [o_psychedelic_ckb setTitle:_NS("Psychedelic")];
+
+    [o_clone_ckb setTitle:_NS("Image clone")];
+    [o_clone_lbl setStringValue:_NS("Number of clones")];
+    [o_addtext_ckb setTitle:_NS("Add text")];
+    [o_addtext_text_lbl setStringValue:_NS("Text")];
+    [o_addtext_pos_lbl setStringValue:_NS("Position")];
+    [o_addtext_pos_pop removeAllItems];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Center")];
+    [[o_addtext_pos_pop lastItem] setTag: 0];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Left")];
+    [[o_addtext_pos_pop lastItem] setTag: 1];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Right")];
+    [[o_addtext_pos_pop lastItem] setTag: 2];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Top")];
+    [[o_addtext_pos_pop lastItem] setTag: 4];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Bottom")];
+    [[o_addtext_pos_pop lastItem] setTag: 8];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Top-Left")];
+    [[o_addtext_pos_pop lastItem] setTag: 5];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Top-Right")];
+    [[o_addtext_pos_pop lastItem] setTag: 6];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Bottom-Left")];
+    [[o_addtext_pos_pop lastItem] setTag: 9];
+    [o_addtext_pos_pop addItemWithTitle: _NS("Bottom-Right")];
+    [[o_addtext_pos_pop lastItem] setTag: 10];
+
+    [o_addlogo_ckb setTitle:_NS("Add logo")];
+    [o_addlogo_logo_lbl setStringValue:_NS("Logo")];
+    [o_addlogo_top_lbl setStringValue:_NS("Top")];
+    [o_addlogo_left_lbl setStringValue:_NS("Left")];
+    [o_addlogo_transparency_lbl setStringValue:_NS("Transparency")];
+    [o_eraselogo_ckb setTitle:_NS("Logo erase")];
+    [o_eraselogo_mask_lbl setStringValue:_NS("Mask")];
+    [o_eraselogo_top_lbl setStringValue:_NS("Top")];
+    [o_eraselogo_left_lbl setStringValue:_NS("Left")];
+
+    [self resetValues];
+}
+
+- (void)resetValues
+{
+    NSString *tmpString;
+    /* do we have any filter enabled? if yes, show it. */
+    char * psz_vfilters;
+    psz_vfilters = config_GetPsz( p_intf, "video-filter" );
+    if( psz_vfilters ) {
+        [o_adjust_ckb setState: (NSInteger)strstr( psz_vfilters, "adjust")];
+        [o_sharpen_ckb setState: (NSInteger)strstr( psz_vfilters, "sharpen")];
+        [o_banding_ckb setState: (NSInteger)strstr( psz_vfilters, "gradfun")];
+        [o_grain_ckb setState: (NSInteger)strstr( psz_vfilters, "grain")];
+        [o_transform_ckb setState: (NSInteger)strstr( psz_vfilters, "transform")];
+        [o_zoom_ckb setState: (NSInteger)strstr( psz_vfilters, "magnify")];
+        [o_puzzle_ckb setState: (NSInteger)strstr( psz_vfilters, "puzzle")];
+        [o_threshold_ckb setState: (NSInteger)strstr( psz_vfilters, "colorthres")];
+        [o_sepia_ckb setState: (NSInteger)strstr( psz_vfilters, "sepia")];
+        [o_noise_ckb setState: (NSInteger)strstr( psz_vfilters, "noise")];
+        [o_gradient_ckb setState: (NSInteger)strstr( psz_vfilters, "gradient")];
+        [o_extract_ckb setState: (NSInteger)strstr( psz_vfilters, "extract")];
+        [o_invert_ckb setState: (NSInteger)strstr( psz_vfilters, "invert")];
+        [o_posterize_ckb setState: (NSInteger)strstr( psz_vfilters, "posterize")];
+        [o_blur_ckb setState: (NSInteger)strstr( psz_vfilters, "motionblur")];
+        [o_motiondetect_ckb setState: (NSInteger)strstr( psz_vfilters, "motiondetect")];
+        [o_watereffect_ckb setState: (NSInteger)strstr( psz_vfilters, "ripple")];
+        [o_waves_ckb setState: (NSInteger)strstr( psz_vfilters, "wave")];
+        [o_psychedelic_ckb setState: (NSInteger)strstr( psz_vfilters, "psychedelic")];
+        [o_clone_ckb setState: (NSInteger)strstr( psz_vfilters, "clone")];
+        free( psz_vfilters );
+    }
+    // TODO: don't forget about o_addtext_ckb, o_addlogo_ckb, o_eraselogo_ckb
+
+    /* fetch and show the various values */
+    [o_adjust_hue_sld setIntValue: config_GetInt( p_intf, "hue" )];
+    [o_adjust_contrast_sld setFloatValue: config_GetFloat( p_intf, "contrast" )];
+    [o_adjust_brightness_sld setFloatValue: config_GetFloat( p_intf, "brightness" )];
+    [o_adjust_saturation_sld setFloatValue: config_GetFloat( p_intf, "saturation" )];
+    [o_adjust_gamma_sld setFloatValue: config_GetFloat( p_intf, "gamma" )];
+    [o_adjust_brightness_sld setEnabled: [o_adjust_ckb state]];
+    [o_adjust_brightness_ckb setEnabled: [o_adjust_ckb state]];
+    [o_adjust_contrast_sld setEnabled: [o_adjust_ckb state]];
+    [o_adjust_gamma_sld setEnabled: [o_adjust_ckb state]];
+    [o_adjust_hue_sld setEnabled: [o_adjust_ckb state]];
+    [o_adjust_saturation_sld setEnabled: [o_adjust_ckb state]];
+    [o_adjust_opaque_sld setFloatValue: config_GetFloat( p_intf, "macosx-opaqueness" )];
+    [o_adjust_opaque_sld setEnabled: NO]; // FIXME: not implemented!
+    [o_sharpen_sld setFloatValue: config_GetFloat( p_intf, "sharpen-sigma" )];
+    [o_sharpen_sld setEnabled: [o_sharpen_ckb state]];
+    [o_banding_sld setIntValue: config_GetInt( p_intf, "gradfun-radius" )];
+    [o_banding_sld setEnabled: [o_banding_ckb state]];
+    [o_grain_sld setFloatValue: config_GetFloat( p_intf, "grain-variance" )];
+    [o_grain_sld setEnabled: [o_grain_sld state]];
+
+    [o_crop_top_fld setIntValue: 0];
+    [o_crop_left_fld setIntValue: 0];
+    [o_crop_right_fld setIntValue: 0];
+    [o_crop_bottom_fld setIntValue: 0];
+    [o_crop_sync_top_bottom_ckb setState: NSOffState];
+    [o_crop_sync_left_right_ckb setState: NSOffState];
+
+    tmpString = [NSString stringWithUTF8String: config_GetPsz( p_intf, "transform-type" )];
+    if( [tmpString isEqualToString:@"hflip"] )
+        [o_transform_pop selectItemWithTag: 1];
+    else if( [tmpString isEqualToString:@"vflip"] )
+        [o_transform_pop selectItemWithTag: 2];
+    else
+        [o_transform_pop selectItemWithTag:[tmpString intValue]];
+    [o_transform_pop setEnabled: [o_transform_ckb state]];
+    [o_puzzle_rows_fld setIntValue: config_GetInt( p_intf, "puzzle-rows" )];
+    [o_puzzle_columns_fld setIntValue: config_GetInt( p_intf, "puzzle-cols" )];
+    [o_puzzle_blackslot_ckb setState: config_GetInt( p_intf, "puzzle-black-slot" )];
+    [o_puzzle_rows_fld setEnabled: [o_puzzle_ckb state]];
+    [o_puzzle_columns_fld setEnabled: [o_puzzle_ckb state]];
+    [o_puzzle_blackslot_ckb setEnabled: [o_puzzle_ckb state]];
+
+    [o_threshold_color_fld setStringValue: [NSString stringWithFormat:@"%x", config_GetInt( p_intf, "colorthres-color" )]];
+    [o_threshold_saturation_sld setIntValue: config_GetInt( p_intf, "colorthres-saturationthres" )];
+    [o_threshold_similarity_sld setIntValue: config_GetInt( p_intf, "colorthres-similaritythres" )];
+    [o_threshold_color_fld setEnabled: [o_threshold_ckb state]];
+    [o_threshold_saturation_sld setEnabled: [o_threshold_ckb state]];
+    [o_threshold_similarity_sld setEnabled: [o_threshold_ckb state]];
+    [o_sepia_fld setIntValue: config_GetInt( p_intf, "sepia-intensity" )];
+    [o_sepia_fld setEnabled: [o_sepia_ckb state]];
+    tmpString = [NSString stringWithUTF8String: config_GetPsz( p_intf, "gradient-mode" )];
+    if( [tmpString isEqualToString:@"hough"] )
+        [o_gradient_mode_pop selectItemWithTag: 3];
+    else if( [tmpString isEqualToString:@"edge"] )
+        [o_gradient_mode_pop selectItemWithTag: 2];
+    else
+        [o_gradient_mode_pop selectItemWithTag: 1];
+    [o_gradient_cartoon_ckb setState: config_GetInt( p_intf, "gradient-cartoon" )];
+    [o_gradient_color_ckb setState: config_GetInt( p_intf, "gradient-type" )];
+    [o_gradient_mode_pop setEnabled: [o_gradient_ckb state]];
+    [o_gradient_cartoon_ckb setEnabled: [o_gradient_ckb state]];
+    [o_gradient_color_ckb setEnabled: [o_gradient_ckb state]];
+    [o_extract_fld setStringValue: [NSString stringWithFormat:@"%x", config_GetInt( p_intf, "extract-component" )]];
+    [o_extract_fld setEnabled: [o_extract_ckb state]];
+    [o_posterize_fld setIntValue: config_GetInt( p_intf, "posterize-level" )];
+    [o_posterize_fld setEnabled: [o_posterize_ckb state]];
+    [o_blur_sld setIntValue: config_GetInt( p_intf, "blur-factor" )];
+    [o_blur_sld setEnabled: [o_blur_ckb state]];
+
+    [o_clone_fld setIntValue: config_GetInt( p_intf, "clone-count" )];
+    [o_clone_fld setEnabled: [o_clone_ckb state]];
+    if( config_GetPsz( p_intf, "marq-marquee" ) )
+        [o_addtext_text_fld setStringValue: [NSString stringWithUTF8String: config_GetPsz( p_intf, "marq-marquee" )]];
+    [o_addtext_pos_pop selectItemWithTag: config_GetInt( p_intf, "marq-position" )];
+
+    if( config_GetPsz( p_intf, "logo-file" ) )
+       [o_addlogo_logo_fld setStringValue: [NSString stringWithUTF8String: config_GetPsz( p_intf, "logo-file" )]];
+    [o_addlogo_top_fld setIntValue: config_GetInt( p_intf, "logo-x" )];
+    [o_addlogo_left_fld setIntValue: config_GetInt( p_intf, "logo-y" )];
+    [o_addlogo_transparency_sld setIntValue: config_GetInt( p_intf, "logo-opacity" )];
+    [o_addlogo_logo_fld setEnabled: [o_addlogo_ckb state]];
+    [o_addlogo_left_fld setEnabled: [o_addlogo_ckb state]];
+    [o_addlogo_top_fld setEnabled: [o_addlogo_ckb state]];
+    if( config_GetPsz( p_intf, "erase-mask" ) )
+        [o_eraselogo_mask_fld setStringValue: [NSString stringWithUTF8String: config_GetPsz( p_intf, "erase-mask" )]];
+    [o_eraselogo_top_fld setIntValue: config_GetInt( p_intf, "erase-x" )];
+    [o_eraselogo_left_fld setIntValue: config_GetInt( p_intf, "erase-y" )];
+    [o_eraselogo_mask_fld setEnabled: [o_eraselogo_ckb state]];
+    [o_eraselogo_left_fld setEnabled: [o_eraselogo_ckb state]];
+    [o_eraselogo_top_fld setEnabled: [o_eraselogo_ckb state]];
+}
+
+- (void)setVideoFilter: (char *)psz_name on:(BOOL)b_on
+{
+    char *psz_tmp;
+    vout_thread_t * p_vout = getVout();
+    if( p_vout )
+        psz_tmp = var_GetNonEmptyString( p_vout, "video-filter" );
+    else
+        psz_tmp = config_GetPsz( p_intf, "video-filter" );
+
+    if( b_on )
+    {
+        if(! psz_tmp)
+            config_PutPsz( p_intf, "video-filter", psz_name );
+        else if( (NSInteger)strstr( psz_tmp, psz_name ) == NO )
+        {
+            psz_tmp = (char *)[[NSString stringWithFormat: @"%s:%s", psz_tmp, psz_name] UTF8String];
+            config_PutPsz( p_intf, "video-filter", psz_tmp );
+        }
+    } else {
+        if( psz_tmp )
+        {
+            psz_tmp = (char *)[[[NSString stringWithUTF8String: psz_tmp] stringByTrimmingCharactersInSet: [NSCharacterSet characterSetWithCharactersInString:[NSString stringWithFormat:@":%s",psz_name]]] UTF8String];
+            psz_tmp = (char *)[[[NSString stringWithUTF8String: psz_tmp] stringByTrimmingCharactersInSet: [NSCharacterSet characterSetWithCharactersInString:[NSString stringWithFormat:@"%s:",psz_name]]] UTF8String];
+            psz_tmp = (char *)[[[NSString stringWithUTF8String: psz_tmp] stringByTrimmingCharactersInSet: [NSCharacterSet characterSetWithCharactersInString:[NSString stringWithUTF8String:psz_name]]] UTF8String];
+            config_PutPsz( p_intf, "video-filter", psz_tmp );
+        }
+    }
+
+    if( p_vout ) {
+        var_SetString( p_vout, "video-filter", psz_tmp );
+        vlc_object_release( p_vout );
+    }
+}
+
 #pragma mark -
 #pragma mark basic
 - (IBAction)enableAdjust:(id)sender
 {
+    BOOL state = [o_adjust_ckb state];
+    [self setVideoFilter: "adjust" on:[o_adjust_ckb state]];
+    [o_adjust_brightness_sld setEnabled: state];
+    [o_adjust_brightness_ckb setEnabled: state];
+    [o_adjust_contrast_sld setEnabled: state];
+    [o_adjust_gamma_sld setEnabled: state];
+    [o_adjust_hue_sld setEnabled: state];
+    [o_adjust_saturation_sld setEnabled: state];
 }
 
 - (IBAction)adjustSliderChanged:(id)sender
 {
+    vout_thread_t *p_vout = getVout();
+    vlc_object_t *p_filter;
+
+    if( p_vout == NULL ) {
+        if( sender == o_adjust_brightness_sld )
+            config_PutFloat( p_intf , "brightness" , [o_adjust_brightness_sld floatValue] );
+        else if( sender == o_adjust_contrast_sld )
+            config_PutFloat( p_intf , "contrast" , [o_adjust_contrast_sld floatValue] );
+        else if( sender == o_adjust_gamma_sld )
+            config_PutFloat( p_intf , "gamma" , [o_adjust_gamma_sld floatValue] );
+        else if( sender == o_adjust_hue_sld )
+            config_PutInt( p_intf , "hue" , [o_adjust_hue_sld intValue] );
+        else if( sender == o_adjust_saturation_sld )
+            config_PutFloat( p_intf , "saturation" , [o_adjust_saturation_sld floatValue] );
+    } else {
+        p_filter = vlc_object_find_name( pl_Get(p_intf), "adjust" );
+
+        if(! p_filter ) {
+            msg_Err( p_intf, "we're unable to find the adjust filter!" );
+            vlc_object_release( p_vout );
+            return;
+        }
+
+        if( sender == o_adjust_brightness_sld ) {
+            var_SetFloat( p_filter, "brightness", [o_adjust_brightness_sld floatValue] );
+            config_PutFloat( p_intf, "brightness", [o_adjust_brightness_sld floatValue] );
+        } else if( sender == o_adjust_contrast_sld ) {
+            var_SetFloat( p_filter, "contrast", [o_adjust_contrast_sld floatValue] );
+            config_PutFloat( p_intf, "contrast", [o_adjust_contrast_sld floatValue] );
+        } else if( sender == o_adjust_gamma_sld ) {
+            var_SetFloat( p_filter, "gamma", [o_adjust_gamma_sld floatValue] );
+            config_PutFloat( p_intf, "gamma", [o_adjust_gamma_sld floatValue] );
+        } else if( sender == o_adjust_hue_sld ) {
+            var_SetInteger( p_filter, "hue", [o_adjust_hue_sld intValue] );
+            config_PutInt( p_intf , "hue" , [o_adjust_hue_sld intValue] );
+        } else if( sender == o_adjust_saturation_sld ) {
+            var_SetFloat( p_filter, "saturation", [o_adjust_saturation_sld floatValue] );
+            config_PutFloat( p_intf , "saturation" , [o_adjust_saturation_sld floatValue] );
+        }
+        vlc_object_release( p_filter );
+        vlc_object_release( p_vout );
+    }
 }
 
 - (IBAction)enableAdjustBrightnessThreshold:(id)sender
 {
+    config_PutInt( p_intf, "brightness-threshold", [o_adjust_brightness_ckb state] );
 }
 
 - (IBAction)enableSharpen:(id)sender
 {
+    [self setVideoFilter: "sharpen" on: [o_sharpen_ckb state]];
+    [o_sharpen_sld setEnabled: [o_sharpen_ckb state]];
 }
 
 - (IBAction)sharpenSliderChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableBanding:(id)sender
 {
+    [self setVideoFilter: "gradfun" on: [o_banding_ckb state]];
+    [o_banding_sld setEnabled: [o_banding_ckb state]];
 }
 
 - (IBAction)bandingSliderChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableGrain:(id)sender
 {
+    [self setVideoFilter: "grain" on: [o_grain_ckb state]];
+    [o_grain_sld setEnabled: [o_grain_ckb state]];
 }
 
 - (IBAction)grainSliderChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 
@@ -88,10 +427,15 @@ static VLCVideoEffects *_o_sharedInstance = nil;
 #pragma mark crop
 - (IBAction)cropFieldChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
+    /* set crop values to corresponding variables, no storage */
 }
 
 - (IBAction)enableCropModifier:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
+    /* when activated, bottom is set to top, right is set to left
+     * no storage of this selection */
 }
 
 
@@ -99,22 +443,36 @@ static VLCVideoEffects *_o_sharedInstance = nil;
 #pragma mark geometry
 - (IBAction)enableTransform:(id)sender
 {
+    [self setVideoFilter: "transform" on: [o_transform_ckb state]];
+    [o_transform_pop setEnabled: [o_transform_ckb state]];
 }
 
 - (IBAction)transformModifierChanged:(id)sender
 {
+    if( [[o_transform_pop selectedItem] tag] == 1 )
+        config_PutPsz( p_intf, "transform-type", "hflip" );
+    else if( [[o_transform_pop selectedItem] tag] == 2 )
+        config_PutPsz( p_intf, "transform-type", "vflip" );
+    else
+        config_PutPsz( p_intf, "transform-type", (char *)[o_transform_pop tag] );
 }
 
 - (IBAction)enableZoom:(id)sender
 {
+    [self setVideoFilter: "magnify" on: [o_zoom_ckb state]];
 }
 
 - (IBAction)enablePuzzle:(id)sender
 {
+    [self setVideoFilter: "puzzle" on: [o_puzzle_ckb state]];
+    [o_puzzle_columns_fld setEnabled: [o_puzzle_ckb state]];
+    [o_puzzle_rows_fld setEnabled: [o_puzzle_ckb state]];
+    [o_puzzle_blackslot_ckb setEnabled: [o_puzzle_ckb state]];
 }
 
 - (IBAction)puzzleModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 
@@ -122,74 +480,102 @@ static VLCVideoEffects *_o_sharedInstance = nil;
 #pragma mark color
 - (IBAction)enableThreshold:(id)sender
 {
+    [self setVideoFilter: "colorthres" on: [o_threshold_ckb state]];
+    [o_threshold_color_fld setEnabled: [o_threshold_ckb state]];
+    [o_threshold_saturation_sld setEnabled: [o_threshold_ckb state]];
+    [o_threshold_similarity_sld setEnabled: [o_threshold_ckb state]];
 }
 
 - (IBAction)thresholdModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableSepia:(id)sender
 {
+    [self setVideoFilter: "sepia" on: [o_sepia_ckb state]];
+    [o_sepia_fld setEnabled: [o_sepia_ckb state]];
 }
 
 - (IBAction)sepiaModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableNoise:(id)sender
 {
+    [self setVideoFilter: "noise" on: [o_noise_ckb state]];
 }
 
 - (IBAction)enableGradient:(id)sender
 {
+    [self setVideoFilter: "gradient" on: [o_gradient_ckb state]];
+    [o_gradient_mode_pop setEnabled: [o_gradient_ckb state]];
+    [o_gradient_color_ckb setEnabled: [o_gradient_ckb state]];
+    [o_gradient_cartoon_ckb setEnabled: [o_gradient_ckb state]];
 }
 
 - (IBAction)gradientModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableExtract:(id)sender
 {
+    [self setVideoFilter: "extract" on: [o_extract_ckb state]];
+    [o_extract_fld setEnabled: [o_extract_ckb state]];
 }
 
 - (IBAction)extractModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableInvert:(id)sender
 {
+    [self setVideoFilter: "invert" on: [o_invert_ckb state]];
 }
 
 - (IBAction)enablePosterize:(id)sender
 {
+    [self setVideoFilter: "posterize" on: [o_posterize_ckb state]];
+    [o_posterize_fld setEnabled: [o_posterize_ckb state]];
 }
 
 - (IBAction)posterizeModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableBlur:(id)sender
 {
+    [self setVideoFilter: "motionblur" on: [o_blur_ckb state]];
+    [o_blur_sld setEnabled: [o_blur_ckb state]];
 }
 
 - (IBAction)blurModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableMotionDetect:(id)sender
 {
+    [self setVideoFilter: "motiondetect" on: [o_motiondetect_ckb state]];
 }
 
 - (IBAction)enableWaterEffect:(id)sender
 {
+    [self setVideoFilter: "ripple" on: [o_watereffect_ckb state]];
 }
 
 - (IBAction)enableWaves:(id)sender
 {
+    [self setVideoFilter: "wave" on: [o_waves_ckb state]];
 }
 
 - (IBAction)enablePsychedelic:(id)sender
 {
+    [self setVideoFilter: "psychedelic" on: [o_psychedelic_ckb state]];
 }
 
 
@@ -201,14 +587,17 @@ static VLCVideoEffects *_o_sharedInstance = nil;
 
 - (IBAction)cloneModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableAddText:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)addTextModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 
@@ -216,18 +605,22 @@ static VLCVideoEffects *_o_sharedInstance = nil;
 #pragma mark logo
 - (IBAction)enableAddLogo:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)addLogoModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)enableEraseLogo:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }
 
 - (IBAction)eraseLogoModifierChanged:(id)sender
 {
+    msg_Dbg( p_intf, "not yet implemented" );
 }