Skip to content

V
vlc-2-2
Commit 60f0938f authored by Rémi Duraffort's avatar Rémi Duraffort
Browse files
Options

dbus control: AFAIK we must lock here.

parent 57a63ce7
Show whitespace changes
Inline Side-by-side
Showing with 7 additions and 2 deletions
modules/control/dbus.c
View file @ 60f0938f
...@@ -419,8 +419,11 @@ DBUS_METHOD( GetCurrentTrack ) ...@@ -419,8 +419,11 @@ DBUS_METHOD( GetCurrentTrack )
REPLY_INIT; REPLY_INIT;
OUT_ARGUMENTS; OUT_ARGUMENTS;
/* XXX: how about locking?! */ playlist_t *p_playlist = PL;
PL_LOCK;
dbus_int32_t i_position = PL->i_current_index; dbus_int32_t i_position = PL->i_current_index;
PL_UNLOCK;
ADD_INT32( &i_position ); ADD_INT32( &i_position );
REPLY_SEND; REPLY_SEND;
...@@ -462,9 +465,11 @@ DBUS_METHOD( GetLength ) ...@@ -462,9 +465,11 @@ DBUS_METHOD( GetLength )
{ {
REPLY_INIT; REPLY_INIT;
OUT_ARGUMENTS; OUT_ARGUMENTS;
playlist_t *p_playlist = PL;
/* XXX: how about locking */ PL_LOCK;
dbus_int32_t i_elements = PL->current.i_size; dbus_int32_t i_elements = PL->current.i_size;
PL_UNLOCK;
ADD_INT32( &i_elements ); ADD_INT32( &i_elements );
REPLY_SEND; REPLY_SEND;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment