Commit 4892f03c authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

getopt: remove strict POSIX ordering

Most probably nobody uses this (in VLC context). In fact, it would
cause many existing VLC command line examples /out there/ to fail
mysteriously.

This simplifies the code a little bit and kills a static variable.
parent 238e0f41
...@@ -27,20 +27,6 @@ ...@@ -27,20 +27,6 @@
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>
/* This version of `getopt' appears to the caller like standard Unix `getopt'
but it behaves differently for the user, since it allows the user
to intersperse the options with the other arguments.
As `getopt' works, it permutes the elements of ARGV so that,
when it is done, all the options precede everything else. Thus
all application programs are extended to handle flexible argument order.
Setting the environment variable POSIXLY_CORRECT disables permutation.
Then the behavior is completely standard.
GNU application programs can use a third alternative mode in which
they can distinguish the relative order of options and other arguments. */
#include "vlc_getopt.h" #include "vlc_getopt.h"
/* For communication from `getopt' to the caller. /* For communication from `getopt' to the caller.
...@@ -79,33 +65,6 @@ static char *nextchar; ...@@ -79,33 +65,6 @@ static char *nextchar;
int vlc_optopt = '?'; int vlc_optopt = '?';
/* Describe how to deal with options that follow non-option ARGV-elements.
If the caller did not specify anything,
the default is REQUIRE_ORDER if the environment variable
POSIXLY_CORRECT is defined, PERMUTE otherwise.
REQUIRE_ORDER means don't recognize them as options;
stop option processing when the first non-option is seen.
This is what Unix does.
This mode of operation is selected by either setting the environment
variable POSIXLY_CORRECT, or using `+' as the first character
of the list of option characters.
PERMUTE is the default. We permute the contents of ARGV as we scan,
so that eventually all the non-options are at the end. This allows options
to be given in any order, even with programs that were not written to
expect this.
The special argument `--' forces an end of option-scanning regardless
of the value of `ordering'. */
static enum
{
REQUIRE_ORDER, PERMUTE
}
ordering;
/* Handle permutation of arguments. */ /* Handle permutation of arguments. */
/* Describe the part of ARGV that contains non-options that have /* Describe the part of ARGV that contains non-options that have
...@@ -182,29 +141,6 @@ static void ...@@ -182,29 +141,6 @@ static void
last_nonopt = vlc_optind; last_nonopt = vlc_optind;
} }
/* Initialize the internal data when the first call is made. */
static const char *vlc_getopt_initialize(const char *optstring)
{
/* Start processing options with ARGV-element 1 (since ARGV-element 0
is the program name); the sequence of previously skipped
non-option ARGV-elements is empty. */
first_nonopt = last_nonopt = vlc_optind = 1;
nextchar = NULL;
const char *posixly_correct = getenv("POSIXLY_CORRECT");
/* Determine how to handle the ordering of options and nonoptions. */
if (posixly_correct != NULL)
ordering = REQUIRE_ORDER;
else
ordering = PERMUTE;
return optstring;
}
/* Scan elements of ARGV (whose length is ARGC) for option characters /* Scan elements of ARGV (whose length is ARGC) for option characters
given in OPTSTRING. given in OPTSTRING.
...@@ -268,8 +204,12 @@ int ...@@ -268,8 +204,12 @@ int
if (vlc_optind == 0) if (vlc_optind == 0)
{ {
optstring = vlc_getopt_initialize(optstring); /* Initialize the internal data when the first call is made. */
vlc_optind = 1; /* Don't scan ARGV[0], the program name. */ /* Start processing options with ARGV-element 1 (since ARGV-element 0
is the program name); the sequence of previously skipped
non-option ARGV-elements is empty. */
first_nonopt = last_nonopt = vlc_optind = 1;
nextchar = NULL;
} }
#define NONOPTION_P (argv[vlc_optind][0] != '-' || argv[vlc_optind][1] == '\0') #define NONOPTION_P (argv[vlc_optind][0] != '-' || argv[vlc_optind][1] == '\0')
...@@ -285,8 +225,6 @@ int ...@@ -285,8 +225,6 @@ int
if (first_nonopt > vlc_optind) if (first_nonopt > vlc_optind)
first_nonopt = vlc_optind; first_nonopt = vlc_optind;
if (ordering == PERMUTE)
{
/* If we have just processed some options following some non-options, /* If we have just processed some options following some non-options,
exchange them so that the options come first. */ exchange them so that the options come first. */
...@@ -301,7 +239,6 @@ int ...@@ -301,7 +239,6 @@ int
while (vlc_optind < argc && NONOPTION_P) while (vlc_optind < argc && NONOPTION_P)
vlc_optind++; vlc_optind++;
last_nonopt = vlc_optind; last_nonopt = vlc_optind;
}
/* The special ARGV-element `--' means premature end of options. /* The special ARGV-element `--' means premature end of options.
Skip it like a null option, Skip it like a null option,
...@@ -338,8 +275,6 @@ int ...@@ -338,8 +275,6 @@ int
if (NONOPTION_P) if (NONOPTION_P)
{ {
if (ordering == REQUIRE_ORDER)
return -1;
vlc_optarg = argv[vlc_optind++]; vlc_optarg = argv[vlc_optind++];
return 1; return 1;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment