Skip to content

V
vlc-2-2
Commit 456bdd9f authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont
Browse files
Options

Fix two more calloc-based denial of service in the MP4 demux.

parent 4d12ba40
Show whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
modules/demux/mp4/mp4.c
View file @ 456bdd9f
...@@ -485,6 +485,8 @@ static int Open( vlc_object_t * p_this ) ...@@ -485,6 +485,8 @@ static int Open( vlc_object_t * p_this )
/* allocate memory */ /* allocate memory */
p_sys->track = calloc( p_sys->i_tracks, sizeof( mp4_track_t ) ); p_sys->track = calloc( p_sys->i_tracks, sizeof( mp4_track_t ) );
if( p_sys->track == NULL )
goto error;
memset( p_sys->track, 0, p_sys->i_tracks * sizeof( mp4_track_t ) ); memset( p_sys->track, 0, p_sys->i_tracks * sizeof( mp4_track_t ) );
/* Search the first chap reference (like quicktime) */ /* Search the first chap reference (like quicktime) */
...@@ -1232,6 +1234,8 @@ static int TrackCreateSamplesIndex( demux_t *p_demux, ...@@ -1232,6 +1234,8 @@ static int TrackCreateSamplesIndex( demux_t *p_demux,
p_demux_track->i_sample_size = 0; p_demux_track->i_sample_size = 0;
p_demux_track->p_sample_size = p_demux_track->p_sample_size =
calloc( p_demux_track->i_sample_count, sizeof( uint32_t ) ); calloc( p_demux_track->i_sample_count, sizeof( uint32_t ) );
if( p_demux_track->p_sample_size == NULL )
return VLC_ENOMEM;
for( i_sample = 0; i_sample < p_demux_track->i_sample_count; i_sample++ ) for( i_sample = 0; i_sample < p_demux_track->i_sample_count; i_sample++ )
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment