Commit 427d59f4 authored by Rémi Denis-Courmont's avatar Rémi Denis-Courmont

xlib: don't abort if autodetection fails

parent bdde76df
...@@ -28,29 +28,29 @@ ...@@ -28,29 +28,29 @@
static inline bool vlc_xlib_init (vlc_object_t *obj) static inline bool vlc_xlib_init (vlc_object_t *obj)
{ {
if (!var_InheritBool (obj, "xlib"))
return false;
bool ok = false; bool ok = false;
if (var_InheritBool (obj, "xlib"))
{
/* XInitThreads() can be called multiple times, /* XInitThreads() can be called multiple times,
* but it is not reentrant, so we need this global lock. */ * but it is not reentrant, so we need this global lock. */
vlc_global_lock (VLC_XLIB_MUTEX); vlc_global_lock (VLC_XLIB_MUTEX);
if (_Xglobal_lock == NULL && unlikely(_XErrorFunction != NULL)) if (_Xglobal_lock == NULL && unlikely(_XErrorFunction != NULL))
{
/* (_Xglobal_lock == NULL) => Xlib threads not initialized */ /* (_Xglobal_lock == NULL) => Xlib threads not initialized */
/* (_XErrorFunction != NULL) => Xlib already in use */ /* (_XErrorFunction != NULL) => Xlib already in use */
fprintf (stderr, "%s:%u:%s: Xlib not initialized for threads.\n" fprintf (stderr, "%s:%u:%s: Xlib not initialized for threads.\n"
"This process is probably using LibVLC incorrectly.\n" "This process is probably using LibVLC incorrectly.\n"
"Pass \"--no-xlib\" to libvlc_new() to fix this.\n", "Pass \"--no-xlib\" to libvlc_new() to fix this.\n",
__FILE__, __LINE__, __func__); __FILE__, __LINE__, __func__);
/* Initiate core meltdown */ else if (XInitThreads ())
abort (); ok = true;
}
else
ok = XInitThreads () != 0;
vlc_global_unlock (VLC_XLIB_MUTEX); vlc_global_unlock (VLC_XLIB_MUTEX);
}
if (!ok)
msg_Err (obj, "Xlib not initialized for threads");
return ok; return ok;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment