Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-1.1
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-1.1
Commits
f2600dd0
Commit
f2600dd0
authored
Apr 01, 2009
by
Rémi Duraffort
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
macosx gui: fix a playlist object leak and use pl_release.
parent
65797af8
Changes
5
Expand all
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
58 additions
and
55 deletions
+58
-55
modules/gui/macosx/controls.m
modules/gui/macosx/controls.m
+6
-6
modules/gui/macosx/embeddedwindow.m
modules/gui/macosx/embeddedwindow.m
+1
-1
modules/gui/macosx/extended.m
modules/gui/macosx/extended.m
+3
-3
modules/gui/macosx/playlist.m
modules/gui/macosx/playlist.m
+47
-44
modules/gui/macosx/wizard.m
modules/gui/macosx/wizard.m
+1
-1
No files found.
modules/gui/macosx/controls.m
View file @
f2600dd0
...
@@ -235,7 +235,7 @@
...
@@ -235,7 +235,7 @@
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
vlc_object_release
(
p_playlist
);
pl_Release
(
p_intf
);
}
}
/* three little ugly helpers */
/* three little ugly helpers */
...
@@ -260,7 +260,7 @@
...
@@ -260,7 +260,7 @@
playlist_t
*
p_playlist
=
pl_Hold
(
VLCIntf
);
playlist_t
*
p_playlist
=
pl_Hold
(
VLCIntf
);
var_Get
(
p_playlist
,
"random"
,
&
val
);
var_Get
(
p_playlist
,
"random"
,
&
val
);
[
o_btn_shuffle
setState
:
val
.
b_bool
];
[
o_btn_shuffle
setState
:
val
.
b_bool
];
vlc_object_release
(
p_playlist
);
pl_Release
(
VLCIntf
);
}
}
-
(
IBAction
)
repeatButtonAction
:(
id
)
sender
-
(
IBAction
)
repeatButtonAction
:(
id
)
sender
...
@@ -327,7 +327,7 @@
...
@@ -327,7 +327,7 @@
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
vlc_object_release
(
p_playlist
);
pl_Release
(
p_intf
);
}
}
...
@@ -357,7 +357,7 @@
...
@@ -357,7 +357,7 @@
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
vlc_object_release
(
p_playlist
);
pl_Release
(
p_intf
);
}
}
-
(
IBAction
)
loop
:(
id
)
sender
-
(
IBAction
)
loop
:(
id
)
sender
...
@@ -386,7 +386,7 @@
...
@@ -386,7 +386,7 @@
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_playmode_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
p_intf
->
p_sys
->
b_intf_update
=
true
;
vlc_object_release
(
p_playlist
);
pl_Release
(
p_intf
);
}
}
-
(
IBAction
)
forward
:(
id
)
sender
-
(
IBAction
)
forward
:(
id
)
sender
...
@@ -1107,7 +1107,7 @@
...
@@ -1107,7 +1107,7 @@
}
}
if
(
p_input
)
vlc_object_release
(
p_input
);
if
(
p_input
)
vlc_object_release
(
p_input
);
vlc_object_release
(
p_playlist
);
pl_Release
(
p_intf
);
return
(
bEnabled
);
return
(
bEnabled
);
}
}
...
...
modules/gui/macosx/embeddedwindow.m
View file @
f2600dd0
...
@@ -160,7 +160,7 @@
...
@@ -160,7 +160,7 @@
playlist_t
*
p_playlist
=
pl_Hold
(
VLCIntf
);
playlist_t
*
p_playlist
=
pl_Hold
(
VLCIntf
);
playlist_Stop
(
p_playlist
);
playlist_Stop
(
p_playlist
);
vlc_object_release
(
p_playlist
);
pl_Release
(
VLCIntf
);
return
YES
;
return
YES
;
}
}
...
...
modules/gui/macosx/extended.m
View file @
f2600dd0
...
@@ -435,7 +435,7 @@ static VLCExtended *_o_sharedInstance = nil;
...
@@ -435,7 +435,7 @@ static VLCExtended *_o_sharedInstance = nil;
/* store to prefs */
/* store to prefs */
config_PutFloat
(
p_playlist
,
"macosx-opaqueness"
,
val
.
f_float
);
config_PutFloat
(
p_playlist
,
"macosx-opaqueness"
,
val
.
f_float
);
vlc_object_release
(
p_playlist
);
pl_Release
(
VLCIntf
);
o_config_changed
=
YES
;
o_config_changed
=
YES
;
}
}
...
@@ -784,7 +784,7 @@ static VLCExtended *_o_sharedInstance = nil;
...
@@ -784,7 +784,7 @@ static VLCExtended *_o_sharedInstance = nil;
"extended control attribute '%s' (%i)"
,
"extended control attribute '%s' (%i)"
,
[[
theModules
objectAtIndex
:
x
]
UTF8String
]
,
returnedValue
);
[[
theModules
objectAtIndex
:
x
]
UTF8String
]
,
returnedValue
);
[
theModules
release
];
[
theModules
release
];
vlc_object_release
(
p_playlist
);
pl_Release
(
VLCIntf
);
return
;
return
;
}
}
...
@@ -795,6 +795,6 @@ static VLCExtended *_o_sharedInstance = nil;
...
@@ -795,6 +795,6 @@ static VLCExtended *_o_sharedInstance = nil;
msg_Dbg
(
VLCIntf
,
"VLCExtended: saved certain preferences successfully"
);
msg_Dbg
(
VLCIntf
,
"VLCExtended: saved certain preferences successfully"
);
[
theModules
release
];
[
theModules
release
];
vlc_object_release
(
p_playlist
);
pl_Release
(
VLCIntf
);
}
}
@end
@end
modules/gui/macosx/playlist.m
View file @
f2600dd0
This diff is collapsed.
Click to expand it.
modules/gui/macosx/wizard.m
View file @
f2600dd0
...
@@ -1322,7 +1322,7 @@ static VLCWizard *_o_sharedInstance = nil;
...
@@ -1322,7 +1322,7 @@ static VLCWizard *_o_sharedInstance = nil;
x
+=
1
;
x
+=
1
;
}
}
vlc_object_release
(
p_playlist
);
pl_Release
(
p_intf
);
/* close the window, since we are done */
/* close the window, since we are done */
[
o_wizard_window
close
];
[
o_wizard_window
close
];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment