Commit d921e92a authored by Laurent Aimar's avatar Laurent Aimar

Fixed a race condition in video filter wrapper.

parent 00af33b4
...@@ -305,12 +305,14 @@ static int Init( vout_thread_t *p_vout ) ...@@ -305,12 +305,14 @@ static int Init( vout_thread_t *p_vout )
VoutsClean( p_vout, i ); VoutsClean( p_vout, i );
return VLC_EGENERIC; return VLC_EGENERIC;
} }
}
/* Attach once pp_vout is completly field to avoid race conditions */
for( int i = 0; i < p_splitter->i_output; i++ )
vout_filter_SetupChild( p_vout, p_sys->pp_vout[i], vout_filter_SetupChild( p_vout, p_sys->pp_vout[i],
MouseEvent, MouseEvent,
FullscreenEventUp, FullscreenEventDown, true ); FullscreenEventUp, FullscreenEventDown, true );
} }
}
vout_filter_AllocateDirectBuffers( p_vout, VOUT_MAX_PICTURES ); vout_filter_AllocateDirectBuffers( p_vout, VOUT_MAX_PICTURES );
...@@ -380,21 +382,19 @@ static void VoutsClean( vout_thread_t *p_vout, int i_count ) ...@@ -380,21 +382,19 @@ static void VoutsClean( vout_thread_t *p_vout, int i_count )
{ {
vout_sys_t *p_sys = p_vout->p_sys; vout_sys_t *p_sys = p_vout->p_sys;
/* Detach all vouts before destroying them */
for( int i = 0; i < i_count; i++ ) for( int i = 0; i < i_count; i++ )
{ {
if( p_sys->p_chain ) if( p_sys->p_chain )
{
assert( i == 0 );
vout_filter_DelChild( p_vout, p_sys->pp_vout[i], MouseEvent ); vout_filter_DelChild( p_vout, p_sys->pp_vout[i], MouseEvent );
}
else else
{
vout_filter_SetupChild( p_vout, p_sys->pp_vout[i], vout_filter_SetupChild( p_vout, p_sys->pp_vout[i],
MouseEvent, MouseEvent,
FullscreenEventUp, FullscreenEventDown, false ); FullscreenEventUp, FullscreenEventDown, false );
} }
for( int i = 0; i < i_count; i++ )
vout_CloseAndRelease( p_sys->pp_vout[i] ); vout_CloseAndRelease( p_sys->pp_vout[i] );
}
} }
static int VoutsNewPicture( vout_thread_t *p_vout, picture_t *pp_dst[] ) static int VoutsNewPicture( vout_thread_t *p_vout, picture_t *pp_dst[] )
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment