Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vlc-1.1
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Redmine
Redmine
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
videolan
vlc-1.1
Commits
9a31d3ab
Commit
9a31d3ab
authored
Jan 04, 2009
by
Laurent Aimar
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix unprotected access of input item (skins2).
parent
c1986e20
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
4 deletions
+8
-4
modules/gui/skins2/commands/cmd_update_item.cpp
modules/gui/skins2/commands/cmd_update_item.cpp
+8
-4
No files found.
modules/gui/skins2/commands/cmd_update_item.cpp
View file @
9a31d3ab
...
@@ -46,9 +46,10 @@ void CmdUpdateItem::execute()
...
@@ -46,9 +46,10 @@ void CmdUpdateItem::execute()
// Get playlist item information
// Get playlist item information
input_item_t
*
pItem
=
input_GetItem
(
p_input
);
input_item_t
*
pItem
=
input_GetItem
(
p_input
);
// XXX: we should not need to access p_input->psz_source directly, a
char
*
pszName
=
input_item_GetName
(
pItem
);
// getter should be provided by VLC core
char
*
pszUri
=
input_item_GetURI
(
pItem
);
string
name
=
pItem
->
psz_name
;
string
name
=
pszName
;
// XXX: This should be done in VLC core, not here...
// XXX: This should be done in VLC core, not here...
// Remove path information if any
// Remove path information if any
OSFactory
*
pFactory
=
OSFactory
::
instance
(
getIntf
()
);
OSFactory
*
pFactory
=
OSFactory
::
instance
(
getIntf
()
);
...
@@ -58,7 +59,10 @@ void CmdUpdateItem::execute()
...
@@ -58,7 +59,10 @@ void CmdUpdateItem::execute()
name
=
name
.
substr
(
pos
+
1
,
name
.
size
()
-
pos
+
1
);
name
=
name
.
substr
(
pos
+
1
,
name
.
size
()
-
pos
+
1
);
}
}
UString
srcName
(
getIntf
(),
name
.
c_str
()
);
UString
srcName
(
getIntf
(),
name
.
c_str
()
);
UString
srcURI
(
getIntf
(),
pItem
->
psz_uri
);
UString
srcURI
(
getIntf
(),
pszUri
);
free
(
pszName
);
free
(
pszUri
);
// Create commands to update the stream variables
// Create commands to update the stream variables
CmdSetText
*
pCmd1
=
new
CmdSetText
(
getIntf
(),
m_rStreamName
,
srcName
);
CmdSetText
*
pCmd1
=
new
CmdSetText
(
getIntf
(),
m_rStreamName
,
srcName
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment